Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()
On Tue, 23 May 2023 21:50:53 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
>
> [...]
Applied to powerpc/next.
[1/1] macintosh: Switch i2c drivers back to use .probe()
https://git.kernel.org/powerpc/c/922db7c571f55b1eab2d2c5da14d150aff1d0252
cheers
Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()
Uwe Kleine-König writes:
> On Tue, May 23, 2023 at 09:50:53PM +0200, Uwe Kleine-König wrote:
>> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
>> call-back type"), all drivers being converted to .probe_new() and then
>> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
>> back to (the new) .probe() to be able to eventually drop .probe_new() from
>> struct i2c_driver.
>>
>> Signed-off-by: Uwe Kleine-König
>> ---
>> Hello,
>>
>> this patch was generated using coccinelle, but I aligned the result to
>> the per-file indention.
>>
>> I chose to convert all drivers below drivers/macintosh in a single
>> patch, but if you prefer I can split by driver.
>>
>> v6.4-rc1 was taken as a base, as there are no commits in next touching
>> drivers/macintosh I don't expect problems when applying this patch. If
>> conflicts arise until this is applied, feel free to just drop the files
>> with conflicts from this patch. I'll care about the fallout later then.
>>
>> Also note there is no coordination necessary with the i2c tree. Dropping
>> .probe_new() will happen only when all (or most) drivers are converted,
>> which will happen after v6.5-rc1 for sure.
>
> Can someone still pick up this patch for v6.5-rc1?
Yes, I will.
cheers
Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()
Hello,
On Tue, May 23, 2023 at 09:50:53PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König
> ---
> Hello,
>
> this patch was generated using coccinelle, but I aligned the result to
> the per-file indention.
>
> I chose to convert all drivers below drivers/macintosh in a single
> patch, but if you prefer I can split by driver.
>
> v6.4-rc1 was taken as a base, as there are no commits in next touching
> drivers/macintosh I don't expect problems when applying this patch. If
> conflicts arise until this is applied, feel free to just drop the files
> with conflicts from this patch. I'll care about the fallout later then.
>
> Also note there is no coordination necessary with the i2c tree. Dropping
> .probe_new() will happen only when all (or most) drivers are converted,
> which will happen after v6.5-rc1 for sure.
Can someone still pick up this patch for v6.5-rc1? I intend to send a
pull request to Wolfram's i2c-tree that drops .probe_new() from struct
i2c_driver on top of v6.5-rc1 early after the merge window closes. So
getting this in before would be great. Otherwise I'm happily adding
received acks to this patch for my PR :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()
On Tue, 23 May 2023 21:50:53 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König
> ---
> Hello,
>
> this patch was generated using coccinelle, but I aligned the result to
> the per-file indention.
>
> I chose to convert all drivers below drivers/macintosh in a single
> patch, but if you prefer I can split by driver.
>
> v6.4-rc1 was taken as a base, as there are no commits in next touching
> drivers/macintosh I don't expect problems when applying this patch. If
> conflicts arise until this is applied, feel free to just drop the files
> with conflicts from this patch. I'll care about the fallout later then.
>
> Also note there is no coordination necessary with the i2c tree. Dropping
> .probe_new() will happen only when all (or most) drivers are converted,
> which will happen after v6.5-rc1 for sure.
>
> Best regards
> Uwe
>
> drivers/macintosh/ams/ams-i2c.c | 2 +-
> drivers/macintosh/therm_adt746x.c | 2 +-
> drivers/macintosh/therm_windtunnel.c| 2 +-
> drivers/macintosh/windfarm_ad7417_sensor.c | 2 +-
> drivers/macintosh/windfarm_fcu_controls.c | 2 +-
> drivers/macintosh/windfarm_lm75_sensor.c| 2 +-
> drivers/macintosh/windfarm_lm87_sensor.c| 2 +-
> drivers/macintosh/windfarm_max6690_sensor.c | 2 +-
> drivers/macintosh/windfarm_smu_sat.c| 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
> (...)
Reviewed-by: Jean Delvare
--
Jean Delvare
SUSE L3 Support
Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()
On Tue, May 23, 2023 at 09:50:53PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Dmitry Torokhov
Thanks.
--
Dmitry
