Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform
On Mon, Jun 28, 2021 at 11:58:54AM +0530, kajoljain wrote: > > > On 6/25/21 6:51 PM, Paul A. Clarke wrote: > > On Fri, Jun 25, 2021 at 05:29:48PM +0530, Kajol Jain wrote: > >> Patch adds 24x7 nest metric events for POWER10. > >> > >> Signed-off-by: Kajol Jain > >> --- > >> .../arch/powerpc/power10/nest_metrics.json| 491 ++ > >> 1 file changed, 491 insertions(+) > >> create mode 100644 > >> tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > >> > >> diff --git a/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > >> b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > >> new file mode 100644 > >> index ..b79046cd8b09 > >> --- /dev/null > >> +++ b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > >> @@ -0,0 +1,491 @@ > >> +[ > >> +{ > >> + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P01", > >> + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P01", > > > > Is it possible to get better descriptions than just a restatement of the > > name, or no description at all? > > > > This comment obviously applies to almost all of the metrics herein. > > Hi Paul, >Thanks for reviewing the patch. Sure I will remove description part for > now. My sentence didn't parse well, sorry... What I really meant was more like "Is it possible to get better descriptions? Having just a restatement of the name (or no description at all in some cases) is not helpful." So, can we provide better descriptions of the metrics? PC
Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform
On 6/25/21 6:51 PM, Paul A. Clarke wrote: > On Fri, Jun 25, 2021 at 05:29:48PM +0530, Kajol Jain wrote: >> Patch adds 24x7 nest metric events for POWER10. >> >> Signed-off-by: Kajol Jain >> --- >> .../arch/powerpc/power10/nest_metrics.json| 491 ++ >> 1 file changed, 491 insertions(+) >> create mode 100644 >> tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json >> >> diff --git a/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json >> b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json >> new file mode 100644 >> index ..b79046cd8b09 >> --- /dev/null >> +++ b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json >> @@ -0,0 +1,491 @@ >> +[ >> +{ >> + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P01", >> + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P01", > > Is it possible to get better descriptions than just a restatement of the > name, or no description at all? > > This comment obviously applies to almost all of the metrics herein. Hi Paul, Thanks for reviewing the patch. Sure I will remove description part for now. > >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_VG_PUMP01\\,chip\\=?@ / >> hv_24x7@PM_PB_VG_PUMP01\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P23", >> + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P23", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_VG_PUMP23\\,chip\\=?@ / >> hv_24x7@PM_PB_VG_PUMP23\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "LOCAL_NODE_PUMP_RETRY_RATIO_P01", >> + "BriefDescription": "LOCAL_NODE_PUMP_RETRY_RATIO_P01", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_LNS_PUMP01\\,chip\\=?@ / >> hv_24x7@PM_PB_LNS_PUMP01\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "LOCAL_NODE_PUMP_RETRY_RATIO_P23", >> + "BriefDescription": "LOCAL_NODE_PUMP_RETRY_RATIO_P23", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_LNS_PUMP23\\,chip\\=?@ / >> hv_24x7@PM_PB_LNS_PUMP23\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "GROUP_PUMP_RETRY_RATIO_P01", >> + "BriefDescription": "GROUP_PUMP_RETRY_RATIO_P01", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP01\\,chip\\=?@ / >> hv_24x7@PM_PB_GROUP_PUMP01\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "GROUP_PUMP_RETRY_RATIO_P23", >> + "BriefDescription": "GROUP_PUMP_RETRY_RATIO_P23", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP23\\,chip\\=?@ / >> hv_24x7@PM_PB_GROUP_PUMP23\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "TOTAL_GROUP_PUMPS_P01", >> + "BriefDescription": "TOTAL_GROUP_PUMPS_P01(PER-CYC)", >> + "MetricExpr": "(hv_24x7@PM_PB_GROUP_PUMP01\\,chip\\=?@ / >> hv_24x7@PM_PAU_CYC\\,chip\\=?@)", >> + "ScaleUnit": "4", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "TOTAL_GROUP_PUMPS_P23", >> + "BriefDescription": "TOTAL_GROUP_PUMPS_P23(PER-CYC)", >> + "MetricExpr": "(hv_24x7@PM_PB_GROUP_PUMP23\\,chip\\=?@ / >> hv_24x7@PM_PAU_CYC\\,chip\\=?@)", >> + "ScaleUnit": "4", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "TOTAL_GROUP_PUMPS_RETRIES_P01", >> + "BriefDescription": "TOTAL_GROUP_PUMPS_RETRIES_P01(PER-CYC)", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP01\\,chip\\=?@ / >> hv_24x7@PM_PAU_CYC\\,chip\\=?@)", >> + "ScaleUnit": "4", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "TOTAL_GROUP_PUMPS_RETRIES_P23", >> + "BriefDescription": "TOTAL_GROUP_PUMPS_RETRIES_P23(PER-CYC)", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP23\\,chip\\=?@ / >> hv_24x7@PM_PAU_CYC\\,chip\\=?@)", >> + "ScaleUnit": "4", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P01", >> + "BriefDescription": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P01", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_RNS_PUMP01\\,chip\\=?@ / >> hv_24x7@PM_PB_RNS_PUMP01\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P23", >> + "BriefDescription": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P23", >> + "MetricExpr": "(hv_24x7@PM_PB_RTY_RNS_PUMP23\\,chip\\=?@ / >> hv_24x7@PM_PB_RNS_PUMP23\\,chip\\=?@) * 100", >> + "ScaleUnit": "1%", >> + "AggregationMode": "PerChip" >> +}, >> +{ >> + "MetricName": "TOTAL_VECTOR_GROUP_PUMPS_P01", >> +
Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform
Test scenarios: 1. With 'perf list metric' and 'perf list metricgroup' - can see metrics 2. Run all the metrics with perf stat with -M option and --metric-only -M option The above test scenarios automated with avocado framework, pull request title: perf_metric.py: Add perf metric test case Output from automated test script run: (1/2) perf_metric.py:perf_metric.test_all_metric_events_with_M: PASS (89.83 s) (2/2) perf_metric.py:perf_metric.test_all_metric_events_with_metric: PASS (89.34 s) Tested-by: Nageswara R Sastry On 25/06/21 5:29 pm, Kajol Jain wrote: Patch adds 24x7 nest metric events for POWER10. Signed-off-by: Kajol Jain --- .../arch/powerpc/power10/nest_metrics.json| 491 ++ 1 file changed, 491 insertions(+) create mode 100644 tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json diff --git a/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json new file mode 100644 index ..b79046cd8b09 --- /dev/null +++ b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json @@ -0,0 +1,491 @@ +[ +{ + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P01", + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P01", + "MetricExpr": "(hv_24x7@PM_PB_RTY_VG_PUMP01\\,chip\\=?@ / hv_24x7@PM_PB_VG_PUMP01\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P23", + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P23", + "MetricExpr": "(hv_24x7@PM_PB_RTY_VG_PUMP23\\,chip\\=?@ / hv_24x7@PM_PB_VG_PUMP23\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "LOCAL_NODE_PUMP_RETRY_RATIO_P01", + "BriefDescription": "LOCAL_NODE_PUMP_RETRY_RATIO_P01", + "MetricExpr": "(hv_24x7@PM_PB_RTY_LNS_PUMP01\\,chip\\=?@ / hv_24x7@PM_PB_LNS_PUMP01\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "LOCAL_NODE_PUMP_RETRY_RATIO_P23", + "BriefDescription": "LOCAL_NODE_PUMP_RETRY_RATIO_P23", + "MetricExpr": "(hv_24x7@PM_PB_RTY_LNS_PUMP23\\,chip\\=?@ / hv_24x7@PM_PB_LNS_PUMP23\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "GROUP_PUMP_RETRY_RATIO_P01", + "BriefDescription": "GROUP_PUMP_RETRY_RATIO_P01", + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP01\\,chip\\=?@ / hv_24x7@PM_PB_GROUP_PUMP01\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "GROUP_PUMP_RETRY_RATIO_P23", + "BriefDescription": "GROUP_PUMP_RETRY_RATIO_P23", + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP23\\,chip\\=?@ / hv_24x7@PM_PB_GROUP_PUMP23\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "TOTAL_GROUP_PUMPS_P01", + "BriefDescription": "TOTAL_GROUP_PUMPS_P01(PER-CYC)", + "MetricExpr": "(hv_24x7@PM_PB_GROUP_PUMP01\\,chip\\=?@ / hv_24x7@PM_PAU_CYC\\,chip\\=?@)", + "ScaleUnit": "4", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "TOTAL_GROUP_PUMPS_P23", + "BriefDescription": "TOTAL_GROUP_PUMPS_P23(PER-CYC)", + "MetricExpr": "(hv_24x7@PM_PB_GROUP_PUMP23\\,chip\\=?@ / hv_24x7@PM_PAU_CYC\\,chip\\=?@)", + "ScaleUnit": "4", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "TOTAL_GROUP_PUMPS_RETRIES_P01", + "BriefDescription": "TOTAL_GROUP_PUMPS_RETRIES_P01(PER-CYC)", + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP01\\,chip\\=?@ / hv_24x7@PM_PAU_CYC\\,chip\\=?@)", + "ScaleUnit": "4", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "TOTAL_GROUP_PUMPS_RETRIES_P23", + "BriefDescription": "TOTAL_GROUP_PUMPS_RETRIES_P23(PER-CYC)", + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP23\\,chip\\=?@ / hv_24x7@PM_PAU_CYC\\,chip\\=?@)", + "ScaleUnit": "4", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P01", + "BriefDescription": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P01", + "MetricExpr": "(hv_24x7@PM_PB_RTY_RNS_PUMP01\\,chip\\=?@ / hv_24x7@PM_PB_RNS_PUMP01\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P23", + "BriefDescription": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P23", + "MetricExpr": "(hv_24x7@PM_PB_RTY_RNS_PUMP23\\,chip\\=?@ / hv_24x7@PM_PB_RNS_PUMP23\\,chip\\=?@) * 100", + "ScaleUnit": "1%", + "AggregationMode": "PerChip" +}, +{ + "MetricName": "TOTAL_VECTOR_GROUP_PUMPS_P01", + "BriefDescription": "TOTAL_VECTOR_GROUP_PUMPS_P01(PER-CYC)", + "MetricExpr": "(hv_24x7@PM_PB_VG_PUMP01\\,chip\\=?@ /
Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform
On Fri, Jun 25, 2021 at 05:29:48PM +0530, Kajol Jain wrote: > Patch adds 24x7 nest metric events for POWER10. > > Signed-off-by: Kajol Jain > --- > .../arch/powerpc/power10/nest_metrics.json| 491 ++ > 1 file changed, 491 insertions(+) > create mode 100644 > tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > > diff --git a/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > new file mode 100644 > index ..b79046cd8b09 > --- /dev/null > +++ b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json > @@ -0,0 +1,491 @@ > +[ > +{ > + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P01", > + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P01", Is it possible to get better descriptions than just a restatement of the name, or no description at all? This comment obviously applies to almost all of the metrics herein. > + "MetricExpr": "(hv_24x7@PM_PB_RTY_VG_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PB_VG_PUMP01\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P23", > + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P23", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_VG_PUMP23\\,chip\\=?@ / > hv_24x7@PM_PB_VG_PUMP23\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "LOCAL_NODE_PUMP_RETRY_RATIO_P01", > + "BriefDescription": "LOCAL_NODE_PUMP_RETRY_RATIO_P01", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_LNS_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PB_LNS_PUMP01\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "LOCAL_NODE_PUMP_RETRY_RATIO_P23", > + "BriefDescription": "LOCAL_NODE_PUMP_RETRY_RATIO_P23", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_LNS_PUMP23\\,chip\\=?@ / > hv_24x7@PM_PB_LNS_PUMP23\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "GROUP_PUMP_RETRY_RATIO_P01", > + "BriefDescription": "GROUP_PUMP_RETRY_RATIO_P01", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PB_GROUP_PUMP01\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "GROUP_PUMP_RETRY_RATIO_P23", > + "BriefDescription": "GROUP_PUMP_RETRY_RATIO_P23", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP23\\,chip\\=?@ / > hv_24x7@PM_PB_GROUP_PUMP23\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "TOTAL_GROUP_PUMPS_P01", > + "BriefDescription": "TOTAL_GROUP_PUMPS_P01(PER-CYC)", > + "MetricExpr": "(hv_24x7@PM_PB_GROUP_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PAU_CYC\\,chip\\=?@)", > + "ScaleUnit": "4", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "TOTAL_GROUP_PUMPS_P23", > + "BriefDescription": "TOTAL_GROUP_PUMPS_P23(PER-CYC)", > + "MetricExpr": "(hv_24x7@PM_PB_GROUP_PUMP23\\,chip\\=?@ / > hv_24x7@PM_PAU_CYC\\,chip\\=?@)", > + "ScaleUnit": "4", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "TOTAL_GROUP_PUMPS_RETRIES_P01", > + "BriefDescription": "TOTAL_GROUP_PUMPS_RETRIES_P01(PER-CYC)", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PAU_CYC\\,chip\\=?@)", > + "ScaleUnit": "4", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "TOTAL_GROUP_PUMPS_RETRIES_P23", > + "BriefDescription": "TOTAL_GROUP_PUMPS_RETRIES_P23(PER-CYC)", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_GROUP_PUMP23\\,chip\\=?@ / > hv_24x7@PM_PAU_CYC\\,chip\\=?@)", > + "ScaleUnit": "4", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P01", > + "BriefDescription": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P01", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_RNS_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PB_RNS_PUMP01\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P23", > + "BriefDescription": "REMOTE_NODE_PUMPS_RETRIES_RATIO_P23", > + "MetricExpr": "(hv_24x7@PM_PB_RTY_RNS_PUMP23\\,chip\\=?@ / > hv_24x7@PM_PB_RNS_PUMP23\\,chip\\=?@) * 100", > + "ScaleUnit": "1%", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName": "TOTAL_VECTOR_GROUP_PUMPS_P01", > + "BriefDescription": "TOTAL_VECTOR_GROUP_PUMPS_P01(PER-CYC)", > + "MetricExpr": "(hv_24x7@PM_PB_VG_PUMP01\\,chip\\=?@ / > hv_24x7@PM_PAU_CYC\\,chip\\=?@)", > + "ScaleUnit": "4", > + "AggregationMode": "PerChip" > +}, > +{ > + "MetricName":