Re: [PATCH] powerpc/85xx: Update smp support to handle doorbells and non-mpic init

2009-03-11 Thread Scott Wood 
On Wed, Mar 11, 2009 at 06:46:03AM -0500, Kumar Gala wrote:
 +void __init mpc85xx_smp_init(void)
 +{
 + struct device_node *np;
 +
 + smp_85xx_ops.message_pass = NULL;
 +
 + np = of_find_node_by_type(NULL, open-pic);

We should probably look by compatible rather than device_type.  I see
only one device tree that has the latter but not the former (ksi8560),
and it's not SMP (but should still be fixed, of course).

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc/85xx: Update smp support to handle doorbells and non-mpic init

2009-03-11 Thread Kumar Gala 


On Mar 11, 2009, at 10:52 AM, Scott Wood wrote:


On Wed, Mar 11, 2009 at 06:46:03AM -0500, Kumar Gala wrote:

+void __init mpc85xx_smp_init(void)
+{
+   struct device_node *np;
+
+   smp_85xx_ops.message_pass = NULL;
+
+   np = of_find_node_by_type(NULL, open-pic);


We should probably look by compatible rather than device_type.  I see
only one device tree that has the latter but not the former (ksi8560),
and it's not SMP (but should still be fixed, of course).


Ever other lookup for the mpic node is done by type.  I see no reason  
to change this right now.


- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev