Re: [PATCH] powerpc/fadump: Remove duplicate message.
On Thu, Oct 24, 2019 at 01:16:51PM +0200, Michal Suchánek wrote: > On Thu, Oct 24, 2019 at 04:08:08PM +0530, Hari Bathini wrote: > > > > Michal, thanks for looking into this. > > > > On 23/10/19 11:26 PM, Michal Suchanek wrote: > > > There is duplicate message about lack of support by firmware in > > > fadump_reserve_mem and setup_fadump. Due to different capitalization it > > > is clear that the one in setup_fadump is shown on boot. Remove the > > > duplicate that is not shown. > > > > Actually, the message in fadump_reserve_mem() is logged. > > fadump_reserve_mem() > > executes first and sets fw_dump.fadump_enabled to `0`, if fadump is not > > supported. > > So, the other message in setup_fadump() doesn't get logged anymore with > > recent > > changes. The right thing to do would be to remove similar message in > > setup_fadump() instead. > > I need to re-check with a recent kernel build. I saw the message from > setup_fadump and not the one from fadump_reserve_mem but not sure what > the platform init code looked like in the kernel I tested with. Indeed, I was missing the patch that changes the capitalization in fadump_reserve_mem. In my kernel both messages are the same and the one from fadump_reserve_mem is displayed. Thanks Michal
Re: [PATCH] powerpc/fadump: Remove duplicate message.
On Thu, Oct 24, 2019 at 04:08:08PM +0530, Hari Bathini wrote: > > Michal, thanks for looking into this. > > On 23/10/19 11:26 PM, Michal Suchanek wrote: > > There is duplicate message about lack of support by firmware in > > fadump_reserve_mem and setup_fadump. Due to different capitalization it > > is clear that the one in setup_fadump is shown on boot. Remove the > > duplicate that is not shown. > > Actually, the message in fadump_reserve_mem() is logged. fadump_reserve_mem() > executes first and sets fw_dump.fadump_enabled to `0`, if fadump is not > supported. > So, the other message in setup_fadump() doesn't get logged anymore with recent > changes. The right thing to do would be to remove similar message in > setup_fadump() instead. I need to re-check with a recent kernel build. I saw the message from setup_fadump and not the one from fadump_reserve_mem but not sure what the platform init code looked like in the kernel I tested with. Thanks Michal
Re: [PATCH] powerpc/fadump: Remove duplicate message.
Michal, thanks for looking into this. On 23/10/19 11:26 PM, Michal Suchanek wrote: > There is duplicate message about lack of support by firmware in > fadump_reserve_mem and setup_fadump. Due to different capitalization it > is clear that the one in setup_fadump is shown on boot. Remove the > duplicate that is not shown. Actually, the message in fadump_reserve_mem() is logged. fadump_reserve_mem() executes first and sets fw_dump.fadump_enabled to `0`, if fadump is not supported. So, the other message in setup_fadump() doesn't get logged anymore with recent changes. The right thing to do would be to remove similar message in setup_fadump() instead. - Hari
