Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c

2009-03-11 Thread Grant Likely 
On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel  wrote:
> A semicolon at the end of the macro means that the for loop has an
> empty body, and so TSEC/MDIO will not work with older device trees.
>
> This fix only applies to 2.6.28; apparently, this code is gone for
> 2.6.29, according to Grant Likely!
>
> Signed-off-by: Johns Daniel 

Acked-by: Grant Likely 

Greg:  Andy Flemming should probably confirm this, but I think this
one should be backported to the stable series.

g.

> ---
> --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
> 16:41:27.0 -0600
> +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-10
> 15:56:47.0 -0500
> @@ -257,7 +257,7 @@
>                gfar_mdio_of_init_one(np);
>
>        /* try the deprecated version */
> -       for_each_compatible_node(np, "mdio", "gianfar");
> +       for_each_compatible_node(np, "mdio", "gianfar")
>                gfar_mdio_of_init_one(np);
>
>        return 0;
> ---
> ___
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c

2009-03-12 Thread Greg KH 
On Wed, Mar 11, 2009 at 10:03:22AM -0600, Grant Likely wrote:
> On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel  wrote:
> > A semicolon at the end of the macro means that the for loop has an
> > empty body, and so TSEC/MDIO will not work with older device trees.
> >
> > This fix only applies to 2.6.28; apparently, this code is gone for
> > 2.6.29, according to Grant Likely!
> >
> > Signed-off-by: Johns Daniel 
> 
> Acked-by: Grant Likely 
> 
> Greg:  Andy Flemming should probably confirm this, but I think this
> one should be backported to the stable series.

Hm, this patch is line-wrapped and tabs are stripped, so I can't apply
it :(

Anyone care to resend it?

thanks,

greg k-h

> > ---
> > --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
> > 16:41:27.0 -0600
> > +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-10
> > 15:56:47.0 -0500
> > @@ -257,7 +257,7 @@
> >                gfar_mdio_of_init_one(np);
> >
> >        /* try the deprecated version */
> > -       for_each_compatible_node(np, "mdio", "gianfar");
> > +       for_each_compatible_node(np, "mdio", "gianfar")
> >                gfar_mdio_of_init_one(np);
> >
> >        return 0;
> > ---
> > ___
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> >
> 
> 
> 
> -- 
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try)

2009-03-14 Thread Grant Likely 
On Sat, Mar 14, 2009 at 9:03 AM, Johns Daniel  wrote:
> TSEC/MDIO will not work with older device trees because of a semicolon at
> the end of a macro resulting in an empty for loop body.
>
> This fix only applies to 2.6.28; this code is gone in 2.6.29, according to
> Grant Likely!
>
> Signed-off-by: Johns Daniel  >

Your signed-off-by line is odd.  I assume your mailer did this to you.
 But in case Greg picks it up anyway:

Acked-by: Grant Likely 

> ==
>
> --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
> 16:41:27.0 -0600
> +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-14
> 09:01:38.994630400 -0500
> @@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void
>                gfar_mdio_of_init_one(np);
>
>        /* try the deprecated version */
> -       for_each_compatible_node(np, "mdio", "gianfar");
> +       for_each_compatible_node(np, "mdio", "gianfar")
>                gfar_mdio_of_init_one(np);
>
>        return 0;
>
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev