Re: [PATCH] powerpc: Use generic PHY driver for Marvell 88E1111 PHY on GE Fanuc SBC610

2008-11-19 Thread Kumar Gala


On Nov 18, 2008, at 4:55 AM, Martyn Welch wrote:


The Marvell PHY driver is currently being used for the 88E on the
SBC610. This driver is causing the link to run in 10/Half mode, the  
generic

PHY driver is correctly configuring the PHY as 1000/Full.

Edit default config to use generic PHY driver.

Signed-off-by: Martyn Welch [EMAIL PROTECTED]
---

Agh! My mistake - forgot to add Signed-off, sorry.

arch/powerpc/configs/86xx/gef_sbc610_defconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


applied to merge.

(I still think you should fix it to work with the proper driver).

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH] powerpc: Use generic PHY driver for Marvell 88E1111 PHY on GE Fanuc SBC610

2008-11-18 Thread Kumar Gala


On Nov 18, 2008, at 4:55 AM, Martyn Welch wrote:


The Marvell PHY driver is currently being used for the 88E on the
SBC610. This driver is causing the link to run in 10/Half mode, the  
generic

PHY driver is correctly configuring the PHY as 1000/Full.

Edit default config to use generic PHY driver.

Signed-off-by: Martyn Welch [EMAIL PROTECTED]
---

Agh! My mistake - forgot to add Signed-off, sorry.

arch/powerpc/configs/86xx/gef_sbc610_defconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


hmm.. why not fix the issue with the 88e driver.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH] powerpc: Use generic PHY driver for Marvell 88E1111 PHY on GE Fanuc SBC610

2008-11-18 Thread Martyn Welch
On Tue, 18 Nov 2008 07:39:21 -0600
Kumar Gala [EMAIL PROTECTED] wrote:
 
 On Nov 18, 2008, at 4:55 AM, Martyn Welch wrote:
 
  The Marvell PHY driver is currently being used for the 88E on the
  SBC610. This driver is causing the link to run in 10/Half mode, the  
  generic
  PHY driver is correctly configuring the PHY as 1000/Full.
 
  Edit default config to use generic PHY driver.
 
  Signed-off-by: Martyn Welch [EMAIL PROTECTED]
  ---
 
  Agh! My mistake - forgot to add Signed-off, sorry.
 
  arch/powerpc/configs/86xx/gef_sbc610_defconfig |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 hmm.. why not fix the issue with the 88e driver.
 

Two reasons really:

1) We don't use any of the non-generic features of the PHY.
2) Networking is really _not_ my forte.

As a result, it's not itching ;-)

Martyn

-- 
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,|Registered in England and Wales
Tove Valley Business Park, Towcester,  |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 729849476
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev