Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
Le 01/07/2023 à 07:46, Randy Dunlap a écrit :
>
>
> On 6/9/23 20:11, Randy Dunlap wrote:
>> Hi--
>>
>> On 5/16/23 11:54, Pali Rohár wrote:
>>> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
In a randconfig with CONFIG_SERIAL_CPM=m and
CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko]
undefined!
Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
SERIAL_CPM=y.
Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial
ports.")
Signed-off-by: Randy Dunlap
Cc: Scott Wood
Cc: Kumar Gala
Cc: "Pali Rohár"
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: linuxppc-dev@lists.ozlabs.org
>>>
>>> Looks good,
>>>
>>> Reviewed-by: Pali Rohár
>>
>> I'm still seeing this build error in linux-next even with other (PPC) CPM
>> patches applied.
>>
>
> Patchwork shows status as Superseded:
>
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdun...@infradead.org/
>
> but I don't understand why or by what.
Neither do I. I must have made a mistake but I can't remember.
>
> I'm going to resubmit the patch now.
Fine, then the previous is really superseeded now.
Christophe
>
>
>>>
---
arch/powerpc/Kconfig.debug |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
--- a/arch/powerpc/Kconfig.debug
+++ b/arch/powerpc/Kconfig.debug
@@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
config PPC_EARLY_DEBUG_CPM
bool "Early serial debugging for Freescale CPM-based serial ports"
- depends on SERIAL_CPM
+ depends on SERIAL_CPM=y
help
Select this to enable early debugging for Freescale chips
using a CPM-based serial port. This assumes that the bootwrapper
>>
>
Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
On 6/9/23 20:11, Randy Dunlap wrote:
> Hi--
>
> On 5/16/23 11:54, Pali Rohár wrote:
>> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
>>> In a randconfig with CONFIG_SERIAL_CPM=m and
>>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
>>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko]
>>> undefined!
>>>
>>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
>>> SERIAL_CPM=y.
>>>
>>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial
>>> ports.")
>>> Signed-off-by: Randy Dunlap
>>> Cc: Scott Wood
>>> Cc: Kumar Gala
>>> Cc: "Pali Rohár"
>>> Cc: Michael Ellerman
>>> Cc: Nicholas Piggin
>>> Cc: Christophe Leroy
>>> Cc: linuxppc-dev@lists.ozlabs.org
>>
>> Looks good,
>>
>> Reviewed-by: Pali Rohár
>
> I'm still seeing this build error in linux-next even with other (PPC) CPM
> patches applied.
>
Patchwork shows status as Superseded:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdun...@infradead.org/
but I don't understand why or by what.
I'm going to resubmit the patch now.
>>
>>> ---
>>> arch/powerpc/Kconfig.debug |2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>>> --- a/arch/powerpc/Kconfig.debug
>>> +++ b/arch/powerpc/Kconfig.debug
>>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>>>
>>> config PPC_EARLY_DEBUG_CPM
>>> bool "Early serial debugging for Freescale CPM-based serial ports"
>>> - depends on SERIAL_CPM
>>> + depends on SERIAL_CPM=y
>>> help
>>> Select this to enable early debugging for Freescale chips
>>> using a CPM-based serial port. This assumes that the bootwrapper
>
--
~Randy
Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
Hi--
On 5/16/23 11:54, Pali Rohár wrote:
> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
>> In a randconfig with CONFIG_SERIAL_CPM=m and
>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko]
>> undefined!
>>
>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
>> SERIAL_CPM=y.
>>
>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial
>> ports.")
>> Signed-off-by: Randy Dunlap
>> Cc: Scott Wood
>> Cc: Kumar Gala
>> Cc: "Pali Rohár"
>> Cc: Michael Ellerman
>> Cc: Nicholas Piggin
>> Cc: Christophe Leroy
>> Cc: linuxppc-dev@lists.ozlabs.org
>
> Looks good,
>
> Reviewed-by: Pali Rohár
I'm still seeing this build error in linux-next even with other (PPC) CPM
patches applied.
>
>> ---
>> arch/powerpc/Kconfig.debug |2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>> --- a/arch/powerpc/Kconfig.debug
>> +++ b/arch/powerpc/Kconfig.debug
>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>>
>> config PPC_EARLY_DEBUG_CPM
>> bool "Early serial debugging for Freescale CPM-based serial ports"
>> -depends on SERIAL_CPM
>> +depends on SERIAL_CPM=y
>> help
>>Select this to enable early debugging for Freescale chips
>>using a CPM-based serial port. This assumes that the bootwrapper
--
~Randy
Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
> In a randconfig with CONFIG_SERIAL_CPM=m and
> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko]
> undefined!
>
> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
> SERIAL_CPM=y.
>
> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial
> ports.")
> Signed-off-by: Randy Dunlap
> Cc: Scott Wood
> Cc: Kumar Gala
> Cc: "Pali Rohár"
> Cc: Michael Ellerman
> Cc: Nicholas Piggin
> Cc: Christophe Leroy
> Cc: linuxppc-dev@lists.ozlabs.org
Looks good,
Reviewed-by: Pali Rohár
> ---
> arch/powerpc/Kconfig.debug |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
> --- a/arch/powerpc/Kconfig.debug
> +++ b/arch/powerpc/Kconfig.debug
> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>
> config PPC_EARLY_DEBUG_CPM
> bool "Early serial debugging for Freescale CPM-based serial ports"
> - depends on SERIAL_CPM
> + depends on SERIAL_CPM=y
> help
> Select this to enable early debugging for Freescale chips
> using a CPM-based serial port. This assumes that the bootwrapper
