Re: [PATCH 0/3] Patches to support QE USB Host Controller
On Thursday 14 August 2008, Laurent Pinchart wrote:
David, could you bear with gpio_to_chip() exported function, just as
a stopgap for a proper api?
I need gpio_to_chip() (or another 'proper API') as well for RTS/CTS
based flow control in the CPM/CPM2 UART driver.
I'l still say proper. This should be straightforward; along
the lines of
struct qe_pin {
struct ... *qe_ports; /* includes gpio_chip */
unsigned offset;
};
And instead of having the driver look up a gpio for such
non-GPIO usage, have it call something that sets up a qe_pin.
All that infrastructure exists already...
Then drivers can use calls which mux the pin into its normal
mode (QE function of some kind), or into its gpio mode.
The gpio number would be gpio_chip-base + offset, and the
gpio_chip is visible -- in a fully typesafe manner! -- from
the qe_ports structure.
No type-unsafe interfaces. No confusion between roles of a
given pin. No hidden assumption there's only one kind of GPIO
(backed by QE ports). And ... no need to change any core
structural assumptions of the GPIO framework.
- Dave
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 0/3] Patches to support QE USB Host Controller
On Fri, Aug 08, 2008 at 04:26:35PM -0700, Greg KH wrote: On Fri, Aug 08, 2008 at 08:17:17PM +0400, Anton Vorontsov wrote: Hi all, Most patches that were needed to support QE USB Host were merged during 2.6.27 merge window, and only three more patches left over. Here they are. David, could you bear with gpio_to_chip() exported function, just as a stopgap for a proper api? I'll hold off on the 3rd patch until david takes the first two. David, are there any issues with the first patch in the series? It would be great if you'll ack the first patch, so that I'll respin the whole patchset with some minor fixes in the 3rd patch. Thanks, -- Anton Vorontsov email: [EMAIL PROTECTED] irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 0/3] Patches to support QE USB Host Controller
On Friday 08 August 2008, Anton Vorontsov wrote: Hi all, Most patches that were needed to support QE USB Host were merged during 2.6.27 merge window, and only three more patches left over. Here they are. David, could you bear with gpio_to_chip() exported function, just as a stopgap for a proper api? I need gpio_to_chip() (or another 'proper API') as well for RTS/CTS based flow control in the CPM/CPM2 UART driver. Best regards, -- Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75 signature.asc Description: This is a digitally signed message part. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 0/3] Patches to support QE USB Host Controller
On Fri, Aug 08, 2008 at 08:17:17PM +0400, Anton Vorontsov wrote: Hi all, Most patches that were needed to support QE USB Host were merged during 2.6.27 merge window, and only three more patches left over. Here they are. David, could you bear with gpio_to_chip() exported function, just as a stopgap for a proper api? I'll hold off on the 3rd patch until david takes the first two. thanks, greg k-h ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
