Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular
[[PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular] On 18/10/2015 (Sun 18:21) Paul Gortmaker wrote: > This next set of patches to drivers/tty fixes up more drivers that would > perhaps appear modular when looking at the code, but are controlled by > a bool Kconfig. We make sure they don't look modular and get rid > of module related code in the drivers that would never be used. [...] > Paul Gortmaker (5): > drivers/tty: make hvc/hvc_vio.c explicitly non-modular > drivers/tty: make ehv_bytechan.c explicitly non-modular > drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular > drivers/tty/serial: make msm_serial.c explicitly non-modular > drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular Hi Greg, You've merged the #3 atmel patch and #5 the 8250_mtk patch; the msm_serial patch (#4) is no longer applicable since the authors changed it to tristate. That leaves the top two patches; both for PPC hardware. Did you skip those because you wanted them pushed through the powerpc tree? If so, that is fine, I can do that. Just let me know. Thanks, Paul. -- > > drivers/tty/ehv_bytechan.c | 40 +++-- > drivers/tty/hvc/hvc_vio.c | 29 > drivers/tty/serial/8250/8250_mtk.c | 35 ++--- > drivers/tty/serial/atmel_serial.c | 45 > -- > drivers/tty/serial/msm_serial.c| 30 - > 5 files changed, 22 insertions(+), 157 deletions(-) > > -- > 2.6.1 > ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular
On 20/10/2015 at 20:20:07 -0400, Paul Gortmaker wrote : > [Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular] > On 20/10/2015 (Tue 17:10) Alexandre Belloni wrote: > > > On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote : > > > The one common thread here for all the patches is that we also > > > scrap the .remove functions which would only be used for module > > > unload (impossible) and driver unbind. For the drivers here, there > > > doesn't seem to be a sensible unbind use case (vs. e.g. a multiport > > > PCI ethernet driver where one port is unbound and passed through to > > > a kvm guest or similar). Hence we just explicitly disallow any > > > driver unbind operations to help prevent root from doing something > > > illogical to the machine that they could have done previously. > > > > > > We've already done this for drivers/tty/serial/mpsc.c previously. > > > > > > Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing. > > > > > > > So, how does this actually build test atmel_serial? > > Not sure why this should be a surprise; I build test it exactly like this: > CONFIG_SERIAL_ATMEL is not selected by allmodconfig on arm64 or powerpc so this is not explaining how you build tested atmel_serial. > paul@builder-02:~/git/linux-head$ echo $ARCH > arm64 > paul@builder-02:~/git/linux-head$ echo $CROSS_COMPILE > aarch64-linux-gnu- > paul@builder-02:~/git/linux-head$ make O=../arm-build/ > drivers/tty/serial/atmel_serial.o > make[1]: Entering directory '/home/paul/git/arm-build' > arch/arm64/Makefile:25: LSE atomics not supported by binutils > CHK include/config/kernel.release > Using /home/paul/git/linux-head as source for kernel > GEN ./Makefile > CHK include/generated/uapi/linux/version.h > CHK include/generated/utsrelease.h > > [...] > > HOSTCC scripts/sign-file > HOSTCC scripts/extract-cert > CC drivers/tty/serial/atmel_serial.o > make[1]: Leaving directory '/home/paul/git/arm-build' > paul@builder-02:~/git/linux-head$ > > It did build; no warning/error. Would you call it an invalid build test? > What you describe is a different test. I end up with 4 warnings when doing that on my machine. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular
[Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular] On 20/10/2015 (Tue 17:10) Alexandre Belloni wrote: > On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote : > > The one common thread here for all the patches is that we also > > scrap the .remove functions which would only be used for module > > unload (impossible) and driver unbind. For the drivers here, there > > doesn't seem to be a sensible unbind use case (vs. e.g. a multiport > > PCI ethernet driver where one port is unbound and passed through to > > a kvm guest or similar). Hence we just explicitly disallow any > > driver unbind operations to help prevent root from doing something > > illogical to the machine that they could have done previously. > > > > We've already done this for drivers/tty/serial/mpsc.c previously. > > > > Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing. > > > > So, how does this actually build test atmel_serial? Not sure why this should be a surprise; I build test it exactly like this: paul@builder-02:~/git/linux-head$ echo $ARCH arm64 paul@builder-02:~/git/linux-head$ echo $CROSS_COMPILE aarch64-linux-gnu- paul@builder-02:~/git/linux-head$ make O=../arm-build/ drivers/tty/serial/atmel_serial.o make[1]: Entering directory '/home/paul/git/arm-build' arch/arm64/Makefile:25: LSE atomics not supported by binutils CHK include/config/kernel.release Using /home/paul/git/linux-head as source for kernel GEN ./Makefile CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h [...] HOSTCC scripts/sign-file HOSTCC scripts/extract-cert CC drivers/tty/serial/atmel_serial.o make[1]: Leaving directory '/home/paul/git/arm-build' paul@builder-02:~/git/linux-head$ It did build; no warning/error. Would you call it an invalid build test? > > A proper solution would be to actually make it a tristate and allow > building as a module. I think it currently fails because of > console_initcall() but that is certainly fixable. Well, as per other threads on this topic, if people want to extend the functionality to support tristate, then great. But please do not confuse that with existing functionality which is clearly non modular in this case. Thanks, Paul. -- > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular
On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote : > The one common thread here for all the patches is that we also > scrap the .remove functions which would only be used for module > unload (impossible) and driver unbind. For the drivers here, there > doesn't seem to be a sensible unbind use case (vs. e.g. a multiport > PCI ethernet driver where one port is unbound and passed through to > a kvm guest or similar). Hence we just explicitly disallow any > driver unbind operations to help prevent root from doing something > illogical to the machine that they could have done previously. > > We've already done this for drivers/tty/serial/mpsc.c previously. > > Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing. > So, how does this actually build test atmel_serial? A proper solution would be to actually make it a tristate and allow building as a module. I think it currently fails because of console_initcall() but that is certainly fixable. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
