Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
On Mon, 2 Aug 2010 16:31:28 -0700, Greg KH wrote: On Wed, Jul 28, 2010 at 11:16:35PM -0700, Eric Biederman wrote: On Wed, Jul 28, 2010 at 10:09 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: The following comment is found in include/linux/sysfs.h: /* FIXME * The *owner field is no longer used. * x86 tree has been cleaned up. The owner * attribute is still left for other arches. */ As it turns out, the *owner field is (again?) initialized in several modules, suggesting that such initialization may be creeping back into the code. This patch set removes the above comment, the *owner field, and each instance in the code where it was found to be initialized. Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc, and sparc defconfig builds. This seems reasonable to me. Can we get this in linux-next? It will show up in linux-next tomorrow. Related bug? https://bugzilla.kernel.org/show_bug.cgi?id=16544 -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Hi Jean, On Tue, 10 Aug 2010 15:43:37 +0200 Jean Delvare kh...@linux-fr.org wrote: Related bug? https://bugzilla.kernel.org/show_bug.cgi?id=16544 Yep, fixed in linux-next today - hopefully the fix is on its way to Linus. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpomupwqTLtg.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Hi Jean, On Wed, 11 Aug 2010 01:17:33 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Tue, 10 Aug 2010 15:43:37 +0200 Jean Delvare kh...@linux-fr.org wrote: Related bug? https://bugzilla.kernel.org/show_bug.cgi?id=16544 Yep, fixed in linux-next today - hopefully the fix is on its way to Linus. Sorry, more info: Fixed by commit 690e85a3957291f4cfe0cac22d97994ec7e5ee45 (olpc_battery: Fix build failure caused by sysfs changes) from the battery tree. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpZuWgur9Rwf.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
On Tue, 2010-08-10 at 11:20 -0400, Stephen Rothwell wrote: Hi Jean, On Wed, 11 Aug 2010 01:17:33 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Tue, 10 Aug 2010 15:43:37 +0200 Jean Delvare kh...@linux-fr.org wrote: Related bug? https://bugzilla.kernel.org/show_bug.cgi?id=16544 Yep, fixed in linux-next today - hopefully the fix is on its way to Linus. Sorry, more info: Fixed by commit 690e85a3957291f4cfe0cac22d97994ec7e5ee45 (olpc_battery: Fix build failure caused by sysfs changes) from the battery tree. Excellent. Guess the patch I sent out earlier today to fix the problem wasn't needed then. Guenter ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
On 07/29/2010 07:09 AM, Guenter Roeck wrote: The following comment is found in include/linux/sysfs.h: /* FIXME * The *owner field is no longer used. * x86 tree has been cleaned up. The owner * attribute is still left for other arches. */ As it turns out, the *owner field is (again?) initialized in several modules, suggesting that such initialization may be creeping back into the code. This patch set removes the above comment, the *owner field, and each instance in the code where it was found to be initialized. Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc, and sparc defconfig builds. Yeah, the change is way overdue. Maybe we should have just removed them back then. Acked-by: Tejun Heo t...@kernel.org Thanks. -- tejun ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote: On 07/29/2010 07:09 AM, Guenter Roeck wrote: The following comment is found in include/linux/sysfs.h: /* FIXME * The *owner field is no longer used. * x86 tree has been cleaned up. The owner * attribute is still left for other arches. */ As it turns out, the *owner field is (again?) initialized in several modules, suggesting that such initialization may be creeping back into the code. This patch set removes the above comment, the *owner field, and each instance in the code where it was found to be initialized. Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc, and sparc defconfig builds. Yeah, the change is way overdue. Maybe we should have just removed them back then. I'm happy with the powerpc related patches as long as we all agree that needs to go. Do you need me to put some of this in powerpc.git or are you carrying them all to Linus ? Cheers, Ben. Acked-by: Tejun Heo t...@kernel.org Thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
On Fri, Jul 30, 2010 at 08:28:10PM +1000, Benjamin Herrenschmidt wrote: On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote: On 07/29/2010 07:09 AM, Guenter Roeck wrote: The following comment is found in include/linux/sysfs.h: /* FIXME * The *owner field is no longer used. * x86 tree has been cleaned up. The owner * attribute is still left for other arches. */ As it turns out, the *owner field is (again?) initialized in several modules, suggesting that such initialization may be creeping back into the code. This patch set removes the above comment, the *owner field, and each instance in the code where it was found to be initialized. Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc, and sparc defconfig builds. Yeah, the change is way overdue. Maybe we should have just removed them back then. I'm happy with the powerpc related patches as long as we all agree that needs to go. Do you need me to put some of this in powerpc.git or are you carrying them all to Linus ? I can carry them all in my driver-core tree if you don't object. thanks, greg k-h ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
On Wed, Jul 28, 2010 at 10:09 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: The following comment is found in include/linux/sysfs.h: /* FIXME * The *owner field is no longer used. * x86 tree has been cleaned up. The owner * attribute is still left for other arches. */ As it turns out, the *owner field is (again?) initialized in several modules, suggesting that such initialization may be creeping back into the code. This patch set removes the above comment, the *owner field, and each instance in the code where it was found to be initialized. Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc, and sparc defconfig builds. This seems reasonable to me. Can we get this in linux-next? Eric ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
