Re: [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config
On Fri, 2014-06-06 at 11:03 +0530, Anshuman Khandual wrote: > On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote: > > Build throws following errors when CONFIG_SMP=n > > arch/powerpc/platforms/powernv/setup.c: In function > > ‘pnv_kexec_wait_secondaries_down’: > > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration > > of function ‘get_hard_smp_processor_id’ > > rc = opal_query_cpu_status(get_hard_smp_processor_id(i), > > > > The usage of get_hard_smp_processor_id() needs the declaration from > > . The file setup.c includes , which in-turn > > includes . However, includes > > only on SMP configs and hence UP builds fail. > > > > Fix this by directly including in setup.c unconditionally. > > Can you please clean up the description in the commit message ? and also > the first line in the commit message should mention that the patch is > trying to fix a UP specific build failure. I don't understand your comment ... the description and subject line are perfectly fine... Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config
On Fri, Jun 6, 2014 at 7:33 AM, Anshuman Khandual
wrote:
> On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote:
>> Build throws following errors when CONFIG_SMP=n
>> arch/powerpc/platforms/powernv/setup.c: In function
>> ‘pnv_kexec_wait_secondaries_down’:
>> arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of
>> function ‘get_hard_smp_processor_id’
>> rc = opal_query_cpu_status(get_hard_smp_processor_id(i),
>>
>> The usage of get_hard_smp_processor_id() needs the declaration from
>> . The file setup.c includes , which in-turn
>> includes . However, includes
>> only on SMP configs and hence UP builds fail.
>>
>> Fix this by directly including in setup.c unconditionally.
>
> Can you please clean up the description in the commit message ? and also
> the first line in the commit message should mention that the patch is
> trying to fix a UP specific build failure.
Both the one-line summary and the first line already mention "UP" or
"CONFIG_SMP=n".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config
On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote: > Build throws following errors when CONFIG_SMP=n > arch/powerpc/platforms/powernv/setup.c: In function > ‘pnv_kexec_wait_secondaries_down’: > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of > function ‘get_hard_smp_processor_id’ > rc = opal_query_cpu_status(get_hard_smp_processor_id(i), > > The usage of get_hard_smp_processor_id() needs the declaration from > . The file setup.c includes , which in-turn > includes . However, includes > only on SMP configs and hence UP builds fail. > > Fix this by directly including in setup.c unconditionally. Can you please clean up the description in the commit message ? and also the first line in the commit message should mention that the patch is trying to fix a UP specific build failure. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
