Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-08 Thread Martyn Welch

Wim Van Sebroeck wrote:

Hi All,


Any status of acceptance of this?


I changed the ioctl to an unlocked ioctl and removed the temperature ioctl call.
It's now in my linux-2.6-watchdog-next tree. Can someone verify that it still 
works?
(http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-next.git;a=summary)



Hi Wim,

Thank you for reviewing these patches. I have made the changes you have on my 
dev tree and, whilst I don't have an SBC610 to hand, I have checked the driver 
on a similar board which also uses the same watchdog and it's still working as 
expected.

Martyn

--
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,|Registered in England and Wales
Tove Valley Business Park, Towcester,  |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 729849476
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-07 Thread Wim Van Sebroeck
Hi Kumar,

> >the second patch is also in. Do we keep in in the watchdog tree  
> >since it almost doesn't
> >touch the powerpc arch or do you want it in your tree?
> 
> If you have it in your tree to pull go ahead and send it via  
> watchdog.  (I assume this will be for 2.6.29)

Ok. Will do it like that. And yes it is for 2.6.29.

Kind regards,
Wim.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-07 Thread Kumar Gala


On Jan 7, 2009, at 3:48 PM, Wim Van Sebroeck wrote:


Hi All,


Any status of acceptance of this?


I changed the ioctl to an unlocked ioctl and removed the temperature  
ioctl call.
It's now in my linux-2.6-watchdog-next tree. Can someone verify that  
it still works?
(http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-next.git;a=summary 
)


Kumar,

the second patch is also in. Do we keep in in the watchdog tree  
since it almost doesn't

touch the powerpc arch or do you want it in your tree?


If you have it in your tree to pull go ahead and send it via  
watchdog.  (I assume this will be for 2.6.29)


- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-07 Thread Wim Van Sebroeck
Hi All,

> Any status of acceptance of this?

I changed the ioctl to an unlocked ioctl and removed the temperature ioctl call.
It's now in my linux-2.6-watchdog-next tree. Can someone verify that it still 
works?
(http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-next.git;a=summary)

Kumar,

the second patch is also in. Do we keep in in the watchdog tree since it almost 
doesn't
touch the powerpc arch or do you want it in your tree?

Kind regards,
Wim.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-07 Thread Wim Van Sebroeck
Hi Kumar,

> >drivers/watchdog/Kconfig   |6 +
> >drivers/watchdog/Makefile  |1
> >drivers/watchdog/gef_wdt.c |  333 +++ 
> >+
> >3 files changed, 340 insertions(+), 0 deletions(-)
> 
> Wim,
> 
> Any status of acceptance of this?

I started reviewing it on sunday. It looks OK so you can expect inclusion in my 
-next tree this week.
A couple of days later I would like to forward it to Linus for mainline 
inclusion. It would like to have it in 2.6.29.

Kind regards,
Wim.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-06 Thread Kumar Gala


On Nov 10, 2008, at 6:31 AM, Martyn Welch wrote:


GE Fanuc SBC610

Support for the FPGA based watchdog timer as found on GE Fanuc's  
SBC310,

SBC610 and PPC9A Single Board Computers.

This patch adds support for the watchdog timer found in one of the  
devices
FPGAs. There are two identical watchdog timers at different offsets  
in the
above mentioned boards, this driver is capable of supporting one of  
them.

The watchdog timers are also capable of generating interrupts at a
user-configurable threshold, though support for this operation is  
currently

not supported by the driver.

Signed-off-by: Martyn Welch 
---

drivers/watchdog/Kconfig   |6 +
drivers/watchdog/Makefile  |1
drivers/watchdog/gef_wdt.c |  333 +++ 
+

3 files changed, 340 insertions(+), 0 deletions(-)


Wim,

Any status of acceptance of this?

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev