Re: [PATCH 10/10] powerpc/mpic: Add in-core support for cascaded MPICs
On Tue, 2011-11-29 at 13:58 -0500, Kyle Moffett wrote: > diff --git a/arch/powerpc/platforms/cell/setup.c > b/arch/powerpc/platforms/cell/setup.c > index cd00ca8..a0f5d28 100644 > --- a/arch/powerpc/platforms/cell/setup.c > +++ b/arch/powerpc/platforms/cell/setup.c > @@ -215,15 +202,6 @@ static void __init mpic_init_IRQ(void) > if (mpic == NULL) > continue; > mpic_init(mpic); > - > - virq = irq_of_parse_and_map(dn, 0); > - if (virq == NO_IRQ) > - continue; > - > - printk(KERN_INFO "%s : hooking up to IRQ %d\n", > -dn->full_name, virq); > - irq_set_handler_data(virq, mpic); > - irq_set_chained_handler(virq, cell_mpic_cascade); > } > } This leaves virq unused, which breaks the build. cheers -- ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 10/10] powerpc/mpic: Add in-core support for cascaded MPICs
Ben, I fixed the 3 issues that Paul and Michael reported and I can provide them to you two different ways, however you would prefer. I can also send the patches via email if that's more convenient. Option 1: Squashed into the the original patches for bisectability: git://opensource.exmeritus.com/hww-1u-1a/linux.git mpc85xx/mpic-and-stuff Option 2: As a fixup patch on the end: git://opensource.exmeritus.com/hww-1u-1a/linux.git mpc85xx/mpic-and-stuff-fixup You can also use HTTP if you would prefer: http://opensource.exmeritus.com/git/hww-1u-1a/linux.git Cheers, Kyle Moffett -- Curious about my work on the Debian powerpcspe port? I'm keeping a blog here: http://pureperl.blogspot.com/ ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 10/10] powerpc/mpic: Add in-core support for cascaded MPICs
On Thu, 2011-12-01 at 19:48 -0600, Moffett, Kyle D wrote: > Ben, > > I fixed the 3 issues that Paul and Michael reported and I can provide them > to you two different ways, however you would prefer. I can also send the > patches via email if that's more convenient. > > Option 1: Squashed into the the original patches for bisectability: > git://opensource.exmeritus.com/hww-1u-1a/linux.git mpc85xx/mpic-and-stuff This option, please just re-send to the list. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev