Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

2009-04-28 Thread Stephen Rothwell
Hi Tim,

Firstly, patches for a particular architecture should really be cc'd to
the list associated with that architecture.  In this case,
linuxppc-dev@ozlabs.org (cc'd).

On Mon, 27 Apr 2009 16:33:05 -0400 Tim Abbott  wrote:
>
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -222,6 +222,7 @@ SECTIONS
>  
>  #ifdef CONFIG_PPC32
>   .data : AT(ADDR(.data) - LOAD_OFFSET) {
> + PAGE_ALIGNED_DATA
>   DATA_DATA
>   *(.sdata)
>   *(.got.plt) *(.got)
> @@ -259,11 +260,6 @@ SECTIONS
>   *(.data.init_task)
>   }
>  
> - . = ALIGN(PAGE_SIZE);
> - .data.page_aligned : AT(ADDR(.data.page_aligned) - LOAD_OFFSET) {
> - *(.data.page_aligned)
> - }
> -

This moves the page_aligned section from a common part of the
vmlinux.lds to a 32 bit only part.  Was that intentional?

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgpHBJqHvQug6.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

2009-04-28 Thread Stephen Rothwell
On Wed, 29 Apr 2009 01:07:53 +1000 Stephen Rothwell  
wrote:
>
> This moves the page_aligned section from a common part of the
> vmlinux.lds to a 32 bit only part.  Was that intentional?

Just saw your later patches, so ignore this.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgpioMRcAuPoU.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

2009-04-28 Thread Tim Abbott
On Wed, 29 Apr 2009, Stephen Rothwell wrote:

> This moves the page_aligned section from a common part of the
> vmlinux.lds to a 32 bit only part.  Was that intentional?

No.  See my reply to this patch from last night 
 and the revised pair of patches in 
reply to that message that replace PATCH 11/14.

-Tim Abbott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev