Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
On Sat, 22 Dec 2007 08:16:55 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Fri, 2007-12-21 at 06:09 -0600, Josh Boyer wrote: > > On Fri, 21 Dec 2007 15:39:35 +1100 > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > This removes a bogus empty "ranges" property in the EBC device node > > > of the Bamboo board device-tree. > > > > > > The "ranges" property will be created by the boot wrapper, there is > > > no need to have an empty property there, and that causes recent > > > dtc to complain. > > > > The wrapper doesn't do anything with EBC for bamboo because the EBC > > stuff is a nightmare on this board. The patch can stand, but I'll > > fixup the comments in the changelog. > > The wrapper could still create ranges for the chip select settings no ? It could. It doesn't though. Perhaps our interpretation of "will be created" differed. > In any case, empty "ranges" is bogus. Correct. Which is why I said I'd just edit the changelog :). josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
On Fri, 2007-12-21 at 06:09 -0600, Josh Boyer wrote: > On Fri, 21 Dec 2007 15:39:35 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > This removes a bogus empty "ranges" property in the EBC device node > > of the Bamboo board device-tree. > > > > The "ranges" property will be created by the boot wrapper, there is > > no need to have an empty property there, and that causes recent > > dtc to complain. > > The wrapper doesn't do anything with EBC for bamboo because the EBC > stuff is a nightmare on this board. The patch can stand, but I'll > fixup the comments in the changelog. The wrapper could still create ranges for the chip select settings no ? In any case, empty "ranges" is bogus. Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
On Fri, 21 Dec 2007 15:39:35 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > This removes a bogus empty "ranges" property in the EBC device node > of the Bamboo board device-tree. > > The "ranges" property will be created by the boot wrapper, there is > no need to have an empty property there, and that causes recent > dtc to complain. The wrapper doesn't do anything with EBC for bamboo because the EBC stuff is a nightmare on this board. The patch can stand, but I'll fixup the comments in the changelog. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev