Re: [PATCH 2/3] powerpc: Add support for creating FIT uImages

2009-11-25 Thread Peter Tyser 

Hi Stefano,

Stefano Babic wrote:

Peter Tyser ptyser wrote:


+# Create a default, fully populated DTS file
+DATA=/ {
+   description = \Linux kernel ${VERSION}\;
+   #address-cells = 1;
+
+   images {
+   kernel at 1 {


Is the at probably generated by your anti-spam mailer ? dtc seems not
to like it as replacement for the usual '@' ;)


The patch looks correct in my inbox and at 
http://patchwork.kernel.org/patch/61183/.  Perhaps its a problem at your 
end?


Please keep everyone cc-ed on responses - the changes are just as 
relevant to linuxppc as kbuild.


Best,
Peter
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/3] powerpc: Add support for creating FIT uImages

2009-11-24 Thread Peter Tyser 
Hi Stefano,
Thanks for trying the patches out.

On Tue, 2009-11-24 at 11:32 +0100, Stefano Babic wrote:
 Peter Tyser ptyser wrote:
  +uboot.fit)
  +rm -f $ofile
  +${MKITS} -A ppc -C gzip -a $membase -e $membase -v $version \
  +   -d $srctree/$dtb -k $srctree/$vmz -o $object/uImage.its
  +${MKIMAGE} -f $object/uImage.its $ofile
 
 Hi,
 
 I have tested your patches against last mkimage utility provided with
 u-boot. The utility requires to pass the type of the image (flat_dt),
 even if this is not mentioned in the help output. Without the image type
 parameter, no image is generated, and no error is reported.
 It should be:
 
 ${MKIMAGE} -f $object/uImage.its - T flat_dt $ofile

Argh, I'm seeing the same behavior with the latest mkimage source too.
It looks like there was a regression in the mkimage utility - the -T
option shouldn't be necessary to create a FIT image.  I'll send a patch
to U-Boot to fix this behavior.

 I have tried to get an image for the lite5200b board, because I have the
 possibility to test the result on the target. However, dtc fails to
 compile the its generated by your script (Version: DTC 1.2.0-g0ef21055,
 cloned from jdt).

I did my testing using the dtc in the linux kernel source
(scripts/dtc/dtc, version 1.2.0) and version 1.2.0-rc1.  I see the same
error as you when using version 1.2.0-g0ef21055.

 DTC: dts-dtb  on file arch/powerpc/boot/uImage.its
 Error: arch/powerpc/boot/uImage.its 1:0 syntax error
 
 Do you test in different conditions ?

Applying the following change should resolve the dtc syntax error.

diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 88411dd..75edc27 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -64,7 +64,9 @@ ENTRY_ADDR=`echo $ENTRY_ADDR | sed 's/0x//'`
 RAMFS_ADDR=`echo $RAMFS_ADDR | sed 's/0x//'`
 
 # Create a default, fully populated DTS file
-DATA=/ {
+DATA=/dts-v1/;
+
+/ {
description = \Linux kernel ${VERSION}\;
#address-cells = 1;
 

I'll wait a few more days for feedback then resubmit with the dts syntax
fix

Thanks for testing,
Peter

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev