Re: [PATCH 2/3 v2] Add initial iomega StorCenter board port.

2008-01-09 Thread Scott Wood
On Tue, Jan 08, 2008 at 04:07:17PM -0600, Jon Loeliger wrote:
 +static void storcenter_power_off(void)
 +{
 + /* No way to shut power off with software */
 + local_irq_disable();
 + for (;;) ;
 + /* NOTREACHED */
 +}

So leave it out, and let the generic halt function be used.

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 2/3 v2] Add initial iomega StorCenter board port.

2008-01-08 Thread Stephen Rothwell
Hi Jon,

On Tue, 08 Jan 2008 16:07:17 -0600 Jon Loeliger [EMAIL PROTECTED] wrote:

 +static void __init storcenter_init_IRQ(void)
 +{
 + struct mpic *mpic;
 + struct device_node *dnp;
 + const void *prop;
 + int size;
 + phys_addr_t paddr;
 +
 + dnp = of_find_node_by_type(NULL, open-pic);
 + if (dnp == NULL)
 + return;
 +
 + prop = of_get_property(dnp, reg, size);
 + paddr = (phys_addr_t)of_translate_address(dnp, prop);
 + mpic = mpic_alloc(dnp, paddr, MPIC_PRIMARY | MPIC_WANTS_RESET,
 + 4, 32,  EPIC );
 + BUG_ON(mpic == NULL);

 + mpic_assign_isu(mpic, 0, paddr + 0x10200);
 + mpic_assign_isu(mpic, 1, paddr + 0x10220);
 + mpic_assign_isu(mpic, 2, paddr + 0x10240);
 + mpic_assign_isu(mpic, 3, paddr + 0x10260);
 + mpic_assign_isu(mpic, 4, paddr + 0x10280);
 + mpic_assign_isu(mpic, 5, paddr + 0x11120);
 + mpic_assign_isu(mpic, 6, paddr + 0x11140);
 +
 + mpic_init(mpic);
 +}

The above needs a of_node_put(dnp) somewhere.

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpJISKtFR5GL.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev