Re: [PATCH 2/4] PowerPC 440EPx: Sequoia DTS
David Gibson wrote:
> On Tue, Aug 14, 2007 at 10:48:43PM +0400, Valentine Barshak wrote:
>> AMCC Sequoia device tree.
>>
>> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]>
>> ---
>> arch/powerpc/boot/dts/sequoia.dts | 289
>> ++
>> 1 files changed, 289 insertions(+)
>>
>> diff -ruN linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts
>> linux-2.6/arch/powerpc/boot/dts/sequoia.dts
>> --- linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts 1970-01-01
>> 03:00:00.0 +0300
>> +++ linux-2.6/arch/powerpc/boot/dts/sequoia.dts 2007-08-14
>> 19:32:56.0 +0400
>> @@ -0,0 +1,289 @@
>> +/*
>> + * Device Tree Source for AMCC Sequoia
>> + *
>> + * Based on Bamboo code by Josh Boyer <[EMAIL PROTECTED]>
>> + * Copyright (c) 2006, 2007 IBM Corp.
>> + *
>> + * FIXME: Draft only!
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without
>> + * any warranty of any kind, whether express or implied.
>> + *
>> + */
>> +
>> +/ {
>> +#address-cells = <2>;
>> +#size-cells = <1>;
>> +model = "amcc,sequoia";
>> +compatible = "amcc,sequoia";
>> +dcr-parent = <&/cpus/PowerPC,[EMAIL PROTECTED]>;
>> +
>> +cpus {
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +
>> +PowerPC,[EMAIL PROTECTED] {
>> +device_type = "cpu";
>> +reg = <0>;
>> +clock-frequency = <0>; /* Filled in by zImage */
>> +timebase-frequency = <0>; /* Filled in by zImage */
>> +i-cache-line-size = <20>;
>> +d-cache-line-size = <20>;
>> +i-cache-size = <8000>;
>> +d-cache-size = <8000>;
>> +dcr-controller;
>> +dcr-access-method = "native";
>> +};
>> +};
>> +
>> +memory {
>> +device_type = "memory";
>> +reg = <0 0 0>; /* Filled in by zImage */
>> +};
>> +
>> +UIC0: interrupt-controller0 {
>> +compatible = "ibm,uic-440epx","ibm,uic";
>> +interrupt-controller;
>> +cell-index = <0>;
>> +dcr-reg = <0c0 009>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +#interrupt-cells = <2>;
>> +};
>> +
>> +UIC1: interrupt-controller1 {
>> +compatible = "ibm,uic-440epx","ibm,uic";
>> +interrupt-controller;
>> +cell-index = <1>;
>> +dcr-reg = <0d0 009>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +#interrupt-cells = <2>;
>> +interrupts = <1e 4 1f 4>; /* cascade */
>> +interrupt-parent = <&UIC0>;
>> +};
>> +
>> +UIC2: interrupt-controller2 {
>> +compatible = "ibm,uic-440epx","ibm,uic";
>> +interrupt-controller;
>> +cell-index = <2>;
>> +dcr-reg = <0e0 009>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +#interrupt-cells = <2>;
>> +interrupts = <1c 4 1d 4>; /* cascade */
>> +interrupt-parent = <&UIC0>;
>> +};
>> +
>> +SDR0: sdr {
>> +compatible = "ibm,sdr-440epx", "ibm,sdr-440ep";
>
> Ok, I take it the 440EP really does have SDR and CPR devices with
> which the EPx variants are compatible?
Right.
>
>> +dcr-reg = <00e 002>;
>> +};
>> +
>> +CPR0: cpr {
>> +compatible = "ibm,cpr-440epx", "ibm,sdr-440ep";
>> +dcr-reg = <00c 002>;
>> +};
>> +
>> +plb {
>> +compatible = "ibm,plb-440epx", "ibm,plb4";
>> +#address-cells = <2>;
>> +#size-cells = <1>;
>> +ranges;
>> +clock-frequency = <0>; /* Filled in by zImage */
>> +
>> +SDRAM0: sdram {
>> +device_type = "memory-controller";
>> +compatible = "ibm,sdram-44x-ddr2denali";
>
> Should have an ibm,sdram-440epx entry as well, just in case of chip
> specific bugs / workarounds.
OK
>
>> +dcr-reg = <010 2>;
>> +};
>> +
>> +DMA0: dma {
>> +compatible = "ibm,dma-440epx", "ibm,dma-4xx";
>> +dcr-reg = <100 027>;
>> +};
>> +
>> +MAL0: mcmal {
>> +compatible = "ibm,mcmal-440epx", "ibm,mcmal-440spe",
>> "ibm,mcmal2";
>
> What's the 440spe entry about?
Will remove. No need in 440spe with the updated EMAC driver.
>
>> +dcr-reg = <180 62>;
>> +num-tx-chans = <4>;
>> +num-rx-chans = <4>;
>> +interrupt-parent = <&MAL0>;
>> +interrupts = <0 1 2 3 4>;
>> +#interrupt-cells = <1>;
>> +#address-cells = <0>;
>> +#size-ce
Re: [PATCH 2/4] PowerPC 440EPx: Sequoia DTS
Stefan Roese wrote:
> On Tuesday 14 August 2007, Valentine Barshak wrote:
>> AMCC Sequoia device tree.
>
> Please find some comments below.
>
>> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]>
>> ---
>> arch/powerpc/boot/dts/sequoia.dts | 289
>> ++ 1 files changed, 289 insertions(+)
>>
>> diff -ruN linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts
>> linux-2.6/arch/powerpc/boot/dts/sequoia.dts ---
>> linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts 1970-01-01
>> 03:00:00.0 +0300 +++
>> linux-2.6/arch/powerpc/boot/dts/sequoia.dts 2007-08-14 19:32:56.0
>> +0400 @@ -0,0 +1,289 @@
>> +/*
>> + * Device Tree Source for AMCC Sequoia
>> + *
>> + * Based on Bamboo code by Josh Boyer <[EMAIL PROTECTED]>
>> + * Copyright (c) 2006, 2007 IBM Corp.
>> + *
>> + * FIXME: Draft only!
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without
>> + * any warranty of any kind, whether express or implied.
>> + *
>> + */
>> +
>> +/ {
>> +#address-cells = <2>;
>> +#size-cells = <1>;
>> +model = "amcc,sequoia";
>> +compatible = "amcc,sequoia";
>> +dcr-parent = <&/cpus/PowerPC,[EMAIL PROTECTED]>;
>> +
>> +cpus {
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +
>> +PowerPC,[EMAIL PROTECTED] {
>> +device_type = "cpu";
>> +reg = <0>;
>> +clock-frequency = <0>; /* Filled in by zImage */
>> +timebase-frequency = <0>; /* Filled in by zImage */
>> +i-cache-line-size = <20>;
>> +d-cache-line-size = <20>;
>> +i-cache-size = <8000>;
>> +d-cache-size = <8000>;
>> +dcr-controller;
>> +dcr-access-method = "native";
>> +};
>> +};
>> +
>> +memory {
>> +device_type = "memory";
>> +reg = <0 0 0>; /* Filled in by zImage */
>> +};
>> +
>> +UIC0: interrupt-controller0 {
>> +compatible = "ibm,uic-440epx","ibm,uic";
>> +interrupt-controller;
>> +cell-index = <0>;
>> +dcr-reg = <0c0 009>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +#interrupt-cells = <2>;
>> +};
>> +
>> +UIC1: interrupt-controller1 {
>> +compatible = "ibm,uic-440epx","ibm,uic";
>> +interrupt-controller;
>> +cell-index = <1>;
>> +dcr-reg = <0d0 009>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +#interrupt-cells = <2>;
>> +interrupts = <1e 4 1f 4>; /* cascade */
>> +interrupt-parent = <&UIC0>;
>> +};
>> +
>> +UIC2: interrupt-controller2 {
>> +compatible = "ibm,uic-440epx","ibm,uic";
>> +interrupt-controller;
>> +cell-index = <2>;
>> +dcr-reg = <0e0 009>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +#interrupt-cells = <2>;
>> +interrupts = <1c 4 1d 4>; /* cascade */
>> +interrupt-parent = <&UIC0>;
>> +};
>> +
>> +SDR0: sdr {
>> +compatible = "ibm,sdr-440epx", "ibm,sdr-440ep";
>> +dcr-reg = <00e 002>;
>> +};
>> +
>> +CPR0: cpr {
>> +compatible = "ibm,cpr-440epx", "ibm,sdr-440ep";
>
> sdr-440ep? I assume you really mean:
>
> + compatible = "ibm,cpr-440epx", "ibm,cpr-440ep";
Oops, thanks for noticing that.
>
>> +dcr-reg = <00c 002>;
>> +};
>> +
>> +plb {
>> +compatible = "ibm,plb-440epx", "ibm,plb4";
>> +#address-cells = <2>;
>> +#size-cells = <1>;
>> +ranges;
>> +clock-frequency = <0>; /* Filled in by zImage */
>> +
>> +SDRAM0: sdram {
>> +device_type = "memory-controller";
>> +compatible = "ibm,sdram-44x-ddr2denali";
>> +dcr-reg = <010 2>;
>> +};
>> +
>> +DMA0: dma {
>> +compatible = "ibm,dma-440epx", "ibm,dma-4xx";
>> +dcr-reg = <100 027>;
>> +};
>> +
>> +MAL0: mcmal {
>> +compatible = "ibm,mcmal-440epx", "ibm,mcmal-440spe",
>> "ibm,mcmal2";
>> +dcr-reg = <180 62>;
>> +num-tx-chans = <4>;
>> +num-rx-chans = <4>;
>> +interrupt-parent = <&MAL0>;
>> +interrupts = <0 1 2 3 4>;
>> +#interrupt-cells = <1>;
>> +#address-cells = <0>;
>> +#size-cells = <0>;
>> +interrupt-map = > +/*RXEOB*/ 1 &UIC0 b 4
>> +/*SERR*/ 2 &UIC1 0 4
>> +
Re: [PATCH 2/4] PowerPC 440EPx: Sequoia DTS
On Tuesday 14 August 2007, Valentine Barshak wrote:
> AMCC Sequoia device tree.
Please find some comments below.
> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]>
> ---
> arch/powerpc/boot/dts/sequoia.dts | 289
> ++ 1 files changed, 289 insertions(+)
>
> diff -ruN linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts
> linux-2.6/arch/powerpc/boot/dts/sequoia.dts ---
> linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts 1970-01-01
> 03:00:00.0 +0300 +++
> linux-2.6/arch/powerpc/boot/dts/sequoia.dts 2007-08-14 19:32:56.0
> +0400 @@ -0,0 +1,289 @@
> +/*
> + * Device Tree Source for AMCC Sequoia
> + *
> + * Based on Bamboo code by Josh Boyer <[EMAIL PROTECTED]>
> + * Copyright (c) 2006, 2007 IBM Corp.
> + *
> + * FIXME: Draft only!
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without
> + * any warranty of any kind, whether express or implied.
> + *
> + */
> +
> +/ {
> + #address-cells = <2>;
> + #size-cells = <1>;
> + model = "amcc,sequoia";
> + compatible = "amcc,sequoia";
> + dcr-parent = <&/cpus/PowerPC,[EMAIL PROTECTED]>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + PowerPC,[EMAIL PROTECTED] {
> + device_type = "cpu";
> + reg = <0>;
> + clock-frequency = <0>; /* Filled in by zImage */
> + timebase-frequency = <0>; /* Filled in by zImage */
> + i-cache-line-size = <20>;
> + d-cache-line-size = <20>;
> + i-cache-size = <8000>;
> + d-cache-size = <8000>;
> + dcr-controller;
> + dcr-access-method = "native";
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0 0>; /* Filled in by zImage */
> + };
> +
> + UIC0: interrupt-controller0 {
> + compatible = "ibm,uic-440epx","ibm,uic";
> + interrupt-controller;
> + cell-index = <0>;
> + dcr-reg = <0c0 009>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> + };
> +
> + UIC1: interrupt-controller1 {
> + compatible = "ibm,uic-440epx","ibm,uic";
> + interrupt-controller;
> + cell-index = <1>;
> + dcr-reg = <0d0 009>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> + interrupts = <1e 4 1f 4>; /* cascade */
> + interrupt-parent = <&UIC0>;
> + };
> +
> + UIC2: interrupt-controller2 {
> + compatible = "ibm,uic-440epx","ibm,uic";
> + interrupt-controller;
> + cell-index = <2>;
> + dcr-reg = <0e0 009>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> + interrupts = <1c 4 1d 4>; /* cascade */
> + interrupt-parent = <&UIC0>;
> + };
> +
> + SDR0: sdr {
> + compatible = "ibm,sdr-440epx", "ibm,sdr-440ep";
> + dcr-reg = <00e 002>;
> + };
> +
> + CPR0: cpr {
> + compatible = "ibm,cpr-440epx", "ibm,sdr-440ep";
sdr-440ep? I assume you really mean:
+ compatible = "ibm,cpr-440epx", "ibm,cpr-440ep";
> + dcr-reg = <00c 002>;
> + };
> +
> + plb {
> + compatible = "ibm,plb-440epx", "ibm,plb4";
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges;
> + clock-frequency = <0>; /* Filled in by zImage */
> +
> + SDRAM0: sdram {
> + device_type = "memory-controller";
> + compatible = "ibm,sdram-44x-ddr2denali";
> + dcr-reg = <010 2>;
> + };
> +
> + DMA0: dma {
> + compatible = "ibm,dma-440epx", "ibm,dma-4xx";
> + dcr-reg = <100 027>;
> + };
> +
> + MAL0: mcmal {
> + compatible = "ibm,mcmal-440epx", "ibm,mcmal-440spe",
> "ibm,mcmal2";
> + dcr-reg = <180 62>;
> + num-tx-chans = <4>;
> + num-rx-chans = <4>;
> + interrupt-parent = <&MAL0>;
> + interrupts = <0 1 2 3 4>;
> + #interrupt-cells = <1>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + interrupt-map = + /*RXEOB*/ 1 &UIC0 b 4
> + /*SERR*/ 2 &UIC1 0 4
> + /*TXDE*/ 3 &UIC1 1 4
> + /*RXDE*/ 4
Re: [PATCH 2/4] PowerPC 440EPx: Sequoia DTS
On Tue, Aug 14, 2007 at 10:48:43PM +0400, Valentine Barshak wrote:
> AMCC Sequoia device tree.
>
> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]>
> ---
> arch/powerpc/boot/dts/sequoia.dts | 289
> ++
> 1 files changed, 289 insertions(+)
>
> diff -ruN linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts
> linux-2.6/arch/powerpc/boot/dts/sequoia.dts
> --- linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts 1970-01-01
> 03:00:00.0 +0300
> +++ linux-2.6/arch/powerpc/boot/dts/sequoia.dts 2007-08-14
> 19:32:56.0 +0400
> @@ -0,0 +1,289 @@
> +/*
> + * Device Tree Source for AMCC Sequoia
> + *
> + * Based on Bamboo code by Josh Boyer <[EMAIL PROTECTED]>
> + * Copyright (c) 2006, 2007 IBM Corp.
> + *
> + * FIXME: Draft only!
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without
> + * any warranty of any kind, whether express or implied.
> + *
> + */
> +
> +/ {
> + #address-cells = <2>;
> + #size-cells = <1>;
> + model = "amcc,sequoia";
> + compatible = "amcc,sequoia";
> + dcr-parent = <&/cpus/PowerPC,[EMAIL PROTECTED]>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + PowerPC,[EMAIL PROTECTED] {
> + device_type = "cpu";
> + reg = <0>;
> + clock-frequency = <0>; /* Filled in by zImage */
> + timebase-frequency = <0>; /* Filled in by zImage */
> + i-cache-line-size = <20>;
> + d-cache-line-size = <20>;
> + i-cache-size = <8000>;
> + d-cache-size = <8000>;
> + dcr-controller;
> + dcr-access-method = "native";
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0 0>; /* Filled in by zImage */
> + };
> +
> + UIC0: interrupt-controller0 {
> + compatible = "ibm,uic-440epx","ibm,uic";
> + interrupt-controller;
> + cell-index = <0>;
> + dcr-reg = <0c0 009>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> + };
> +
> + UIC1: interrupt-controller1 {
> + compatible = "ibm,uic-440epx","ibm,uic";
> + interrupt-controller;
> + cell-index = <1>;
> + dcr-reg = <0d0 009>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> + interrupts = <1e 4 1f 4>; /* cascade */
> + interrupt-parent = <&UIC0>;
> + };
> +
> + UIC2: interrupt-controller2 {
> + compatible = "ibm,uic-440epx","ibm,uic";
> + interrupt-controller;
> + cell-index = <2>;
> + dcr-reg = <0e0 009>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> + interrupts = <1c 4 1d 4>; /* cascade */
> + interrupt-parent = <&UIC0>;
> + };
> +
> + SDR0: sdr {
> + compatible = "ibm,sdr-440epx", "ibm,sdr-440ep";
Ok, I take it the 440EP really does have SDR and CPR devices with
which the EPx variants are compatible?
> + dcr-reg = <00e 002>;
> + };
> +
> + CPR0: cpr {
> + compatible = "ibm,cpr-440epx", "ibm,sdr-440ep";
> + dcr-reg = <00c 002>;
> + };
> +
> + plb {
> + compatible = "ibm,plb-440epx", "ibm,plb4";
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges;
> + clock-frequency = <0>; /* Filled in by zImage */
> +
> + SDRAM0: sdram {
> + device_type = "memory-controller";
> + compatible = "ibm,sdram-44x-ddr2denali";
Should have an ibm,sdram-440epx entry as well, just in case of chip
specific bugs / workarounds.
> + dcr-reg = <010 2>;
> + };
> +
> + DMA0: dma {
> + compatible = "ibm,dma-440epx", "ibm,dma-4xx";
> + dcr-reg = <100 027>;
> + };
> +
> + MAL0: mcmal {
> + compatible = "ibm,mcmal-440epx", "ibm,mcmal-440spe",
> "ibm,mcmal2";
What's the 440spe entry about?
> + dcr-reg = <180 62>;
> + num-tx-chans = <4>;
> + num-rx-chans = <4>;
> + interrupt-parent = <&MAL0>;
> + interrupts = <0 1 2 3 4>;
> + #interrupt-cells = <1>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + interrupt-map = + /*RXEOB*/ 1 &UIC0 b 4
> + /*SERR*/
