Re: [PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Akinobu Mita 
2011/7/4 Pavel Machek :
>
>> +     for (action = enb->actions; action->name; action++) {
>> +             struct dentry *file = debugfs_create_int(action->name, mode,
>> +                                             enb->dir, &action->error);
>> +
>> +             if (!file) {
>> +                     debugfs_remove_recursive(enb->dir);
>> +                     return -ENOMEM;
>> +             }
>
> Few lines how this work would be welcome...?

OK, I'll add a comment like below.

/*
 * Create debugfs r/w file containing action->error. If notifier call
 * chain is called with action->val, it will fail with the error code
 */
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Pavel Machek 

> + for (action = enb->actions; action->name; action++) {
> + struct dentry *file = debugfs_create_int(action->name, mode,
> + enb->dir, &action->error);
> +
> + if (!file) {
> + debugfs_remove_recursive(enb->dir);
> + return -ENOMEM;
> + }

Few lines how this work would be welcome...?
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev