Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED
At Wed, 21 Sep 2011 11:55:36 +0200 (CEST), Thomas Gleixner wrote: We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Do you want to merge by yourself or shall I take it to sound git tree? Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based tree, right? Yes, please go ahead. I'll pick up the leftovers. OK, I applied Yong's (fixed) patch now to sound git tree. thanks, Takashi ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED
At Wed, 21 Sep 2011 17:28:54 +0800,
Yong Zhang wrote:
Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
Hm, this id hits a different commit:
commit c58543c869606532c2382f027d6466f4672ea756
Author: David S. Miller da...@davemloft.net
Date: Tue Oct 13 00:49:09 2009 -0700
sparc64: Set IRQF_DISABLED on LDC channel IRQs.
You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922?
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).
So now this flag is a NOOP and can be removed.
Signed-off-by: Yong Zhang yong.zha...@gmail.com
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
Do you want to merge by yourself or shall I take it to sound git tree?
Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based
tree, right?
Anyway, if needed, take my ack:
Acked-by: Takashi Iwai ti...@suse.de
thanks,
Takashi
---
include/sound/initval.h|2 +-
sound/arm/aaci.c |2 +-
sound/arm/pxa2xx-ac97-lib.c|2 +-
sound/drivers/ml403-ac97cr.c |4 ++--
sound/drivers/mpu401/mpu401_uart.c |2 +-
sound/drivers/mtpav.c |2 +-
sound/drivers/serial-u16550.c |2 +-
sound/isa/ad1816a/ad1816a_lib.c|2 +-
sound/isa/es1688/es1688_lib.c |2 +-
sound/isa/es18xx.c |2 +-
sound/isa/gus/gus_main.c |2 +-
sound/isa/gus/gusmax.c |2 +-
sound/isa/gus/interwave.c |2 +-
sound/isa/opl3sa2.c|2 +-
sound/isa/opti9xx/opti92x-ad1848.c |2 +-
sound/isa/sb/sb_common.c |2 +-
sound/isa/wavefront/wavefront.c|2 +-
sound/isa/wss/wss_lib.c|2 +-
sound/mips/au1x00.c|4 ++--
sound/pci/sis7019.c|4 ++--
sound/ppc/snd_ps3.c|2 +-
sound/soc/au1x/dma.c |2 +-
sound/soc/codecs/tlv320dac33.c |2 +-
sound/soc/nuc900/nuc900-pcm.c |2 +-
sound/soc/samsung/ac97.c |2 +-
sound/soc/sh/fsi.c |2 +-
sound/soc/txx9/txx9aclc-ac97.c |2 +-
sound/sparc/amd7930.c |2 +-
28 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/include/sound/initval.h b/include/sound/initval.h
index 1daa6df..f99a0d2 100644
--- a/include/sound/initval.h
+++ b/include/sound/initval.h
@@ -62,7 +62,7 @@ static int snd_legacy_find_free_irq(int *irq_table)
{
while (*irq_table != -1) {
if (!request_irq(*irq_table, snd_legacy_empty_irq_handler,
- IRQF_DISABLED | IRQF_PROBE_SHARED, ALSA Test
IRQ,
+ IRQF_PROBE_SHARED, ALSA Test IRQ,
(void *) irq_table)) {
free_irq(*irq_table, (void *) irq_table);
return *irq_table;
diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
index d0cead3..e518d38 100644
--- a/sound/arm/aaci.c
+++ b/sound/arm/aaci.c
@@ -443,7 +443,7 @@ static int aaci_pcm_open(struct snd_pcm_substream
*substream)
mutex_lock(aaci-irq_lock);
if (!aaci-users++) {
ret = request_irq(aaci-dev-irq[0], aaci_irq,
-IRQF_SHARED | IRQF_DISABLED, DRIVER_NAME, aaci);
+IRQF_SHARED, DRIVER_NAME, aaci);
if (ret != 0)
aaci-users--;
}
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
index 88eec38..8ad6535 100644
--- a/sound/arm/pxa2xx-ac97-lib.c
+++ b/sound/arm/pxa2xx-ac97-lib.c
@@ -359,7 +359,7 @@ int __devinit pxa2xx_ac97_hw_probe(struct platform_device
*dev)
if (ret)
goto err_clk2;
- ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, IRQF_DISABLED, AC97,
NULL);
+ ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, 0, AC97, NULL);
if (ret 0)
goto err_irq;
diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c
index 5cfcb90..2c7a763 100644
--- a/sound/drivers/ml403-ac97cr.c
+++ b/sound/drivers/ml403-ac97cr.c
@@ -1153,7 +1153,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct
platform_device *pfdev,
0x%x done\n, (unsigned int)ml403_ac97cr-port);
/* get irq */
irq = platform_get_irq(pfdev, 0);
- if (request_irq(irq, snd_ml403_ac97cr_irq, IRQF_DISABLED,
+ if (request_irq(irq, snd_ml403_ac97cr_irq, 0,
dev_name(pfdev-dev), (void *)ml403_ac97cr)) {
snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER :
unable to grab IRQ %d\n,
@@ -1166,7 +1166,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct
platform_device *pfdev,
request (playback) irq %d
Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED
On Wed, 21 Sep 2011, Takashi Iwai wrote: At Wed, 21 Sep 2011 17:28:54 +0800, Yong Zhang wrote: Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], Hm, this id hits a different commit: commit c58543c869606532c2382f027d6466f4672ea756 Author: David S. Miller da...@davemloft.net Date: Tue Oct 13 00:49:09 2009 -0700 sparc64: Set IRQF_DISABLED on LDC channel IRQs. You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922? Yeah. We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Do you want to merge by yourself or shall I take it to sound git tree? Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based tree, right? Yes, please go ahead. I'll pick up the leftovers. Thanks, tglx ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED
On Wed, Sep 21, 2011 at 12:28 PM, Yong Zhang yong.zha...@gmail.com wrote: Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Peter Ujfalusi peter.ujfal...@ti.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED
On Wed, Sep 21, 2011 at 11:52:00AM +0200, Takashi Iwai wrote:
At Wed, 21 Sep 2011 17:28:54 +0800,
Yong Zhang wrote:
Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
Hm, this id hits a different commit:
commit c58543c869606532c2382f027d6466f4672ea756
Author: David S. Miller da...@davemloft.net
Date: Tue Oct 13 00:49:09 2009 -0700
sparc64: Set IRQF_DISABLED on LDC channel IRQs.
You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922?
Oh, yes. No idea how I made it wrong :(
Thanks,
Yong
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).
So now this flag is a NOOP and can be removed.
Signed-off-by: Yong Zhang yong.zha...@gmail.com
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
Do you want to merge by yourself or shall I take it to sound git tree?
Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based
tree, right?
Anyway, if needed, take my ack:
Acked-by: Takashi Iwai ti...@suse.de
thanks,
Takashi
---
include/sound/initval.h|2 +-
sound/arm/aaci.c |2 +-
sound/arm/pxa2xx-ac97-lib.c|2 +-
sound/drivers/ml403-ac97cr.c |4 ++--
sound/drivers/mpu401/mpu401_uart.c |2 +-
sound/drivers/mtpav.c |2 +-
sound/drivers/serial-u16550.c |2 +-
sound/isa/ad1816a/ad1816a_lib.c|2 +-
sound/isa/es1688/es1688_lib.c |2 +-
sound/isa/es18xx.c |2 +-
sound/isa/gus/gus_main.c |2 +-
sound/isa/gus/gusmax.c |2 +-
sound/isa/gus/interwave.c |2 +-
sound/isa/opl3sa2.c|2 +-
sound/isa/opti9xx/opti92x-ad1848.c |2 +-
sound/isa/sb/sb_common.c |2 +-
sound/isa/wavefront/wavefront.c|2 +-
sound/isa/wss/wss_lib.c|2 +-
sound/mips/au1x00.c|4 ++--
sound/pci/sis7019.c|4 ++--
sound/ppc/snd_ps3.c|2 +-
sound/soc/au1x/dma.c |2 +-
sound/soc/codecs/tlv320dac33.c |2 +-
sound/soc/nuc900/nuc900-pcm.c |2 +-
sound/soc/samsung/ac97.c |2 +-
sound/soc/sh/fsi.c |2 +-
sound/soc/txx9/txx9aclc-ac97.c |2 +-
sound/sparc/amd7930.c |2 +-
28 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/include/sound/initval.h b/include/sound/initval.h
index 1daa6df..f99a0d2 100644
--- a/include/sound/initval.h
+++ b/include/sound/initval.h
@@ -62,7 +62,7 @@ static int snd_legacy_find_free_irq(int *irq_table)
{
while (*irq_table != -1) {
if (!request_irq(*irq_table, snd_legacy_empty_irq_handler,
-IRQF_DISABLED | IRQF_PROBE_SHARED, ALSA Test
IRQ,
+IRQF_PROBE_SHARED, ALSA Test IRQ,
(void *) irq_table)) {
free_irq(*irq_table, (void *) irq_table);
return *irq_table;
diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
index d0cead3..e518d38 100644
--- a/sound/arm/aaci.c
+++ b/sound/arm/aaci.c
@@ -443,7 +443,7 @@ static int aaci_pcm_open(struct snd_pcm_substream
*substream)
mutex_lock(aaci-irq_lock);
if (!aaci-users++) {
ret = request_irq(aaci-dev-irq[0], aaci_irq,
- IRQF_SHARED | IRQF_DISABLED, DRIVER_NAME, aaci);
+ IRQF_SHARED, DRIVER_NAME, aaci);
if (ret != 0)
aaci-users--;
}
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
index 88eec38..8ad6535 100644
--- a/sound/arm/pxa2xx-ac97-lib.c
+++ b/sound/arm/pxa2xx-ac97-lib.c
@@ -359,7 +359,7 @@ int __devinit pxa2xx_ac97_hw_probe(struct
platform_device *dev)
if (ret)
goto err_clk2;
- ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, IRQF_DISABLED, AC97,
NULL);
+ ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, 0, AC97, NULL);
if (ret 0)
goto err_irq;
diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c
index 5cfcb90..2c7a763 100644
--- a/sound/drivers/ml403-ac97cr.c
+++ b/sound/drivers/ml403-ac97cr.c
@@ -1153,7 +1153,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct
platform_device *pfdev,
0x%x done\n, (unsigned int)ml403_ac97cr-port);
/* get irq */
irq = platform_get_irq(pfdev, 0);
- if (request_irq(irq, snd_ml403_ac97cr_irq, IRQF_DISABLED,
+ if (request_irq(irq, snd_ml403_ac97cr_irq, 0,
dev_name(pfdev-dev), (void *)ml403_ac97cr)) {
snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER :
Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED
On Wed, Sep 21, 2011 at 11:55:36AM +0200, Thomas Gleixner wrote: On Wed, 21 Sep 2011, Takashi Iwai wrote: At Wed, 21 Sep 2011 17:28:54 +0800, Yong Zhang wrote: Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], Hm, this id hits a different commit: commit c58543c869606532c2382f027d6466f4672ea756 Author: David S. Miller da...@davemloft.net Date: Tue Oct 13 00:49:09 2009 -0700 sparc64: Set IRQF_DISABLED on LDC channel IRQs. You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922? Yeah. We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Do you want to merge by yourself or shall I take it to sound git tree? Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based tree, right? Yes, please go ahead. I'll pick up the leftovers. Takashi, if you take it, could you please modify that commit id to the right one? Otherwise I could change it when I refresh this patchset. Thanks, Yong ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
