Re: [PATCH v2] powerpc/Makefile: Mark phony targets as PHONY
Masahiro Yamada writes: > On Fri, Mar 6, 2020 at 9:27 AM Michael Ellerman > wrote: >> >> On Wed, 2020-02-19 at 00:04:34 UTC, Michael Ellerman wrote: >> > Some of our phony targets are not marked as such. This can lead to >> > confusing errors, eg: >> > >> > $ make clean >> > $ touch install >> > $ make install >> > make: 'install' is up to date. >> > $ >> > >> > Fix it by adding them to the PHONY variable which is marked phony in >> > the top-level Makefile, or in scripts/Makefile.build for the boot >> > Makefile. >> > >> > Suggested-by: Masahiro Yamada >> > Signed-off-by: Michael Ellerman >> >> Applied to powerpc next. >> >> https://git.kernel.org/powerpc/c/d42c6d0f8d004c3661dde3c376ed637e9f292c22 >> > > You do not have to double your Signed-off-by. Oops :/ My scripts don't cope with applying my own patches very well. Will try to fix it. cheers
Re: [PATCH v2] powerpc/Makefile: Mark phony targets as PHONY
On Fri, Mar 6, 2020 at 9:27 AM Michael Ellerman wrote: > > On Wed, 2020-02-19 at 00:04:34 UTC, Michael Ellerman wrote: > > Some of our phony targets are not marked as such. This can lead to > > confusing errors, eg: > > > > $ make clean > > $ touch install > > $ make install > > make: 'install' is up to date. > > $ > > > > Fix it by adding them to the PHONY variable which is marked phony in > > the top-level Makefile, or in scripts/Makefile.build for the boot > > Makefile. > > > > Suggested-by: Masahiro Yamada > > Signed-off-by: Michael Ellerman > > Applied to powerpc next. > > https://git.kernel.org/powerpc/c/d42c6d0f8d004c3661dde3c376ed637e9f292c22 > You do not have to double your Signed-off-by. -- Best Regards Masahiro Yamada
Re: [PATCH v2] powerpc/Makefile: Mark phony targets as PHONY
On Wed, 2020-02-19 at 00:04:34 UTC, Michael Ellerman wrote: > Some of our phony targets are not marked as such. This can lead to > confusing errors, eg: > > $ make clean > $ touch install > $ make install > make: 'install' is up to date. > $ > > Fix it by adding them to the PHONY variable which is marked phony in > the top-level Makefile, or in scripts/Makefile.build for the boot > Makefile. > > Suggested-by: Masahiro Yamada > Signed-off-by: Michael Ellerman Applied to powerpc next. https://git.kernel.org/powerpc/c/d42c6d0f8d004c3661dde3c376ed637e9f292c22 cheers
Re: [PATCH v2] powerpc/Makefile: Mark phony targets as PHONY
On Wed, Feb 19, 2020 at 9:04 AM Michael Ellerman wrote: > > Some of our phony targets are not marked as such. This can lead to > confusing errors, eg: > > $ make clean > $ touch install > $ make install > make: 'install' is up to date. > $ > > Fix it by adding them to the PHONY variable which is marked phony in > the top-level Makefile, or in scripts/Makefile.build for the boot > Makefile. > > Suggested-by: Masahiro Yamada > Signed-off-by: Michael Ellerman > --- Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada
