Re: [PATCH v6 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC
On Tue, Apr 14, 2020 at 9:56 PM Shengjiu Wang wrote: > > Hi Rob > > On Tue, Apr 14, 2020 at 11:49 PM Rob Herring wrote: > > > > On Wed, Apr 01, 2020 at 04:45:39PM +0800, Shengjiu Wang wrote: > > > EASRC (Enhanced Asynchronous Sample Rate Converter) is a new > > > IP module found on i.MX8MN. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > .../devicetree/bindings/sound/fsl,easrc.yaml | 101 ++ > > > 1 file changed, 101 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > new file mode 100644 > > > index ..14ea60084420 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > @@ -0,0 +1,101 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NXP Asynchronous Sample Rate Converter (ASRC) Controller > > > + > > > +maintainers: > > > + - Shengjiu Wang > > > + > > > +properties: > > > + $nodename: > > > +pattern: "^easrc@.*" > > > + > > > + compatible: > > > +const: fsl,imx8mn-easrc > > > + > > > + reg: > > > +maxItems: 1 > > > + > > > + interrupts: > > > +maxItems: 1 > > > + > > > + clocks: > > > +items: > > > + - description: Peripheral clock > > > + > > > + clock-names: > > > +items: > > > + - const: mem > > > + > > > + dmas: > > > +maxItems: 8 > > > + > > > + dma-names: > > > +items: > > > + - const: ctx0_rx > > > + - const: ctx0_tx > > > + - const: ctx1_rx > > > + - const: ctx1_tx > > > + - const: ctx2_rx > > > + - const: ctx2_tx > > > + - const: ctx3_rx > > > + - const: ctx3_tx > > > + > > > + firmware-name: > > > +allOf: > > > + - $ref: /schemas/types.yaml#/definitions/string > > > + - const: imx/easrc/easrc-imx8mn.bin > > > +description: The coefficient table for the filters > > > + > > > + fsl,asrc-rate: > > > > fsl,asrc-rate-hz > > Can we keep "fsl,asrc-rate", because I want this property > align with the one in fsl,asrc.txt. These two asrc modules > can share same property name. Oh, yes. So with the example fixed: Reviewed-by: Rob Herring
Re: [PATCH v6 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC
Hi Rob On Tue, Apr 14, 2020 at 11:49 PM Rob Herring wrote: > > On Wed, Apr 01, 2020 at 04:45:39PM +0800, Shengjiu Wang wrote: > > EASRC (Enhanced Asynchronous Sample Rate Converter) is a new > > IP module found on i.MX8MN. > > > > Signed-off-by: Shengjiu Wang > > --- > > .../devicetree/bindings/sound/fsl,easrc.yaml | 101 ++ > > 1 file changed, 101 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > new file mode 100644 > > index ..14ea60084420 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > @@ -0,0 +1,101 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP Asynchronous Sample Rate Converter (ASRC) Controller > > + > > +maintainers: > > + - Shengjiu Wang > > + > > +properties: > > + $nodename: > > +pattern: "^easrc@.*" > > + > > + compatible: > > +const: fsl,imx8mn-easrc > > + > > + reg: > > +maxItems: 1 > > + > > + interrupts: > > +maxItems: 1 > > + > > + clocks: > > +items: > > + - description: Peripheral clock > > + > > + clock-names: > > +items: > > + - const: mem > > + > > + dmas: > > +maxItems: 8 > > + > > + dma-names: > > +items: > > + - const: ctx0_rx > > + - const: ctx0_tx > > + - const: ctx1_rx > > + - const: ctx1_tx > > + - const: ctx2_rx > > + - const: ctx2_tx > > + - const: ctx3_rx > > + - const: ctx3_tx > > + > > + firmware-name: > > +allOf: > > + - $ref: /schemas/types.yaml#/definitions/string > > + - const: imx/easrc/easrc-imx8mn.bin > > +description: The coefficient table for the filters > > + > > + fsl,asrc-rate: > > fsl,asrc-rate-hz Can we keep "fsl,asrc-rate", because I want this property align with the one in fsl,asrc.txt. These two asrc modules can share same property name. best regards wang shengjiu
Re: [PATCH v6 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC
On Wed, Apr 01, 2020 at 04:45:39PM +0800, Shengjiu Wang wrote:
> EASRC (Enhanced Asynchronous Sample Rate Converter) is a new
> IP module found on i.MX8MN.
>
> Signed-off-by: Shengjiu Wang
> ---
> .../devicetree/bindings/sound/fsl,easrc.yaml | 101 ++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> new file mode 100644
> index ..14ea60084420
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> @@ -0,0 +1,101 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP Asynchronous Sample Rate Converter (ASRC) Controller
> +
> +maintainers:
> + - Shengjiu Wang
> +
> +properties:
> + $nodename:
> +pattern: "^easrc@.*"
> +
> + compatible:
> +const: fsl,imx8mn-easrc
> +
> + reg:
> +maxItems: 1
> +
> + interrupts:
> +maxItems: 1
> +
> + clocks:
> +items:
> + - description: Peripheral clock
> +
> + clock-names:
> +items:
> + - const: mem
> +
> + dmas:
> +maxItems: 8
> +
> + dma-names:
> +items:
> + - const: ctx0_rx
> + - const: ctx0_tx
> + - const: ctx1_rx
> + - const: ctx1_tx
> + - const: ctx2_rx
> + - const: ctx2_tx
> + - const: ctx3_rx
> + - const: ctx3_tx
> +
> + firmware-name:
> +allOf:
> + - $ref: /schemas/types.yaml#/definitions/string
> + - const: imx/easrc/easrc-imx8mn.bin
> +description: The coefficient table for the filters
> +
> + fsl,asrc-rate:
fsl,asrc-rate-hz
> +allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
And then you can drop this.
> + - minimum: 8000
> + - maximum: 192000
> +description: Defines a mutual sample rate used by DPCM Back Ends
> +
> + fsl,asrc-format:
> +allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - enum: [2, 6, 10, 32, 36]
> +default: 2
> +description:
> + Defines a mutual sample format used by DPCM Back Ends
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> + - firmware-name
> + - fsl,asrc-rate
> + - fsl,asrc-format
> +
> +examples:
> + - |
> +#include
> +
> +easrc: easrc@300C {
Lowercase hex
> + compatible = "fsl,imx8mn-easrc";
> + reg = <0x0 0x300C 0x0 0x1>;
> + interrupts = <0x0 122 0x4>;
> + clocks = < IMX8MN_CLK_ASRC_ROOT>;
> + clock-names = "mem";
> + dmas = < 16 23 0> , < 17 23 0>,
> + < 18 23 0> , < 19 23 0>,
> + < 20 23 0> , < 21 23 0>,
> + < 22 23 0> , < 23 23 0>;
> + dma-names = "ctx0_rx", "ctx0_tx",
> + "ctx1_rx", "ctx1_tx",
> + "ctx2_rx", "ctx2_tx",
> + "ctx3_rx", "ctx3_tx";
> + firmware-name = "imx/easrc/easrc-imx8mn.bin";
> + fsl,asrc-rate = <8000>;
> + fsl,asrc-format = <2>;
> +};
> --
> 2.21.0
>
