Re: [PATCH v9 07/27] net: wan: Add support for QMC HDLC
On 3/14/24 08:31, Christophe Leroy wrote:
Le 14/03/2024 à 16:21, Guenter Roeck a écrit :
On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:
The QMC HDLC driver provides support for HDLC using the QMC (QUICC
Multichannel Controller) to transfer the HDLC data.
Signed-off-by: Herve Codina
Reviewed-by: Christophe Leroy
Acked-by: Jakub Kicinski
---
[ ... ]
+
+static const struct of_device_id qmc_hdlc_id_table[] = {
+ { .compatible = "fsl,qmc-hdlc" },
+ {} /* sentinel */
+};
+MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
I am a bit puzzled. How does this even compile ?
Because
#else /* !MODULE */
#define MODULE_DEVICE_TABLE(type, name)
#endif
Ah, makes sense. We live and learn.
We should probably try to catch those errors when CONFIG_MODULE is not set.
By the way, a fix is available at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240314123346.461350-1-herve.cod...@bootlin.com/
Great, I'll add that to my testing branch for the time being.
Thanks!
Guenter
Re: [PATCH v9 07/27] net: wan: Add support for QMC HDLC
Le 14/03/2024 à 16:21, Guenter Roeck a écrit :
> On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:
>> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
>> Multichannel Controller) to transfer the HDLC data.
>>
>> Signed-off-by: Herve Codina
>> Reviewed-by: Christophe Leroy
>> Acked-by: Jakub Kicinski
>> ---
> [ ... ]
>
>> +
>> +static const struct of_device_id qmc_hdlc_id_table[] = {
>> +{ .compatible = "fsl,qmc-hdlc" },
>> +{} /* sentinel */
>> +};
>> +MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
>
> I am a bit puzzled. How does this even compile ?
Because
#else /* !MODULE */
#define MODULE_DEVICE_TABLE(type, name)
#endif
We should probably try to catch those errors when CONFIG_MODULE is not set.
By the way, a fix is available at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240314123346.461350-1-herve.cod...@bootlin.com/
Christophe
Re: [PATCH v9 07/27] net: wan: Add support for QMC HDLC
On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:
> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
> Multichannel Controller) to transfer the HDLC data.
>
> Signed-off-by: Herve Codina
> Reviewed-by: Christophe Leroy
> Acked-by: Jakub Kicinski
> ---
[ ... ]
> +
> +static const struct of_device_id qmc_hdlc_id_table[] = {
> + { .compatible = "fsl,qmc-hdlc" },
> + {} /* sentinel */
> +};
> +MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
I am a bit puzzled. How does this even compile ?
Building powerpc:ppc32_allmodconfig ... failed
--
Error log:
In file included from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/dma-mapping.h:8,
from drivers/net/wan/fsl_qmc_hdlc.c:14:
drivers/net/wan/fsl_qmc_hdlc.c:783:25: error: 'qmc_hdlc_driver' undeclared here
(not in a function); did you mean 'qmc_hdlc_probe'?
783 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
Guenter
> +
> +static struct platform_driver qmc_hdlc_driver = {
> + .driver = {
> + .name = "fsl-qmc-hdlc",
> + .of_match_table = qmc_hdlc_id_table,
> + },
> + .probe = qmc_hdlc_probe,
> + .remove = qmc_hdlc_remove,
> +};
> +module_platform_driver(qmc_hdlc_driver);
> +
> +MODULE_AUTHOR("Herve Codina ");
> +MODULE_DESCRIPTION("QMC HDLC driver");
> +MODULE_LICENSE("GPL");
> --
> 2.41.0
>
