Re: [RFC v5 00/26] Re-use nvram module
On Sun, 16 Aug 2015, Geert Uytterhoeven wrote:
Hi Finn,
On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain fth...@telegraphics.com.au
wrote:
The generic NVRAM module, drivers/char/generic_nvram, implements a
/dev/nvram misc device. It is used only by 32-bit PowerPC platforms
and isn't generic enough to be more widely used.
[...]
Thanks!
You can add my
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org
to patches 03, 04, 11, 19, 23, 24, 25, 26.
Thanks for reviewing.
BTW, checkpatch reported a few newly-introduced whitespace errors in
patches 03, 05, 16, 24, and 25.
I will check again, but I'm sure those are all deliberate. I examined all
the errors and warnings before submitting.
checkpatch doesn't really understand the difference between whitespace
used for indentation of statements (according to scope) and whitespace
used for alignment of terms or parameters (when line-wrapped). Any tool
that fails to make that distinction can't be depended upon to correctly
validate the elisp in Documentation/CodingStyle, for example.
--
Gr{oetje,eeting}s,
Geert
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [RFC v5 00/26] Re-use nvram module
Hi Finn,
On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain fth...@telegraphics.com.au wrote:
BTW, checkpatch reported a few newly-introduced whitespace errors in
patches 03, 05, 16, 24, and 25.
I will check again, but I'm sure those are all deliberate. I examined all
the errors and warnings before submitting.
checkpatch doesn't really understand the difference between whitespace
used for indentation of statements (according to scope) and whitespace
used for alignment of terms or parameters (when line-wrapped). Any tool
that fails to make that distinction can't be depended upon to correctly
validate the elisp in Documentation/CodingStyle, for example.
Checkpatch complains because you don't replace a sequence of 8 spaces
by a TAB in continuation lines.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [RFC v5 00/26] Re-use nvram module
On Mon, 17 Aug 2015, Geert Uytterhoeven wrote:
On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain
fth...@telegraphics.com.au wrote:
BTW, checkpatch reported a few newly-introduced whitespace errors in
patches 03, 05, 16, 24, and 25.
I will check again, but I'm sure those are all deliberate. I examined
all the errors and warnings before submitting.
checkpatch doesn't really understand the difference between whitespace
used for indentation of statements (according to scope) and whitespace
used for alignment of terms or parameters (when line-wrapped). Any
tool that fails to make that distinction can't be depended upon to
correctly validate the elisp in Documentation/CodingStyle, for
example.
Checkpatch complains because you don't replace a sequence of 8 spaces by
a TAB in continuation lines.
Right. Were such a sequence used for indentation, a tab should be used
instead. After those tabs, spaces are needed for alignment (see elisp
example mentioned above).
But I sure wouldn't want to try to encode that distinction in regexp (as
opposed to comparing a patch with its pretty-printed version, as might be
generated by an actual C parser). So I expect some false positives from
checkpatch.
--
Gr{oetje,eeting}s,
Geert
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [RFC v5 00/26] Re-use nvram module
Hi Finn,
On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain fth...@telegraphics.com.au wrote:
The generic NVRAM module, drivers/char/generic_nvram, implements a
/dev/nvram misc device. It is used only by 32-bit PowerPC platforms and
isn't generic enough to be more widely used.
[...]
Thanks!
You can add my
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org
to patches 03, 04, 11, 19, 23, 24, 25, 26.
BTW, checkpatch reported a few newly-introduced whitespace errors in patches
03, 05, 16, 24, and 25.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
