Re: [patch 1/5] powerpc: Sky CPU: redundant or incorrect tests on unsigned
On Thu, 2009-12-17 at 16:44 -0800, a...@linux-foundation.org wrote:
From: Roel Kluin roel.kl...@gmail.com
count is unsigned and cannot be less than 0.
Is this really a powerpc thing ?
This driver is only build with CONFIG_HDPU_FEATURES and a git grep
HDPU_FEATURES returns no Kconfig that defines it :-)
I'm happy to apply such a trivial thing but it's weird isn't it ?
Cheers,
Ben.
Signed-off-by: Roel Kluin roel.kl...@gmail.com
Acked-by: Cyrill Gorcunov gorcu...@gmail.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Kumar Gala ga...@gate.crashing.org
Cc: Brian Waite wa...@skycomputers.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
---
drivers/misc/hdpuftrs/hdpu_cpustate.c |5 -
1 file changed, 5 deletions(-)
diff -puN
drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
drivers/misc/hdpuftrs/hdpu_cpustate.c
---
a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
{
unsigned char data;
- if (count 0)
- return -EFAULT;
if (count == 0)
return 0;
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
{
unsigned char data;
- if (count 0)
- return -EFAULT;
-
if (count == 0)
return 0;
_
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [patch 1/5] powerpc: Sky CPU: redundant or incorrect tests on unsigned
On Fri, 2009-12-18 at 14:40 +1100, Benjamin Herrenschmidt wrote:
On Thu, 2009-12-17 at 16:44 -0800, a...@linux-foundation.org wrote:
From: Roel Kluin roel.kl...@gmail.com
count is unsigned and cannot be less than 0.
Is this really a powerpc thing ?
This driver is only build with CONFIG_HDPU_FEATURES and a git grep
HDPU_FEATURES returns no Kconfig that defines it :-)
I'm happy to apply such a trivial thing but it's weird isn't it ?
Ok so it looks like some old stuff that got removed a long time ago and
never made it to arch/powerpc.
I'll send a patch to just remove the whole driver, it's stale.
Cheers,
Ben.
Cheers,
Ben.
Signed-off-by: Roel Kluin roel.kl...@gmail.com
Acked-by: Cyrill Gorcunov gorcu...@gmail.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Kumar Gala ga...@gate.crashing.org
Cc: Brian Waite wa...@skycomputers.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
---
drivers/misc/hdpuftrs/hdpu_cpustate.c |5 -
1 file changed, 5 deletions(-)
diff -puN
drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
drivers/misc/hdpuftrs/hdpu_cpustate.c
---
a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
{
unsigned char data;
- if (count 0)
- return -EFAULT;
if (count == 0)
return 0;
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
{
unsigned char data;
- if (count 0)
- return -EFAULT;
-
if (count == 0)
return 0;
_
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
