Re: 82xx, mgcoge: updates for 2.6.32
On Wed, Jul 29, 2009 at 10:32:30AM +0200, Heiko Schocher wrote:
[snip]
+ m...@10d40 {
+ device_type = mdio;
Drop this device_type.
+ compatible = fsl,cpm2-mdio-bitbang;
+ reg = 0x10d00 0x14;
+ #address-cells = 1;
+ #size-cells = 0;
+ fsl,mdio-pin = 12;
+ fsl,mdc-pin = 13;
+
+ phy0: ethernet-...@0 {
+ reg = 0x0;
+ device_type = ethernet-phy;
And this one, too.
+ };
+
+ phy1: ethernet-...@1 {
+ reg = 0x1;
+ device_type = ethernet-phy;
+ };
+ };
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: 82xx, mgcoge: updates for 2.6.32
On Jul 29, 2009, at 3:32 AM, Heiko Schocher wrote: - add I2C support - add FCC1 and FCC2 support - fix bogus gpio numbering in plattformcode Signed-off-by: Heiko Schocher h...@denx.de --- - based on git://git.kernel.org/pub/scm/linux/kernel/git/benh/ powerpc.git next branch - checked with checkpatch.pl: $ ./scripts/checkpatch.pl 0001-82xx-mgcoge-updates-for-2.6.32.patch total: 0 errors, 0 warnings, 531 lines checked 0001-82xx-mgcoge-updates-for-2.6.32.patch has no obvious style problems and is ready for submission. $ BTW: Who is PPC82XX Maintainer? I couldn;t find such an entry in the MAINTAINERS file ... its me. arch/powerpc/boot/dts/mgcoge.dts | 56 ++ arch/powerpc/configs/mgcoge_defconfig | 178 +--- Can we hold off or pull the defconfig update into a separate patch. I normally update defconfigs in a late -rc series and that will probably generate merge conflicts. arch/powerpc/platforms/82xx/mgcoge.c | 69 +++-- 3 files changed, 255 insertions(+), 48 deletions(-) - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: 82xx, mgcoge: updates for 2.6.32
Hello David,
David Gibson wrote:
On Wed, Jul 29, 2009 at 10:32:30AM +0200, Heiko Schocher wrote:
[snip]
+m...@10d40 {
+device_type = mdio;
Drop this device_type.
Done.
+compatible = fsl,cpm2-mdio-bitbang;
+reg = 0x10d00 0x14;
+#address-cells = 1;
+#size-cells = 0;
+fsl,mdio-pin = 12;
+fsl,mdc-pin = 13;
+
+phy0: ethernet-...@0 {
+reg = 0x0;
+device_type = ethernet-phy;
And this one, too.
Done.
+};
+
+phy1: ethernet-...@1 {
+reg = 0x1;
+device_type = ethernet-phy;
+};
+};
I collect more comments, then the patch follows.
Thanks
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: 82xx, mgcoge: updates for 2.6.32
Hello Kumar, Kumar Gala wrote: On Jul 29, 2009, at 3:32 AM, Heiko Schocher wrote: - add I2C support - add FCC1 and FCC2 support - fix bogus gpio numbering in plattformcode Signed-off-by: Heiko Schocher h...@denx.de --- - based on git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next branch - checked with checkpatch.pl: $ ./scripts/checkpatch.pl 0001-82xx-mgcoge-updates-for-2.6.32.patch total: 0 errors, 0 warnings, 531 lines checked 0001-82xx-mgcoge-updates-for-2.6.32.patch has no obvious style problems and is ready for submission. $ BTW: Who is PPC82XX Maintainer? I couldn;t find such an entry in the MAINTAINERS file ... its me. Ah, thought it, but I wasn;t sure ... Hmm, maybe you can update the MAINTAINERS entry? arch/powerpc/boot/dts/mgcoge.dts | 56 ++ arch/powerpc/configs/mgcoge_defconfig | 178 +--- Can we hold off or pull the defconfig update into a separate patch. I normally update defconfigs in a late -rc series and that will probably generate merge conflicts. I make a seperate patch for the defconfig. Thanks. I wait for more comments, before I post the next version of this patch. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
