Re: Status of patches (ppc32 mm init clean and 85xx kernel reloc)
[POWERPC] Clean up some linker and symbol usage No comments. Straight forward patch. Well, it is changing behaviour. In particular, klimit is not necessarily the same as _end. It starts out initialized to _end but then gets advanced by some allocations very early in the boot IIRC. It might be true by now that nothing reserves memory by advancing klimit any more, but if that is true then the patch description needs to mention that klimit is no longer used and this patch makes it no longer usable. In fact in that case you should remove all mention of klimit. Also, this patch means that the region from PHYSICAL_START to __pa(stext) is no longer reserved, which is another behaviour change that deserves to be mentioned. so I see iseries updating klimit. [POWERPC] Update linker script to properly set physical addresses You felt LOAD_OFFSET should be (CONFIG_PAGE_OFFSET - CONFIG_PHYSICAL_START). I disagreed. We need to resolve. I think you're right, actually, now, assuming that CONFIG_PHYSICAL_START is the physical address of the start of the kernel (actually, why don't you use that instead of __pa(stext) in your patch [9/11]?). I think I can just drop that change in the patch now that I look at it. My previous plan had been to get ride of PHYSICAL_START but now that we still have it I don't see any reason I need to change that particular lmb reserve. (i'll repost the full series with a minor bit of re-ordering). - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Status of patches (ppc32 mm init clean and 85xx kernel reloc)
Kumar Gala writes: [POWERPC] bootwrapper: Allow specifying of image physical offset reworked to look at PHDR (needs linker script update patch). Still open question on how best to do that (objdump, readelf, C program, suggestions) Just replied about that one. [POWERPC] Remove Kconfig option BOOT_LOAD should be acceptable. Looks OK. [POWERPC] Provide access to arch/powerpc include path on ppc64 Looks OK. [POWERPC] Remove and replace uses of PPC_MEMSTART with memstart_addr You had some questions about _stext and the PAGE_OFFSET vs KERNELBASE. Not sure if you are satisfied with the answers. The kdump guys don't seem to be concerned, so I guess it's OK. [POWERPC] Introduce lowmem_end_addr to distiguish from total_lowmem OK. [POWERPC] 85xx: Cleanup TLB initialization Only effects 85xx and I don't have issues with it :) Cool :) [POWERPC] Use lowmem_end_addr to limit lmb allocations on ppc32 Looks fine. [POWERPC] Rename __initial_memory_limit to __initial_memory_limit_addr Looks OK, though it seems a tad unnecessary. [POWERPC] Clean up some linker and symbol usage No comments. Straight forward patch. Well, it is changing behaviour. In particular, klimit is not necessarily the same as _end. It starts out initialized to _end but then gets advanced by some allocations very early in the boot IIRC. It might be true by now that nothing reserves memory by advancing klimit any more, but if that is true then the patch description needs to mention that klimit is no longer used and this patch makes it no longer usable. In fact in that case you should remove all mention of klimit. Also, this patch means that the region from PHYSICAL_START to __pa(stext) is no longer reserved, which is another behaviour change that deserves to be mentioned. [POWERPC] Move phys_addr_t definition into asm/types.h I had an open question if the Kconfig for PHYS_64BIT should get set on PPC64 as well (has not effect). I reworked the asm/types.h bits to look like: +#if defined(CONFIG_PPC64) || defined(CONFIG_PHYS_64BIT) +typedef __u64 phys_addr_t; +#else +typedef __u32 phys_addr_t; +#endif That looks OK. [POWERPC] 85xx: Add support for relocatble kernel (and booting at non- zero Should probably get a bit more review. [POWERPC] Update linker script to properly set physical addresses You felt LOAD_OFFSET should be (CONFIG_PAGE_OFFSET - CONFIG_PHYSICAL_START). I disagreed. We need to resolve. I think you're right, actually, now, assuming that CONFIG_PHYSICAL_START is the physical address of the start of the kernel (actually, why don't you use that instead of __pa(stext) in your patch [9/11]?). I think we should be able to quickly resolve and get into powerpc-next all but the '85xx: Add support for relocatable kernel' and 'bootwrapper: Allow specifying of image..' patches. If we can close on the phys_addr_t and linker script patches that would be great. I'll put in the ones that look OK, and wait for you to resend the others. Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Status of patches (ppc32 mm init clean and 85xx kernel reloc)
Paul, Here's my take on the current status of the patchset: [POWERPC] bootwrapper: Allow specifying of image physical offset reworked to look at PHDR (needs linker script update patch). Still open question on how best to do that (objdump, readelf, C program, suggestions) [POWERPC] Remove Kconfig option BOOT_LOAD should be acceptable. [POWERPC] Provide access to arch/powerpc include path on ppc64 should be acceptable (desired by others). [POWERPC] Remove and replace uses of PPC_MEMSTART with memstart_addr You had some questions about _stext and the PAGE_OFFSET vs KERNELBASE. Not sure if you are satisfied with the answers. [POWERPC] Introduce lowmem_end_addr to distiguish from total_lowmem No comments. Should be straight forward. [POWERPC] 85xx: Cleanup TLB initialization Only effects 85xx and I don't have issues with it :) [POWERPC] Use lowmem_end_addr to limit lmb allocations on ppc32 No comments. Straight forward patch. [POWERPC] Rename __initial_memory_limit to __initial_memory_limit_addr No comments. Straight forward patch. [POWERPC] Clean up some linker and symbol usage No comments. Straight forward patch. [POWERPC] Move phys_addr_t definition into asm/types.h I had an open question if the Kconfig for PHYS_64BIT should get set on PPC64 as well (has not effect). I reworked the asm/types.h bits to look like: +#if defined(CONFIG_PPC64) || defined(CONFIG_PHYS_64BIT) +typedef __u64 phys_addr_t; +#else +typedef __u32 phys_addr_t; +#endif [POWERPC] 85xx: Add support for relocatble kernel (and booting at non- zero Should probably get a bit more review. [POWERPC] Update linker script to properly set physical addresses You felt LOAD_OFFSET should be (CONFIG_PAGE_OFFSET - CONFIG_PHYSICAL_START). I disagreed. We need to resolve. I think we should be able to quickly resolve and get into powerpc-next all but the '85xx: Add support for relocatable kernel' and 'bootwrapper: Allow specifying of image..' patches. If we can close on the phys_addr_t and linker script patches that would be great. thanks - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
