Re: ioctl32 unknown cmds with 2.6.24-rc1

2007-10-25 Thread Geert Uytterhoeven
On Thu, 25 Oct 2007, Johannes Berg wrote:
 On Wed, 2007-10-24 at 16:27 +0200, Arnd Bergmann wrote:
  On Wednesday 24 October 2007, Johannes Berg wrote:
 Show Details
 I've been getting these warnings (many more of them but this is a list
   of unique ones) on my quad G5 with 32-bit userspace:
   
   ioctl32(cdrom_id:1078): Unknown cmd fd(3) cmd(5331){t:'S';sz:0} 
   arg() on /dev/.tmp-3-0
   ioctl32(ata_id:1095): Unknown cmd fd(3) cmd(030d){t:03;sz:0} 
   arg(ff863970) on /dev/.tmp-3-0
   ioctl32(smartd:3563): Unknown cmd fd(3) cmd(031f){t:03;sz:0} 
   arg(ffeb5480) on /dev/sda
   ioctl32(hald-probe-stor:3761): Unknown cmd fd(4) 
   cmd(5320){t:'S';sz:0} arg(0004) on /dev/hda
   ioctl32(gnome-terminal:4187): Unknown cmd fd(19) 
   cmd(530b){t:'S';sz:0} arg(0fd8e400) on /dev/pts/0
   
   Does anybody know whether this is expected?
  
  It's probably my fault, since I changed the compat ioctl handling for
  block devices. Geert already reported the same, but I haven't had
  a chance to reproduce it on my system to look into what went wrong.
  Probably a trivial bug I introduced in block/compat_ioctl.c
 
 I have to admit that ioctl numbers scare me :) Any idea what I should be
 looking for?

Fortunately there's nothing to really worry about, as it's purely cosmetic :-)

If you want to look into this, the question is just why these messages are
printed now, while they weren't printed before. I don't think any other
behavior got changed.

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:+32 (0)2 700 8453 
Fax:  +32 (0)2 700 8622 
E-mail:   [EMAIL PROTECTED] 
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe  
A division of Sony Service Centre (Europe) N.V. 
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium  
VAT BE 0413.825.160 · RPR Brussels  
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: ioctl32 unknown cmds with 2.6.24-rc1

2007-10-25 Thread Arnd Bergmann
On Thursday 25 October 2007, Geert Uytterhoeven wrote:
 If you want to look into this, the question is just why these messages are
 printed now, while they weren't printed before. I don't think any other
 behavior got changed.

I'm not so sure about that. The reason that the messages are printed now
is that there is no fallback handler for these ioctl numbers any more,
but they are instead expected to be handled by the compat_blkdev_ioctl()
function, which is only called for block devices.

My first idea was that the ioctl numbers are used on files that are
not block devices, in this case the warning message would be (somewhat)
appropriate.

Whenever we get one of these messages on a real block device, that is
supposed to mean that an ioctl that was actually valid could not be
executed, and compat_blkdev_ioctl() returned -ENOIOCTLCMD.

Arnd 
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: ioctl32 unknown cmds with 2.6.24-rc1

2007-10-25 Thread Geert Uytterhoeven
On Thu, 25 Oct 2007, Arnd Bergmann wrote:
 On Thursday 25 October 2007, Geert Uytterhoeven wrote:
  If you want to look into this, the question is just why these messages are
  printed now, while they weren't printed before. I don't think any other
  behavior got changed.
 
 I'm not so sure about that. The reason that the messages are printed now
 is that there is no fallback handler for these ioctl numbers any more,
 but they are instead expected to be handled by the compat_blkdev_ioctl()
 function, which is only called for block devices.
 
 My first idea was that the ioctl numbers are used on files that are
 not block devices, in this case the warning message would be (somewhat)
 appropriate.
 
 Whenever we get one of these messages on a real block device, that is
 supposed to mean that an ioctl that was actually valid could not be
 executed, and compat_blkdev_ioctl() returned -ENOIOCTLCMD.

In many cases these ioctls can indeed not be handled.
E.g. when using `hdparm -tT /dev/ps3da', hdparm issues an ioctl to flush the
cache. But this ioctl is not supported, not before and not after 2.6.23.
Before 2.6.23, it didn't print the message, in 2.6.23, it does.

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:+32 (0)2 700 8453 
Fax:  +32 (0)2 700 8622 
E-mail:   [EMAIL PROTECTED] 
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe  
A division of Sony Service Centre (Europe) N.V. 
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium  
VAT BE 0413.825.160 · RPR Brussels  
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

ioctl32 unknown cmds with 2.6.24-rc1

2007-10-24 Thread Johannes Berg
I've been getting these warnings (many more of them but this is a list
of unique ones) on my quad G5 with 32-bit userspace:

ioctl32(cdrom_id:1078): Unknown cmd fd(3) cmd(5331){t:'S';sz:0} 
arg() on /dev/.tmp-3-0
ioctl32(ata_id:1095): Unknown cmd fd(3) cmd(030d){t:03;sz:0} arg(ff863970) 
on /dev/.tmp-3-0
ioctl32(smartd:3563): Unknown cmd fd(3) cmd(031f){t:03;sz:0} arg(ffeb5480) 
on /dev/sda
ioctl32(hald-probe-stor:3761): Unknown cmd fd(4) cmd(5320){t:'S';sz:0} 
arg(0004) on /dev/hda
ioctl32(gnome-terminal:4187): Unknown cmd fd(19) cmd(530b){t:'S';sz:0} 
arg(0fd8e400) on /dev/pts/0

Does anybody know whether this is expected?

johannes


signature.asc
Description: This is a digitally signed message part
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: ioctl32 unknown cmds with 2.6.24-rc1

2007-10-24 Thread Arnd Bergmann
On Wednesday 24 October 2007, Johannes Berg wrote:
   Show Details
   I've been getting these warnings (many more of them but this is a list
 of unique ones) on my quad G5 with 32-bit userspace:
 
 ioctl32(cdrom_id:1078): Unknown cmd fd(3) cmd(5331){t:'S';sz:0} 
 arg() on /dev/.tmp-3-0
 ioctl32(ata_id:1095): Unknown cmd fd(3) cmd(030d){t:03;sz:0} 
 arg(ff863970) on /dev/.tmp-3-0
 ioctl32(smartd:3563): Unknown cmd fd(3) cmd(031f){t:03;sz:0} 
 arg(ffeb5480) on /dev/sda
 ioctl32(hald-probe-stor:3761): Unknown cmd fd(4) cmd(5320){t:'S';sz:0} 
 arg(0004) on /dev/hda
 ioctl32(gnome-terminal:4187): Unknown cmd fd(19) cmd(530b){t:'S';sz:0} 
 arg(0fd8e400) on /dev/pts/0
 
 Does anybody know whether this is expected?

It's probably my fault, since I changed the compat ioctl handling for
block devices. Geert already reported the same, but I haven't had
a chance to reproduce it on my system to look into what went wrong.
Probably a trivial bug I introduced in block/compat_ioctl.c

Arnd 
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev