Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Grant Likely
On Sat, 17 Mar 2012 08:23:54 +1100, Benjamin Herrenschmidt 
b...@kernel.crashing.org wrote:
 On Fri, 2012-03-16 at 16:21 -0500, Kumar Gala wrote:
  Guys,
  
  Are you aware of any reason that we can't call of_platform_bus_probe()
  or multiple times.  Timur's run into an issue in which all devices
  don't get registered properly if we call of_platform_bus_probe() times
  with different of_device_id struct's.
 
 Nothing comes to mind... Grant ?

Neither for me.  Should work.

g.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Tabi Timur-B04825
Grant Likely wrote:
 Are you aware of any reason that we can't call of_platform_bus_probe()
 or multiple times.  Timur's run into an issue in which all devices
 don't get registered properly if we call of_platform_bus_probe() times
 with different of_device_id struct's.
 
   Nothing comes to mind... Grant ?
 Neither for me.  Should work.

I posted a work-around patch here:

http://patchwork.ozlabs.org/patch/128533/

Without this patch, drivers cannot probe on DMA *channels*, or any other 
grandchildren of the root node.

-- 
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Benjamin Herrenschmidt
On Sat, 2012-03-17 at 13:35 +, Tabi Timur-B04825 wrote:
  Are you aware of any reason that we can't call
 of_platform_bus_probe()
  or multiple times.  Timur's run into an issue in which all
 devices
  don't get registered properly if we call
 of_platform_bus_probe() times
  with different of_device_id struct's.
  
Nothing comes to mind... Grant ?
  Neither for me.  Should work.
 
 I posted a work-around patch here:
 
 http://patchwork.ozlabs.org/patch/128533/
 
 Without this patch, drivers cannot probe on DMA *channels*, or any
 other 
 grandchildren of the root node. 

Why don't you track down the actual bug instead ?

Cheers,
Ben.



___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


issues calling of_platform_bus_probe() twice

2012-03-16 Thread Kumar Gala
Guys,

Are you aware of any reason that we can't call of_platform_bus_probe() or 
multiple times.  Timur's run into an issue in which all devices don't get 
registered properly if we call of_platform_bus_probe() times with different 
of_device_id struct's.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: issues calling of_platform_bus_probe() twice

2012-03-16 Thread Benjamin Herrenschmidt
On Fri, 2012-03-16 at 16:21 -0500, Kumar Gala wrote:
 Guys,
 
 Are you aware of any reason that we can't call of_platform_bus_probe()
 or multiple times.  Timur's run into an issue in which all devices
 don't get registered properly if we call of_platform_bus_probe() times
 with different of_device_id struct's.

Nothing comes to mind... Grant ?

Cheers,
Ben.


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev