Re: libfdt: Add function to explicitly expand aliases

2008-10-02 Thread Jon Loeliger
> Kumar has already added alias expansion to fdt_path_offset().
> However, in some circumstances it may be convenient for the user of
> libfdt to explicitly get the string expansion of an alias.  This patch
> adds a function to do this, fdt_get_alias(), and uses it to implement
> fdt_path_offset().
> 
> Signed-off-by: David Gibson <[EMAIL PROTECTED]>

Applied.

jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


libfdt: Add function to explicitly expand aliases

2008-08-19 Thread David Gibson
Kumar has already added alias expansion to fdt_path_offset().
However, in some circumstances it may be convenient for the user of
libfdt to explicitly get the string expansion of an alias.  This patch
adds a function to do this, fdt_get_alias(), and uses it to implement
fdt_path_offset().

Signed-off-by: David Gibson <[EMAIL PROTECTED]>

Index: dtc/libfdt/fdt_ro.c
===
--- dtc.orig/libfdt/fdt_ro.c2008-08-20 15:59:56.0 +1000
+++ dtc/libfdt/fdt_ro.c 2008-08-20 15:59:56.0 +1000
@@ -141,17 +141,12 @@ int fdt_path_offset(const void *fdt, con
 
/* see if we have an alias */
if (*path != '/') {
-   const char *q;
-   int aliasoffset = fdt_path_offset(fdt, "/aliases");
-
-   if (aliasoffset < 0)
-   return -FDT_ERR_BADPATH;
+   const char *q = strchr(path, '/');
 
-   q = strchr(path, '/');
if (!q)
q = end;
 
-   p = fdt_getprop_namelen(fdt, aliasoffset, path, q - p, NULL);
+   p = fdt_get_alias_namelen(fdt, p, q - p);
if (!p)
return -FDT_ERR_BADPATH;
offset = fdt_path_offset(fdt, p);
@@ -302,6 +297,23 @@ uint32_t fdt_get_phandle(const void *fdt
return fdt32_to_cpu(*php);
 }
 
+const char *fdt_get_alias_namelen(const void *fdt,
+ const char *name, int namelen)
+{
+   int aliasoffset;
+
+   aliasoffset = fdt_path_offset(fdt, "/aliases");
+   if (aliasoffset < 0)
+   return NULL;
+
+   return fdt_getprop_namelen(fdt, aliasoffset, name, namelen, NULL);
+}
+
+const char *fdt_get_alias(const void *fdt, const char *name)
+{
+   return fdt_get_alias_namelen(fdt, name, strlen(name));
+}
+
 int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen)
 {
int pdepth = 0, p = 0;
Index: dtc/libfdt/libfdt.h
===
--- dtc.orig/libfdt/libfdt.h2008-08-20 15:59:56.0 +1000
+++ dtc/libfdt/libfdt.h 2008-08-20 15:59:56.0 +1000
@@ -459,6 +459,32 @@ static inline void *fdt_getprop_w(void *
 uint32_t fdt_get_phandle(const void *fdt, int nodeoffset);
 
 /**
+ * fdt_get_namelen - get alias based on substring
+ * @fdt: pointer to the device tree blob
+ * @name: name of the alias th look up
+ * @namelen: number of characters of name to consider
+ *
+ * Identical to fdt_get_alias(), but only examine the first namelen
+ * characters of name for matching the alias name.
+ */
+const char *fdt_get_alias_namelen(const void *fdt,
+ const char *name, int namelen);
+
+/**
+ * fdt_get_alias - retreive the path referenced by a given alias
+ * @fdt: pointer to the device tree blob
+ * @name: name of the alias th look up
+ *
+ * fdt_get_alias() retrieves the value of a given alias.  That is, the
+ * value of the property named 'name' in the node /aliases.
+ *
+ * returns:
+ * a pointer to the expansion of the alias named 'name', of it exists
+ * NULL, if the given alias or the /aliases node does not exist
+ */
+const char *fdt_get_alias(const void *fdt, const char *name);
+
+/**
  * fdt_get_path - determine the full path of a node
  * @fdt: pointer to the device tree blob
  * @nodeoffset: offset of the node whose path to find
Index: dtc/tests/get_alias.c
===
--- /dev/null   1970-01-01 00:00:00.0 +
+++ dtc/tests/get_alias.c   2008-08-20 15:59:56.0 +1000
@@ -0,0 +1,58 @@
+/*
+ * libfdt - Flat Device Tree manipulation
+ * Testcase for fdt_get_alias()
+ * Copyright (C) 2006 David Gibson, IBM Corporation.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public License
+ * as published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include "tests.h"
+#include "testdata.h"
+
+void check_alias(void *fdt, const char *path, const char *alias)
+{
+   const char *aliaspath;
+
+   aliaspath = fdt_get_alias(fdt, alias);
+
+   if (path && !aliaspath)
+   FAIL("fdt_get_alias(%s) failed\n", alias);
+
+   if (strcmp(aliaspath, path) != 0)
+   FAIL("fd