linux-next: build failure after merge of the akpm-current tree
Hi Andrew, After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/lib/code-patching.c:61:16: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'is_conditional_branch' bool __kprobes is_conditional_branch(unsigned int instr) ^ Caused by commit 916c821aaf13 ("kprobes: move kprobe declarations to asm-generic/kprobes.h") interacting with commit 51c9c0843993 ("powerpc/kprobes: Implement Optprobes") from the powerpc tree. I have applied this merge fix patch for today: From: Stephen RothwellDate: Tue, 14 Feb 2017 16:56:11 +1100 Subject: [PATCH] powerpc/kprobes: fixup for kprobes declarations moving Signed-off-by: Stephen Rothwell --- arch/powerpc/lib/code-patching.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c index 0899315e1434..0d3002b7e2b4 100644 --- a/arch/powerpc/lib/code-patching.c +++ b/arch/powerpc/lib/code-patching.c @@ -14,6 +14,7 @@ #include #include #include +#include int patch_instruction(unsigned int *addr, unsigned int instr) -- 2.10.2 -- Cheers, Stephen Rothwell
Re: linux-next: build failure after merge of the akpm-current tree
Hi Thiago, On Thu, 24 Nov 2016 13:02:39 -0200 Thiago Jung Bauermannwrote: > > Am Donnerstag, 24. November 2016, 16:01:51 BRST schrieb Stephen Rothwell: > > Hi Andrew, > > > > After merging the akpm-current tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > powerpc-linux-ld: unrecognized option '--no-dynamic-linker' > > > > Caused by patch > > > > "powerpc: add purgatory for kexec_file_load implementation" > > > > Sorry about that. --no-dynamic-linker was added in binutils 2.26. > The patch below fixes the problem. OK, I will apply that patch instead of disabling CONFIG_KEXEC_FILE today. -- Cheers, Stephen Rothwell
Re: linux-next: build failure after merge of the akpm-current tree
Hello Stephen, Am Donnerstag, 24. November 2016, 16:01:51 BRST schrieb Stephen Rothwell: > Hi Andrew, > > After merging the akpm-current tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > powerpc-linux-ld: unrecognized option '--no-dynamic-linker' > > Caused by patch > > "powerpc: add purgatory for kexec_file_load implementation" > Sorry about that. --no-dynamic-linker was added in binutils 2.26. The patch below fixes the problem. -- Thiago Jung Bauermann IBM Linux Technology Center diff --git a/arch/powerpc/purgatory/Makefile b/arch/powerpc/purgatory/Makefile index 2dfb53ac9944..cf6e78b9af86 100644 --- a/arch/powerpc/purgatory/Makefile +++ b/arch/powerpc/purgatory/Makefile @@ -6,8 +6,10 @@ purgatory-y := purgatory.o string.o v2wrap.o purgatory-ppc64.o crtsavres.o \ targets += $(purgatory-y) PURGATORY_OBJS = $(addprefix $(obj)/,$(purgatory-y)) -LDFLAGS_purgatory.ro := -pie --no-dynamic-linker -e purgatory_start \ - --no-undefined -nostartfiles -nostdlib -nodefaultlibs +LDFLAGS_purgatory.ro := -pie -e purgatory_start --no-undefined -nostartfiles \ + -nostdlib -nodefaultlibs +LDFLAGS_purgatory.ro += $(call ld-option, --no-dynamic-linker) + targets += purgatory.ro KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_FTRACE), $(KBUILD_CFLAGS))
linux-next: build failure after merge of the akpm-current tree
Hi Andrew, After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: powerpc-linux-ld: unrecognized option '--no-dynamic-linker' Caused by patch "powerpc: add purgatory for kexec_file_load implementation" I have disabled KEXEC_FILE for now: From: Stephen RothwellDate: Thu, 24 Nov 2016 15:52:55 +1100 Subject: [PATCH] disable KEXEC_FILE on powerpc for now Signed-off-by: Stephen Rothwell --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 2d86643f280d..b72c1c7afcf0 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -475,6 +475,7 @@ config KEXEC_FILE depends on PPC64 depends on CRYPTO=y depends on CRYPTO_SHA256=y + depends on BROKEN help This is a new version of the kexec system call. This call is file based and takes in file descriptors as system call arguments -- 2.10.2 -- Cheers, Stephen Rothwell
Re: linux-next: build failure after merge of the akpm-current tree
Stephen Rothwellwrites: > Hi Andrew, > > After merging the akpm-current tree, today's linux-next build (powerpc > allyesconfig and pseries_le_defconfig) failed like this: > > In file included from include/linux/mm.h:394:0, > from mm/huge_memory.c:10: > include/linux/huge_mm.h:53:22: error: initializer element is not constant > #define HPAGE_PMD_NR (1< ^ > mm/huge_memory.c:104:62: note: in expansion of macro 'HPAGE_PMD_NR' > static unsigned int khugepaged_max_ptes_swap __read_mostly = HPAGE_PMD_NR/8; > ^ > > Caused by commit > > 6d34b9749be2 ("mm: make optimistic check for swapin readahead") > > interacting with commit > > dd1842a2a448 ("powerpc/mm: Make page table size a variable") > > from the powerpc tree. > > I applied this fix patch for today (hopefully this is still initialised > early enough): > > From: Stephen Rothwell > Date: Mon, 2 May 2016 18:25:42 +1000 > Subject: [PATCH] mm: make optimistic check for swapin readahead fix > > Signed-off-by: Stephen Rothwell Reviewed-by: Aneesh Kumar K.V > --- > mm/huge_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f0cd9dbc1157..6aabfa166b6d 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -101,7 +101,7 @@ static DECLARE_WAIT_QUEUE_HEAD(khugepaged_wait); > * fault. > */ > static unsigned int khugepaged_max_ptes_none __read_mostly; > -static unsigned int khugepaged_max_ptes_swap __read_mostly = HPAGE_PMD_NR/8; > +static unsigned int khugepaged_max_ptes_swap __read_mostly; > static unsigned long allocstall; > > static int khugepaged(void *none); > @@ -703,6 +703,7 @@ static int __init hugepage_init(void) > > khugepaged_pages_to_scan = HPAGE_PMD_NR * 8; > khugepaged_max_ptes_none = HPAGE_PMD_NR - 1; > + khugepaged_max_ptes_swap = HPAGE_PMD_NR / 8; > /* >* hugepages can't be allocated by the buddy allocator >*/ > -- > 2.7.0 > > > > > -- > Cheers, > Stephen Rothwell ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the akpm-current tree
Hi Andrew, After merging the akpm-current tree, today's linux-next build (powerpc allyesconfig and pseries_le_defconfig) failed like this: In file included from include/linux/mm.h:394:0, from mm/huge_memory.c:10: include/linux/huge_mm.h:53:22: error: initializer element is not constant #define HPAGE_PMD_NR (1<Date: Mon, 2 May 2016 18:25:42 +1000 Subject: [PATCH] mm: make optimistic check for swapin readahead fix Signed-off-by: Stephen Rothwell --- mm/huge_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f0cd9dbc1157..6aabfa166b6d 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -101,7 +101,7 @@ static DECLARE_WAIT_QUEUE_HEAD(khugepaged_wait); * fault. */ static unsigned int khugepaged_max_ptes_none __read_mostly; -static unsigned int khugepaged_max_ptes_swap __read_mostly = HPAGE_PMD_NR/8; +static unsigned int khugepaged_max_ptes_swap __read_mostly; static unsigned long allocstall; static int khugepaged(void *none); @@ -703,6 +703,7 @@ static int __init hugepage_init(void) khugepaged_pages_to_scan = HPAGE_PMD_NR * 8; khugepaged_max_ptes_none = HPAGE_PMD_NR - 1; + khugepaged_max_ptes_swap = HPAGE_PMD_NR / 8; /* * hugepages can't be allocated by the buddy allocator */ -- 2.7.0 -- Cheers, Stephen Rothwell ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the akpm-current tree
Hi Andrew, After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/kernel/setup_64.c: In function 'disable_hardlockup_detector': arch/powerpc/kernel/setup_64.c:796:2: error: implicit declaration of function 'watchdog_enable_hardlockup_detector' [-Werror=implicit-function-declaration] watchdog_enable_hardlockup_detector(false); ^ Caused by commit 069bb95b9e38 (watchdog: introduce the hardlockup_detector_disable() function) interacting with commit c54b2bf1b5e9 (powerpc: Add ppc64 hard lockup detector support) from the powerpc-mpe tree. I applied the following merge fix patch (hopefully that is all that is required): From: Stephen Rothwell s...@canb.auug.org.au Date: Mon, 13 Apr 2015 21:18:01 +1000 Subject: [PATCH] powerpc: merge fix for watchdog_enable_hardlockup_detector API change Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- arch/powerpc/kernel/setup_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 7551e5692597..c69671c03c3b 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c @@ -793,7 +793,7 @@ u64 hw_nmi_get_sample_period(int watchdog_thresh) */ static int __init disable_hardlockup_detector(void) { - watchdog_enable_hardlockup_detector(false); + hardlockup_detector_disable(); return 0; } -- 2.1.4 -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpNfI1O_QrHh.pgp Description: OpenPGP digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev