linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:958: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:959: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:983: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:984: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1003: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1013: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1014: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1015: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1016: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1017: Error: attempt to move .org backwards arch/powerpc/kernel/exceptions-64s.S:1018: Error: attempt to move .org backwards Caused by commit 1e9b4507ed98 ("powerpc/book3s: handle machine check in Linux host"). I have reverted these commits (possibly some of these reverts are unnecessary): b63a0ffe35de "powerpc/powernv: Machine check exception handling" 28446de2ce99 "powerpc/powernv: Remove machine check handling in OPAL" b5ff4211a829 "powerpc/book3s: Queue up and process delayed MCE events" 36df96f8acaf "powerpc/book3s: Decode and save machine check event" ae744f3432d3 "powerpc/book3s: Flush SLB/TLBs if we get SLB/TLB machine check errors on power8" e22a22740c1a "powerpc/book3s: Flush SLB/TLBs if we get SLB/TLB machine check errors on power7" 0440705049b0 "powerpc/book3s: Add flush_tlb operation in cpu_spec" 4c703416efc0 "powerpc/book3s: Introduce a early machine check hook in cpu_spec" 1c51089f777b "powerpc/book3s: Return from interrupt if coming from evil context" 1e9b4507ed98 "powerpc/book3s: handle machine check in Linux host" -- Cheers, Stephen Rothwell pgpc4ymwFbUDD.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > arch/powerpc/kernel/kgdb.c: In function 'kgdb_arch_exit': > arch/powerpc/kernel/kgdb.c:492:2: error: '__debugger_breakx_match' undeclared > (first use in this function) > > Caused by commit 9422de3e953d ("powerpc: Hardware breakpoints rewrite to > handle non DABR breakpoint registers"). I applied "powerpc: Fix typo in > breakpoint kgdb code" from Mikey for this. > > arch/powerpc/kernel/exceptions-64s.S: Assembler messages: > arch/powerpc/kernel/exceptions-64s.S:1204: Error: attempt to move .org > backwards > > Not sure what caused that - probably a combination of patches adding code > low down. I have just left this broken for today. FWIW I posted this earlier http://patchwork.ozlabs.org/patch/211184/ Mikey ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/kernel/kgdb.c: In function 'kgdb_arch_exit': arch/powerpc/kernel/kgdb.c:492:2: error: '__debugger_breakx_match' undeclared (first use in this function) Caused by commit 9422de3e953d ("powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint registers"). I applied "powerpc: Fix typo in breakpoint kgdb code" from Mikey for this. arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:1204: Error: attempt to move .org backwards Not sure what caused that - probably a combination of patches adding code low down. I have just left this broken for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpnvRx6z7fjt.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Thu, Sep 06, 2012 at 05:11:53PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc allyesconfig) > failed like this: > > In file included from drivers/atm/fore200e.c:70:0: > drivers/atm/fore200e.h:263:3: error: redefinition of typedef 'opcode_t' with > different type > arch/powerpc/include/asm/probes.h:25:13: note: previous declaration of > 'opcode_t' was here > > Caused by commit 7118e7e648e0 ("powerpc: Consolidate {k,u}probe > definitions") from the powerpc tree. > > I have reverted that commit (and the two following: > 41ab5266c362 "powerpc: Add trap_nr to thread_struct" > 8b7b80b9ebb4 "powerpc: Uprobes port to powerpc") > for today. Hi Stephen, I have just posted a patch [1] to fix the issue. Ananth [1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-September/100813.html ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/atm/fore200e.c:70:0: drivers/atm/fore200e.h:263:3: error: redefinition of typedef 'opcode_t' with different type arch/powerpc/include/asm/probes.h:25:13: note: previous declaration of 'opcode_t' was here Caused by commit 7118e7e648e0 ("powerpc: Consolidate {k,u}probe definitions") from the powerpc tree. I have reverted that commit (and the two following: 41ab5266c362"powerpc: Add trap_nr to thread_struct" 8b7b80b9ebb4"powerpc: Uprobes port to powerpc") for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp88dPx4Isth.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Thu, 2011-06-30 at 16:36 +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/tty/hvc/hvsi.c:701:12: error: conflicting types for 'hvsi_put_chars' > arch/powerpc/include/asm/hvsi.h:92:12: note: previous declaration of > 'hvsi_put_chars' was here > drivers/tty/hvc/hvsi.c:736:12: error: conflicting types for 'hvsi_open' > arch/powerpc/include/asm/hvsi.h:86:12: note: previous declaration of > 'hvsi_open' was here > drivers/tty/hvc/hvsi.c:802:13: error: conflicting types for 'hvsi_close' > arch/powerpc/include/asm/hvsi.h:87:13: note: previous declaration of > 'hvsi_close' was here > drivers/tty/hvc/hvsi.c:1083:19: error: conflicting types for 'hvsi_init' > arch/powerpc/include/asm/hvsi.h:81:13: note: previous declaration of > 'hvsi_init' was here > > Caused by commit 17bdc6c0e979 ("powerpc/pseries: Move hvsi support into a > library"). > > I have reverted that commit for today. Ooops, that seems to be entirely my fault, not sure what happened, I might have merged the wrong patch version (I had some problem locally with screwing up the git repo where those patches were originally). I'll push a fix tomorrow. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/tty/hvc/hvsi.c:701:12: error: conflicting types for 'hvsi_put_chars' arch/powerpc/include/asm/hvsi.h:92:12: note: previous declaration of 'hvsi_put_chars' was here drivers/tty/hvc/hvsi.c:736:12: error: conflicting types for 'hvsi_open' arch/powerpc/include/asm/hvsi.h:86:12: note: previous declaration of 'hvsi_open' was here drivers/tty/hvc/hvsi.c:802:13: error: conflicting types for 'hvsi_close' arch/powerpc/include/asm/hvsi.h:87:13: note: previous declaration of 'hvsi_close' was here drivers/tty/hvc/hvsi.c:1083:19: error: conflicting types for 'hvsi_init' arch/powerpc/include/asm/hvsi.h:81:13: note: previous declaration of 'hvsi_init' was here Caused by commit 17bdc6c0e979 ("powerpc/pseries: Move hvsi support into a library"). I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpHeeqWh4eZ8.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/mm/mmu_context_hash64.c: In function 'init_new_context': arch/powerpc/mm/mmu_context_hash64.c:282: error: 'NO_CONTEXT' undeclared (first use in this function) Presumably caused by commit 851d2e2fe8db ("powerpc: Add Initiate Coprocessor Store Word (icswx) support") interacting with commit 5e8e7b404ac9 ("powerpc/mm: Standardise on MMU_NO_CONTEXT"). I added the below patch for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au From: Stephen Rothwell Date: Thu, 5 May 2011 13:32:02 +1000 Subject: [PATCH] powerpc: fix up mismerge in mmu_context_hash64.c NO_CONTEXT was changed to MMU_NO_CONTEXT. Signed-off-by: Stephen Rothwell --- arch/powerpc/mm/mmu_context_hash64.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/mm/mmu_context_hash64.c b/arch/powerpc/mm/mmu_context_hash64.c index c517815..3bafc3d 100644 --- a/arch/powerpc/mm/mmu_context_hash64.c +++ b/arch/powerpc/mm/mmu_context_hash64.c @@ -279,7 +279,7 @@ int init_new_context(struct task_struct *tsk, struct mm_struct *mm) if (!mm->context.cop_lockp) { __destroy_context(index); subpage_prot_free(mm); - mm->context.id = NO_CONTEXT; + mm->context.id = MMU_NO_CONTEXT; return -ENOMEM; } spin_lock_init(mm->context.cop_lockp); -- 1.7.4.4 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Tue, Mar 15, 2011 at 07:37:54AM +1100, Benjamin Herrenschmidt wrote: > > Hi all, > > > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler': > > drivers/gpio/langwell_gpio.c:210: error: 'struct irq_desc' has no member > > named 'chip' > > drivers/gpio/langwell_gpio.c:211: error: 'struct irq_desc' has no member > > named 'chip' > > > > Caused by commit 17b9f9e2653a ("powerpc: Enable > > GENERIC_HARDIRQS_NO_DEPRECATED") enabling > > CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED for powerpc without previously > > fixing up the above driver. > > > > I have reverted that commit for today. > > Except that the above driver has nothing to do with powerpc, it's some > Intel Moorestown stuff... I sent this this morning: http://marc.info/?l=linux-kernel&m=130009963219374&w=2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Mon, 14 Mar 2011, David Miller wrote: > From: Benjamin Herrenschmidt > Date: Tue, 15 Mar 2011 07:37:54 +1100 > > > On Mon, 2011-03-14 at 20:38 +1100, Stephen Rothwell wrote: > >> Hi all, > >> > >> After merging the final tree, today's linux-next build (powerpc > >> allyesconfig) failed like this: > >> > >> drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler': > >> drivers/gpio/langwell_gpio.c:210: error: 'struct irq_desc' has no member > >> named 'chip' > >> drivers/gpio/langwell_gpio.c:211: error: 'struct irq_desc' has no member > >> named 'chip' > >> > >> Caused by commit 17b9f9e2653a ("powerpc: Enable > >> GENERIC_HARDIRQS_NO_DEPRECATED") enabling > >> CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED for powerpc without previously > >> fixing up the above driver. > >> > >> I have reverted that commit for today. > > > > Except that the above driver has nothing to do with powerpc, it's some > > Intel Moorestown stuff... > > > > It should be fixed regardless I suppose, CC'ing Thomas. > > I've had to make fixes to this driver in sparc64 allmodconfig builds > too :-) Sigh. Yes, this wants to depend on x86 in the first place. But this is the second instance of blindly and mindlessly changing eoi to irq_eoi w/o looking at the reason for this change. Those patches should have been rejected based on their changelog in the first place: Latest kernel has many changes in IRQ subsystem and its interfaces, like adding "irq_eoi" for struct irq_chip, this patch is a follow up change for that. When noone beats me to fix that mess, I'll do it tomorrow morning. Thanks, tglx ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
From: Benjamin Herrenschmidt Date: Tue, 15 Mar 2011 07:37:54 +1100 > On Mon, 2011-03-14 at 20:38 +1100, Stephen Rothwell wrote: >> Hi all, >> >> After merging the final tree, today's linux-next build (powerpc >> allyesconfig) failed like this: >> >> drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler': >> drivers/gpio/langwell_gpio.c:210: error: 'struct irq_desc' has no member >> named 'chip' >> drivers/gpio/langwell_gpio.c:211: error: 'struct irq_desc' has no member >> named 'chip' >> >> Caused by commit 17b9f9e2653a ("powerpc: Enable >> GENERIC_HARDIRQS_NO_DEPRECATED") enabling >> CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED for powerpc without previously >> fixing up the above driver. >> >> I have reverted that commit for today. > > Except that the above driver has nothing to do with powerpc, it's some > Intel Moorestown stuff... > > It should be fixed regardless I suppose, CC'ing Thomas. I've had to make fixes to this driver in sparc64 allmodconfig builds too :-) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Mon, 2011-03-14 at 20:38 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler': > drivers/gpio/langwell_gpio.c:210: error: 'struct irq_desc' has no member > named 'chip' > drivers/gpio/langwell_gpio.c:211: error: 'struct irq_desc' has no member > named 'chip' > > Caused by commit 17b9f9e2653a ("powerpc: Enable > GENERIC_HARDIRQS_NO_DEPRECATED") enabling > CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED for powerpc without previously > fixing up the above driver. > > I have reverted that commit for today. Except that the above driver has nothing to do with powerpc, it's some Intel Moorestown stuff... It should be fixed regardless I suppose, CC'ing Thomas. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler': drivers/gpio/langwell_gpio.c:210: error: 'struct irq_desc' has no member named 'chip' drivers/gpio/langwell_gpio.c:211: error: 'struct irq_desc' has no member named 'chip' Caused by commit 17b9f9e2653a ("powerpc: Enable GENERIC_HARDIRQS_NO_DEPRECATED") enabling CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED for powerpc without previously fixing up the above driver. I have reverted that commit for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpqUko7EeJr9.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Fri, Dec 03, 2010 at 04:59:58PM +1100, Benjamin Herrenschmidt wrote: >On Fri, 2010-12-03 at 16:32 +1100, Stephen Rothwell wrote: >> >> After merging the tree, today's linux-next build (powerpc allmodconfig) >> failed like this: >> >> arch/powerpc/lib/hweight_64.S: Assembler messages: >> arch/powerpc/lib/hweight_64.S:52: Error: Unrecognized opcode: `popcntw' >> arch/powerpc/lib/hweight_64.S:77: Error: Unrecognized opcode: `popcntw' >> arch/powerpc/lib/hweight_64.S:106: Error: Unrecognized opcode: `popcntd' >> >> This is with: >> >> powerpc64-linux-gcc (GCC) 4.4.0 >> GNU assembler (GNU Binutils) 2.19.1 >> >> Caused by commit 64ff31287693c1f325cb9cb049569c1611438ef1 ("powerpc: Add >> support for popcnt instructions"). > > >This toolchain is a bit ancient I suppose... Anton, do you reckon we SLES 11 SP1 still uses gcc 4.3. 4.4.0 is not ancient by any means. Neither is binutils 2.19.1. >should use .long based macros for these for the time being or just >require a newer binutils ? .long macros sound like the proper solution. josh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Fri, 03 Dec 2010 16:59:58 +1100 Benjamin Herrenschmidt wrote: > > This toolchain is a bit ancient I suppose... Anton, do you reckon we > should use .long based macros for these for the time being or just > require a newer binutils ? The currently documented minimum binutils is 2.12 ... -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpzngCYknfXy.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: build failure after merge of the final tree (powerpc tree related)
On Fri, 2010-12-03 at 16:32 +1100, Stephen Rothwell wrote: > > After merging the tree, today's linux-next build (powerpc allmodconfig) > failed like this: > > arch/powerpc/lib/hweight_64.S: Assembler messages: > arch/powerpc/lib/hweight_64.S:52: Error: Unrecognized opcode: `popcntw' > arch/powerpc/lib/hweight_64.S:77: Error: Unrecognized opcode: `popcntw' > arch/powerpc/lib/hweight_64.S:106: Error: Unrecognized opcode: `popcntd' > > This is with: > > powerpc64-linux-gcc (GCC) 4.4.0 > GNU assembler (GNU Binutils) 2.19.1 > > Caused by commit 64ff31287693c1f325cb9cb049569c1611438ef1 ("powerpc: Add > support for popcnt instructions"). This toolchain is a bit ancient I suppose... Anton, do you reckon we should use .long based macros for these for the time being or just require a newer binutils ? Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: build failure after merge of the final tree (powerpc tree related)
Hi all, After merging the tree, today's linux-next build (powerpc allmodconfig) failed like this: arch/powerpc/lib/hweight_64.S: Assembler messages: arch/powerpc/lib/hweight_64.S:52: Error: Unrecognized opcode: `popcntw' arch/powerpc/lib/hweight_64.S:77: Error: Unrecognized opcode: `popcntw' arch/powerpc/lib/hweight_64.S:106: Error: Unrecognized opcode: `popcntd' This is with: powerpc64-linux-gcc (GCC) 4.4.0 GNU assembler (GNU Binutils) 2.19.1 Caused by commit 64ff31287693c1f325cb9cb049569c1611438ef1 ("powerpc: Add support for popcnt instructions"). -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgp8ykb4056qq.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev