Re: linux-next: powerpc tree build warning
On Mon, Aug 24, 2009 at 10:22:56AM +1000, Stephen Rothwell wrote: Hi all, Today's linux-next build (powerpc ppc64_defconfig) produced this warning: kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick': kernel/time/tick-sched.c:261: warning: format '%02x' expects type 'unsigned int', but argument 2 has type 'long unsigned int' Introduced by commit 6826a57d1abc8ac9f59b24f1a008554c6560a995 (powerpc: Switch to asm-generic/hardirq.h) which changed irq_cpustat_t::__softirq_pending from unsigned int to unsigned long on powerpc. Hah, that's an interesting one. In currently mainline the following architectures have it as unsigned long: alpha, parisc and blackfin/microblaze via asm-generic and all others have it as unsigned int. For blackfin and microblaze it obviously doesn't matter, so the question is why alpha and parisc have it as usinged long. We defintively should standardize on one, and unless alpha and parisc have good reasons for needing a long value that would be unsigned int. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: powerpc tree build warning
Hi Ben, Today's linux-next build (powerpc ppc64_defconfig) produced this warning: arch/powerpc/platforms/Kconfig.cputype:60:warning: defaults for choice values not supported We appear to have CONFIG_PPC_BOOK3S int two places which is confusing Kconfig. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpLPVuhjnP1r.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: linux-next: powerpc tree build warning
On Thu, 2009-06-11 at 11:39 +1000, Stephen Rothwell wrote: Hi Ben, Today's linux-next build (powerpc ppc64_defconfig) produced this warning: arch/powerpc/platforms/Kconfig.cputype:60:warning: defaults for choice values not supported We appear to have CONFIG_PPC_BOOK3S int two places which is confusing Kconfig. Yes, I see that. One place depends on PPC32 and the other one PPC64, but it still seems to be somewhat confused. In any case, it seems to still do the right thing, so not a big hurry here, but I'll do a patch that does it differently. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
linux-next: powerpc tree build warning
Hi Ben, Today's linux-next build (powerpc ppc64_defconfig) produced this warning: arch/powerpc/platforms/cell/spufs/inode.c: In function 'spufs_create': arch/powerpc/platforms/cell/spufs/inode.c:647: warning: label 'out_dput' defined but not used Introduced by commit 45db9240890d9343c934db1fe82d6e68ac2d28da (powerpc/spufs: Remove double check for non-negative dentry). -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpqsKvlqA0R7.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
linux-next: powerpc tree build warning
Hi Ben, Today's linux-next build (powerpc ppc64_defconfig) produced this warning: arch/powerpc/xmon/xmon.c: In function 'dump_log_buf': arch/powerpc/xmon/xmon.c:2133: warning: unused variable 'i' Introduced by commit f312deb4cd0c88196edf6dab192b7d42514398d6 (powerpc/xmon: Add dl command to dump contents of __log_buf). [As an aside, that commit contains this: Signed-off-by: Michael Ellerman michael at ellerman.id.au but we use real email addresses normally] -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpfbCyiSOyRc.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
