Re: powerpc/pseries: use memdup_user_nul

[Michael Ellerman]

On Sat, 2017-04-29 at 01:45:15 UTC, Geliang Tang wrote:
> Use memdup_user_nul() helper instead of open-coding to simplify the code.
> 
> Signed-off-by: Geliang Tang 

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/3783225130f01ea86fc0ee477a0e72

cheers

[PATCH] powerpc/pseries: use memdup_user_nul

[Geliang Tang]

Use memdup_user_nul() helper instead of open-coding to simplify the code.

Signed-off-by: Geliang Tang 
---
 arch/powerpc/platforms/pseries/reconfig.c | 13 +++--
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/reconfig.c 
b/arch/powerpc/platforms/pseries/reconfig.c
index e5bf1e8..431f513 100644
--- a/arch/powerpc/platforms/pseries/reconfig.c
+++ b/arch/powerpc/platforms/pseries/reconfig.c
@@ -367,16 +367,9 @@ static ssize_t ofdt_write(struct file *file, const char 
__user *buf, size_t coun
char *kbuf;
char *tmp;
 
-   if (!(kbuf = kmalloc(count + 1, GFP_KERNEL))) {
-   rv = -ENOMEM;
-   goto out;
-   }
-   if (copy_from_user(kbuf, buf, count)) {
-   rv = -EFAULT;
-   goto out;
-   }
-
-   kbuf[count] = '\0';
+   kbuf = memdup_user_nul(buf, count);
+   if (IS_ERR(kbuf))
+   return PTR_ERR(kbuf);
 
tmp = strchr(kbuf, ' ');
if (!tmp) {
-- 
2.9.3