Re: [PATCH] TurboStation support (Properly)
On May 9, 2007, at 9:18 AM, Kumar Gala wrote: > > On May 8, 2007, at 4:56 PM, Øyvind Repvik wrote: > >> On Sunday 06 May 2007 14:46:05 Øyvind Repvik wrote: >>> Hi, >>> >>> This patch adds support for the QNAP TurboStation TS-101 and >>> TS-201 devices. >> >> Of course, it probably helps if my mail client doesn't break the >> patch completely. > > Comments below. > > Out of interesting, what's the difference between the TS-101 and > TS-201? Also, can you provide a defconfig. - k ___ Linuxppc-embedded mailing list Linuxppc-embedded@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-embedded
Re: [PATCH] TurboStation support (Properly)
On May 8, 2007, at 4:56 PM, Øyvind Repvik wrote:
> On Sunday 06 May 2007 14:46:05 Øyvind Repvik wrote:
>> Hi,
>>
>> This patch adds support for the QNAP TurboStation TS-101 and
>> TS-201 devices.
>
> Of course, it probably helps if my mail client doesn't break the
> patch completely.
Comments below.
Out of interesting, what's the difference between the TS-101 and TS-201?
>
>
> Signed-off-by: Øyvind Repvik <[EMAIL PROTECTED]>
> Signed-off-by: Alessandro Zummo <[EMAIL PROTECTED]>
>
> --- linux-2.6.21.1/arch/powerpc/boot/dts/qnap-ts101.dts 1970-01-01
> 01:00:00.0 +0100
> +++ linux-2.6.21.1.ts/arch/powerpc/boot/dts/qnap-ts101.dts
> 2007-05-03 22:44:59.0 +0200
> @@ -0,0 +1,166 @@
> +/*
> + * Device Tree Souce for QNAP Turbostation 101/201
> + *
> + * Choose CONFIG_TURBOSTATION to build a kernel for turbostation
> + *
> + *
> + * Based on kuroboxHD.dts by G. Liakhovetski
> + *
> + * 2007 (c) Oyvind Repvik <[EMAIL PROTECTED]>
> + *
> + * This file is licensed under
> + * the terms of the GNU General Public License version 2. This
> program
> + * is licensed "as is" without any warranty of any kind, whether
> express
> + * or implied.
> + *
> + * build with: "dtc -f -I dts -O dtb -o qnap-ts101.dtb -V 16 qnap-
> ts101.dts"
> + *
> + *
> + */
> +
> +/ {
> + linux,phandle = <1000>;
> + model = "TurboStation TSx01";
> + compatible = "turbostation";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + cpus {
> + linux,phandle = <2000>;
Can you removal all linux,phandle's and use the new reference syntax.
> + #cpus = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + PowerPC,603e { /* Really 8241 */
> + linux,phandle = <2100>;
> + device_type = "cpu";
> + reg = <0>;
> + clock-frequency = ;/* 266 MHz */
> + timebase-frequency = <1fca055>; /* 33.333 MHz */
> + bus-frequency = <0>;
> + /* Following required by dtc but not used */
> + i-cache-line-size = <0>;
> + d-cache-line-size = <0>;
No reason not to set the line-size properly to <20>
> + i-cache-size = <4000>;
> + d-cache-size = <4000>;
> + };
> + };
> +
> + /* 64MB @ 0x0 */
> + memory {
> + linux,phandle = <3000>;
> + device_type = "memory";
> + reg = < 0400>;
> + };
> +
> + [EMAIL PROTECTED] {
> + linux,phandle = <3100>;
> + device_type = "rom";
> + compatible = "direct-mapped";
> + probe-type = "CFI";
> + reg = ;
> + bank-width = <1>;
> + partitions = <
> + 0020
> + 0020 00d0
> + 00f0 00040001
> + 00f4 0002
> + 00f6 0004
> + 00fa 0002
> + 00fc 0004
> + >;
> + partition-names = "kernel\0rootfs\0uboot1\0uboot1-env\0uboot2
> \0uboot2-env\0SysConf";
> + };
> +
> +
> + soc10x { /* AFAICT need to make soc for 8245's uarts to be
> defined */
> + linux,phandle = <4000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + #interrupt-cells = <2>;
> + device_type = "soc";
> + compatible = "mpc10x";
> + store-gathering = <0>; /* 0 == off, !0 == on */
> + reg = <8000 0010>;
> + ranges = <8000 8000 7000/* pci mem space */
> + fc00 fc00 0010/* EUMB */
> + fe00 fe00 00c0/* pci i/o space */
> + fec0 fec0 0030/* pci cfg regs */
> + fef0 fef0 0010>; /* pci iack */
> +
> + [EMAIL PROTECTED] {
> + linux,phandle = <4300>;
> + device_type = "i2c";
> + compatible = "fsl-i2c";
> + reg = ;
> + interrupts = <5 2>;
> + interrupt-parent = <4400>;
> + };
> +
> + [EMAIL PROTECTED] {
> + linux,phandle = <4511>;
> + device_type = "serial";
> + compatible = "ns16550";
> + reg = ;
> + clock-frequency = <7ed6b40>;/* 133 MHz */
> + current-speed = <1c200>;/* 115200 */
> + interrupts = <9 2>;
> + interrupt-parent = <4400>;
> + };
> +
> + [EMAIL PROTECTED] {
> +
Re: [PATCH] TurboStation support (Properly)
On Sunday 06 May 2007 14:46:05 Øyvind Repvik wrote:
> Hi,
>
> This patch adds support for the QNAP TurboStation TS-101 and TS-201
> devices.
Of course, it probably helps if my mail client doesn't break the patch
completely.
Signed-off-by: Øyvind Repvik <[EMAIL PROTECTED]>
Signed-off-by: Alessandro Zummo <[EMAIL PROTECTED]>
--- linux-2.6.21.1/arch/powerpc/boot/dts/qnap-ts101.dts 1970-01-01
01:00:00.0 +0100
+++ linux-2.6.21.1.ts/arch/powerpc/boot/dts/qnap-ts101.dts 2007-05-03
22:44:59.0 +0200
@@ -0,0 +1,166 @@
+/*
+ * Device Tree Souce for QNAP Turbostation 101/201
+ *
+ * Choose CONFIG_TURBOSTATION to build a kernel for turbostation
+ *
+ *
+ * Based on kuroboxHD.dts by G. Liakhovetski
+ *
+ * 2007 (c) Oyvind Repvik <[EMAIL PROTECTED]>
+ *
+ * This file is licensed under
+ * the terms of the GNU General Public License version 2. This program
+ * is licensed "as is" without any warranty of any kind, whether express
+ * or implied.
+ *
+ * build with: "dtc -f -I dts -O dtb -o qnap-ts101.dtb -V 16 qnap-ts101.dts"
+ *
+ *
+ */
+
+/ {
+ linux,phandle = <1000>;
+ model = "TurboStation TSx01";
+ compatible = "turbostation";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ cpus {
+ linux,phandle = <2000>;
+ #cpus = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ PowerPC,603e { /* Really 8241 */
+ linux,phandle = <2100>;
+ device_type = "cpu";
+ reg = <0>;
+ clock-frequency = ;/* 266 MHz */
+ timebase-frequency = <1fca055>; /* 33.333 MHz */
+ bus-frequency = <0>;
+ /* Following required by dtc but not used */
+ i-cache-line-size = <0>;
+ d-cache-line-size = <0>;
+ i-cache-size = <4000>;
+ d-cache-size = <4000>;
+ };
+ };
+
+ /* 64MB @ 0x0 */
+ memory {
+ linux,phandle = <3000>;
+ device_type = "memory";
+ reg = < 0400>;
+ };
+
+ [EMAIL PROTECTED] {
+ linux,phandle = <3100>;
+ device_type = "rom";
+ compatible = "direct-mapped";
+ probe-type = "CFI";
+ reg = ;
+ bank-width = <1>;
+ partitions = <
+ 0020
+ 0020 00d0
+ 00f0 00040001
+ 00f4 0002
+ 00f6 0004
+ 00fa 0002
+ 00fc 0004
+ >;
+ partition-names =
"kernel\0rootfs\0uboot1\0uboot1-env\0uboot2\0uboot2-env\0SysConf";
+ };
+
+
+ soc10x { /* AFAICT need to make soc for 8245's uarts to be defined */
+ linux,phandle = <4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ #interrupt-cells = <2>;
+ device_type = "soc";
+ compatible = "mpc10x";
+ store-gathering = <0>; /* 0 == off, !0 == on */
+ reg = <8000 0010>;
+ ranges = <8000 8000 7000/* pci mem space */
+ fc00 fc00 0010/* EUMB */
+ fe00 fe00 00c0/* pci i/o space */
+ fec0 fec0 0030/* pci cfg regs */
+ fef0 fef0 0010>; /* pci iack */
+
+ [EMAIL PROTECTED] {
+ linux,phandle = <4300>;
+ device_type = "i2c";
+ compatible = "fsl-i2c";
+ reg = ;
+ interrupts = <5 2>;
+ interrupt-parent = <4400>;
+ };
+
+ [EMAIL PROTECTED] {
+ linux,phandle = <4511>;
+ device_type = "serial";
+ compatible = "ns16550";
+ reg = ;
+ clock-frequency = <7ed6b40>;/* 133 MHz */
+ current-speed = <1c200>;/* 115200 */
+ interrupts = <9 2>;
+ interrupt-parent = <4400>;
+ };
+
+ [EMAIL PROTECTED] {
+ linux,phandle = <4512>;
+ device_type = "serial";
+ compatible = "ns16550";
+ reg = ;
+ clock-frequency = <7ed6b40>;
+ current-speed = <4b00>; /* 19200 */
+ interrupts = ;
+ interrupt-parent = <4400>;
