early return set_multicast

[Jaap-Jan Boor]

On Wed, 3 Mar 2004, Ricardo Scop wrote:

> Hi,
>
> On Wednesday 03 March 2004 13:09, Jaap-Jan Boor wrote:
> > Hi,
> >
> > does somebody know why there is an early return;
> > statement in the set_multicast_list() function
> > of 8260_io/fcc_enet.c (or cpm2_io/fcc_enet.c)?
> >
>
> [snip]
>
> Well, probably the code after the early return is broken ;).

that's what I was afraid for yes

> Which kernel version is that?

all I checked (denx latest 2.4.24-pre2, bk linuxppc 2.4.26-pre1
and kernel.org 2.4.22)

> There used to be at least one bug
> in the for statement (lack
> of a dmi=dmi->next statement inside it, AFAIR).


thanks again.

Jaap-Jan

>
> >
> > thanks,
> >
> > Jaap-Jan
>
> Your welcome.
>
>

--
J.G.J. Boor   Anton Philipsweg 1
Software Engineer 1223 KZ Hilversum
AimSys bv tel. +31 35 689 1941
Postbus 2194, 1200 CD Hilversum   mailto:jjboor at aimsys.nl


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

early return set_multicast

[Jaap-Jan Boor]

Hi,

does somebody know why there is an early return;
statement in the set_multicast_list() function
of 8260_io/fcc_enet.c (or cpm2_io/fcc_enet.c)?


static void
set_multicast_list(struct net_device *dev)
{
struct  fcc_enet_private *cep;
struct  dev_mc_list *dmi;
u_char  *mcptr, *tdptr;
volatile fcc_enet_t *ep;
int i, j;

cep = (struct fcc_enet_private *)dev->priv;

return;
/* Get pointer to FCC area in parameter RAM.
*/
ep = (fcc_enet_t *)dev->base_addr;

if (dev->flags&IFF_PROMISC) {
...
--

thanks,

Jaap-Jan

--
J.G.J. Boor   Anton Philipsweg 1
Software Engineer 1223 KZ Hilversum
AimSys bv tel. +31 35 689 1941
Postbus 2194, 1200 CD Hilversum   mailto:jjboor at aimsys.nl


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

early return set_multicast

[Ricardo Scop]

Hi,

On Wednesday 03 March 2004 13:09, Jaap-Jan Boor wrote:
> Hi,
>
> does somebody know why there is an early return;
> statement in the set_multicast_list() function
> of 8260_io/fcc_enet.c (or cpm2_io/fcc_enet.c)?
>

[snip]

Well, probably the code after the early return is broken ;). Which kernel
version is that? There used to be at least one bug in the for statement (lack
of a dmi=dmi->next statement inside it, AFAIR).

>
> thanks,
>
> Jaap-Jan

Your welcome.

--
Ricardo Scop.

  _
 /  _  \
 \_/(@ @)\_/
   /  V  \   R SCOP Consult.
  /( )\  Linux-based communications
---^^---^^--
rscop at matrix.com.br
+55 51 999-36-777
Porto Alegre, RS - BRazil


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/