Re: [Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV
On Mon, Mar 22, 2021 at 04:31:43PM +0100, Erez Geva wrote: > According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV > is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. > > To retain backward compatibility and as bit 1 in SLAVE_ONLY > is not used anyway. Read and set both bits with same value. This seems really not very important to keep compatibility with older buggy versions. Let's just fix the code to set the correct bit. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH 1/1] Ensure TLV_PORT_STATS_NP statistics uses little endian.
On Tue, Mar 23, 2021 at 11:37:39PM +0100, Erez Geva wrote: > As machine byte order may vary. > Ensure TLV_PORT_STATS_NP statistics use defined order. > > As most of us use little endian hardware and > to retain backward compatible with most of us, > we decide to use little endian for the statistics. > All other TLVs messages remain in network order. > > Signed-off-by: Erez Geva Applied. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] Unable to have UNCALIBRAT to SLAVE transition
On Wed, Mar 24, 2021 at 02:10:59PM +0100, Luigi 'Comio' Mantellini wrote: > Yes, it works for me. I am going to apply a fix. May I add this tag into the git commit to give you credit? Reported-by: Luigi 'Comio' Mantellini ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
