Re: [Linuxptp-devel] [PATCH 2/2] hwtstamp_ctl: use SIOCGHWTSTAMP ioctl before destructively setting policy
On Mon, Jun 02, 2014 at 08:59:27PM +, Keller, Jacob E wrote: Too long of a line? I usually try to follow the Linux practice which allows long lines if they only contain print statement, so that it's easier to grep the source for where the error came from.. Linux has way more lines of code to grep through than we do. I can change it though. I don't think the message itself is too long though. Yes, the text is fine. I don't mind having string constants divided into two chunks. I can break these onto their own lines, I suppose. Yes, please. Thanks, Richard -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH 2/2] hwtstamp_ctl: use SIOCGHWTSTAMP ioctl before destructively setting policy
On Tue, 2014-06-03 at 09:26 +0200, Richard Cochran wrote: On Mon, Jun 02, 2014 at 08:59:27PM +, Keller, Jacob E wrote: Too long of a line? I usually try to follow the Linux practice which allows long lines if they only contain print statement, so that it's easier to grep the source for where the error came from.. Linux has way more lines of code to grep through than we do. I can change it though. I don't think the message itself is too long though. Yes, the text is fine. I don't mind having string constants divided into two chunks. I can break these onto their own lines, I suppose. Yes, please. Thanks, Richard Alright, I'll go ahead and do that. Thanks, Jake -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
