[linuxtools-dev] git commit messages
Hi, The git commit message section of our git guide has more content now: http://wiki.eclipse.org/Linux_Tools_Project/Git#Commit_messages Please follow the guidelines as best as you can. They're from here: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
[linuxtools-dev] Getting Rid of Changelogs
I have been thinking about this for a while, but was prompted by Andrew's email [1] to send a message to the list. Changelogs are pain to deal with, they don't automerge, and the authorship information is redundant. On the other hand I find them useful in two ways: they force me to go over my patch one more time, and they provide a structure for creating a good commit message (I copy and paste my Changelog entry in the commit message). So my suggestion is we get rid of Changelogs, follow the format outlined on the wiki [2] and referenced by Andrew's message [1], and perhaps add a requirement to have a bullet for each modified file. WDYT ? Sami [1] http://wiki.eclipse.org/Linux_Tools_Project/Git#Commit_messages [2] http://dev.eclipse.org/mhonarc/lists/linuxtools-dev/msg01203.html ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
[linuxtools-dev] Build failed in Hudson: linuxtools-master #483
See https://hudson.eclipse.org/hudson/job/linuxtools-master/483/changes Changes: [Anithra P Janakiraman] Change feature version to 1.2.0 -- [...truncated 8677 lines...] [INFO] Linux Tools Newlib Libhover Plug-in ... SUCCESS [0.793s] [INFO] Linux Tools Libhover Newlib Feature ... SUCCESS [0.967s] [INFO] Linux Tools Devhelp Libhover Plug-in .. SUCCESS [10.126s] [INFO] Linux Tools Devhelp Libhover Feature .. SUCCESS [0.945s] [INFO] Eclipse Linux Tools LTTng Parent .. SUCCESS [0.051s] [INFO] Linux Tools TMF (LTTng) Plug-in ... SUCCESS [15.452s] [INFO] Linux Tools LTTng JNI Plug-in . SUCCESS [11.299s] [INFO] LTTng - Linux Tracing Toolkit (Incubation) SUCCESS [19.820s] [INFO] Linux Tools TMF UI (LTTng) Plug-in SUCCESS [43.012s] [INFO] Linux Tools LTTng UI Plug-in .. SUCCESS [27.446s] [INFO] Linux Tools LTTng Help Plug-in SUCCESS [1.074s] [INFO] Linux Tools TMF (LTTng) Feature ... SUCCESS [1.012s] [INFO] Linux Tracing Toolkit Integration (LTTng) (Incubation) SUCCESS [1.017s] [INFO] Linux Tools LTTng Tests Plug-in ... SUCCESS [15.018s] [INFO] Linux Tools LTTng UI Tests Plug-in SUCCESS [9.136s] [INFO] Linux Tools LTTng Tests Feature ... SUCCESS [1.019s] [INFO] Linux Tools TMF Tests (LTTng) Plug-in . SUCCESS [52.920s] [INFO] Linux Tools TMF UI Tests (LTTng) Plug-in .. SUCCESS [1:57.751s] [INFO] Linux Tools TMF Tests (LTTng) Feature . SUCCESS [1.007s] [INFO] Eclipse Linux Tools Man Parent SUCCESS [0.062s] [INFO] Linux Tools Man Plug-in ... SUCCESS [8.875s] [INFO] Linux Tools Man Feature (Incubation) .. SUCCESS [0.999s] [INFO] Eclipse Linux Tools OProfile Parent ... SUCCESS [0.062s] [INFO] Linux Tools OProfile Core Plug-in . SUCCESS [1.277s] [INFO] Linux Tools OProfile Tests Plug-in SUCCESS [6.723s] [INFO] Linux Tools OProfile Core Tests Plug-in ... SUCCESS [15.731s] [INFO] Linux Tools OProfile Documentation Plug-in SUCCESS [0.826s] [INFO] Linux Tools Profiling UI Plug-in .. SUCCESS [8.270s] [INFO] Linux Tools OProfile UI Plug-in ... SUCCESS [10.652s] [INFO] Linux Tools Profiling Launch Plug-in .. SUCCESS [9.190s] [INFO] Linux Tools OProfile Launch Plug-in ... SUCCESS [12.063s] [INFO] Linux Tools OProfile Integration Feature .. SUCCESS [1.006s] [INFO] Linux Tools Profiling Tests Plug-in ... SUCCESS [8.310s] [INFO] Linux Tools OProfile Launch Tests Plug-in . SUCCESS [15.976s] [INFO] Linux Tools OProfile UI Tests Plug-in . SUCCESS [7.233s] [INFO] Linux Tools OProfile Tests Feature SUCCESS [0.950s] [INFO] Linux Tools Profiling Framework Feature ... SUCCESS [0.948s] [INFO] Linux Tools Profiling Framework Testing Feature ... SUCCESS [0.933s] [INFO] Linux Tools Profiling Capability Plug-in .. SUCCESS [0.699s] [INFO] Eclipse Linux Tools RPM Parent SUCCESS [0.065s] [INFO] Linux Tools RPM Core Plug-in .. SUCCESS [9.935s] [INFO] Linux Tools RPM Specfile Editor Tests Plug-in . SUCCESS [12.584s] [INFO] Linux Tools RPM UI Plug-in SUCCESS [10.956s] [INFO] Linux Tools RPM Import/Export and Building Tools Feature SUCCESS [0.919s] [INFO] Linux Tools RPM Specfile Editor Plug-in ... SUCCESS [21.596s] [INFO] Linux Tools RPM Rpmlint Core Plug-in .. SUCCESS [10.945s] [INFO] Linux Tools RPM Specfile Editor RCP Plug-in ... SUCCESS [8.510s] [INFO] Linux Tools RPM Specfile Editor Documentation Plug-in SUCCESS [0.864s] [INFO] Linux Tools RPM Specfile Editor Feature ... SUCCESS [0.872s] [INFO] Linux Tools RPM Specfile Editor Tests Plug-in . SUCCESS [30.396s] [INFO] Eclipse Linux Tools RPM Stubby Parent . SUCCESS [0.062s] [INFO] Linux Tools RPM Stubby Plug-in SUCCESS [10.718s] [INFO] Linux Tools RPM Stubby Feature (Incubation) ... SUCCESS [0.920s] [INFO] Eclipse Linux Tools SystemTap Parent .. SUCCESS [0.070s] [INFO] Linux Tools Callgraph Core Plug-in SUCCESS [11.686s] [INFO] Linux Tools Callgraph Graphing Plug-in SUCCESS [19.055s] [INFO] Linux Tools Callgraph Launch Plug-in .. SUCCESS [14.777s] [INFO] Linux Tools Callgraph Documentation Plug-in ... SUCCESS [0.746s] [INFO] Linux Tools C/C++ Call Graph Visualization Feature SUCCESS [0.969s] [INFO] Linux Tools Callgraph Launch Tests Plug-in SUCCESS [18.258s] [INFO] Linux Tools Callgraph Graphing Tests Plug-in .. SUCCESS [21.434s] [INFO] Linux Tools Callgraph Tests Feature ... SUCCESS [0.901s] [INFO] Linux Tools SystemTap
[linuxtools-dev] Hudson build is back to normal : linuxtools-master #484
See https://hudson.eclipse.org/hudson/job/linuxtools-master/484/changes ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Build failed in Hudson: linuxtools-master #483
On 21:56:09 Friday 19 August 2011 Andrew Overholt wrote: [Anithra P Janakiraman] Change feature version to 1.2.0 It looks like Anithra forgot to change the version in the matching pom.xml. Where possible, please run local builds before pushing changes so that we don't have broken builds. It's no big deal :) , but it saves on emails and clarifies which commit broke something in situations where multiple commits make it into a Hudson build. Everyone, please learn using maven and tycho. mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the right thing keeping things in sync. Alex I've fixed this and run a local build (mvn clean install). I just pushed a Hudson build: https://hudson.eclipse.org/hudson/job/linuxtools-master/484/ Thanks, Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
[linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
* Alexander Kurtakov akurt...@redhat.com [2011-08-19 14:57]: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the right thing keeping things in sync. This seems promising but how should it be used? If I try it in the top-level directory or in one of the project directories, I get: Cannot find layout implementation corresponding to: 'p2' for remote repository with id: 'indigo'. for project org.eclipse.linuxtools:linuxtools-parent Speaking of that, should have a Juno profile? Maybe once M1 is out? Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
On 22:19:57 Friday 19 August 2011 Andrew Overholt wrote: * Alexander Kurtakov akurt...@redhat.com [2011-08-19 14:57]: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the right thing keeping things in sync. This seems promising but how should it be used? If I try it in the top-level directory or in one of the project directories, I get: Cannot find layout implementation corresponding to: 'p2' for remote repository with id: 'indigo'. for project org.eclipse.linuxtools:linuxtools-parent Are you sure you use maven 3 ? I've seen this error only when people try to use maven 2.x for tycho builds. Speaking of that, should have a Juno profile? Maybe once M1 is out? I have no idea whether there is even Juno repository yet. Should be fairly easy to add one. Alex Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
* Alexander Kurtakov akurt...@redhat.com [2011-08-19 15:22]: On 22:19:57 Friday 19 August 2011 Andrew Overholt wrote: * Alexander Kurtakov akurt...@redhat.com [2011-08-19 14:57]: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the right thing keeping things in sync. [...] Are you sure you use maven 3 ? I've seen this error only when people try to use maven 2.x for tycho builds. Oops, you're right :) It did a nice job of changing all pom.xml files but didn't modify the feature.xml. Do you know if Tycho plans to have this functionality? Or perhaps I'm just using it wrong. I tried setting the valgrind version to 0.8.1 but it didn't change the feature.xml version from 0.8.0. Speaking of that, should have a Juno profile? Maybe once M1 is out? I have no idea whether there is even Juno repository yet. Should be fairly easy to add one. 6 minutes before I got your email, I received another one saying that the Juno repository had just been created :) http://download.eclipse.org/releases/juno/ I'll take care of this in master. Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
On 23:01:13 Friday 19 August 2011 Andrew Overholt wrote: * Alexander Kurtakov akurt...@redhat.com [2011-08-19 15:22]: On 22:19:57 Friday 19 August 2011 Andrew Overholt wrote: * Alexander Kurtakov akurt...@redhat.com [2011-08-19 14:57]: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the right thing keeping things in sync. [...] Are you sure you use maven 3 ? I've seen this error only when people try to use maven 2.x for tycho builds. Oops, you're right :) It did a nice job of changing all pom.xml files but didn't modify the feature.xml. Do you know if Tycho plans to have this functionality? Or perhaps I'm just using it wrong. I tried setting the valgrind version to 0.8.1 but it didn't change the feature.xml version from 0.8.0. Please note that if you run it in valgrind directory it will change the valgrind parent pom and all references to it but it will not change the versions of the bundles and features. Rightfully so because I don't want everything bumped when updating the module's pom. If you want to change the version of the feature go into the feature directory (org.eclipse.linuxtools.valgrind-feature) and run the command again. Here is the output I got: [INFO] [INFO] --- tycho-versions-plugin:0.12.0:set-version (default-cli) @ org.eclipse.linuxtools.valgrind --- [INFO] Making changes in /home/akurtakov/work/org.eclipse.linuxtools/valgrind/org.eclipse.linuxtools.valgrind- feature [INFO] pom.xml//project/version: 0.8.0-SNAPSHOT = 0.8.3 [INFO] feature.xml//feature/@version: 0.8.0.qualifier = 0.8.3 As you see it works correctly. :) Alex Speaking of that, should have a Juno profile? Maybe once M1 is out? I have no idea whether there is even Juno repository yet. Should be fairly easy to add one. 6 minutes before I got your email, I received another one saying that the Juno repository had just been created :) http://download.eclipse.org/releases/juno/ I'll take care of this in master. Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the Please note that if you run it in valgrind directory it will change the valgrind parent pom and all references to it but it will not change the versions of the bundles and features. Ah. But if we want the source tarballs [1] to match the overall release version, we have to change the parent POM versions, right? Thanks for bringing up this Tycho plugin, it's really cool Andrew [1] http://download.eclipse.org/technology/linuxtools/0.8.0-sources/ Note the 0.0.1 and 2.0.0, etc. :) ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
On 23:29:56 Friday 19 August 2011 Andrew Overholt wrote: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the Please note that if you run it in valgrind directory it will change the valgrind parent pom and all references to it but it will not change the versions of the bundles and features. Ah. But if we want the source tarballs [1] to match the overall release version, we have to change the parent POM versions, right? Yup, that's why rpm has the correct version in the tarball :P Alex Thanks for bringing up this Tycho plugin, it's really cool Andrew [1] http://download.eclipse.org/technology/linuxtools/0.8.0-sources/ Note the 0.0.1 and 2.0.0, etc. :) ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
* Alexander Kurtakov akurt...@redhat.com [2011-08-19 16:31]: On 23:29:56 Friday 19 August 2011 Andrew Overholt wrote: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the Please note that if you run it in valgrind directory it will change the valgrind parent pom and all references to it but it will not change the versions of the bundles and features. Ah. But if we want the source tarballs [1] to match the overall release version, we have to change the parent POM versions, right? Yup, that's why rpm has the correct version in the tarball :P I'll make all of them 0.8.1 on stable-0.8 and 0.9.0 on master. This won't affect the feature or plugin versions in any way. Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
Re: [linuxtools-dev] Syncing pom.xml and feature.xml/MANIFEST.MF (was Re: Build failed in Hudson: linuxtools-master #483)
On 23:37:40 Friday 19 August 2011 Andrew Overholt wrote: * Alexander Kurtakov akurt...@redhat.com [2011-08-19 16:31]: On 23:29:56 Friday 19 August 2011 Andrew Overholt wrote: mvn tycho-versions:set-version -DnewVersion=YOUR_VERSION will do the Please note that if you run it in valgrind directory it will change the valgrind parent pom and all references to it but it will not change the versions of the bundles and features. Ah. But if we want the source tarballs [1] to match the overall release version, we have to change the parent POM versions, right? Yup, that's why rpm has the correct version in the tarball :P I'll make all of them 0.8.1 on stable-0.8 and 0.9.0 on master. This won't affect the feature or plugin versions in any way. Thanks for doing that. Though I hoped to see module maintainers taking care of this. This way its visible who pays attention to the details and who doesn't. Alex Andrew ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
