[linuxtools-dev] [Hudson] Hudson build is still unstable: linuxtools-master #1161

[hudsonbuild]

See 


--
This message is automatically generated by Hudson. 
For more information on Hudson, see: http://hudson-ci.org/
___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

Re: [linuxtools-dev] Gerrit reviews,

[sami wagiaalla]

On 11/28/2012 04:43 AM, Aleksandar Kurtakov wrote:

And please don't mix formatting changes with code changes as it becomes really 
hard to review what actually was changed.



The only reason I did that was to avoid having more patches and creating 
a bigger series :). I actually believe that each patch should contain 
only one logical or formatting change.


Gerrit highlights non white-space changes in darker red and darker 
green. This should catch most formatting changes and allow you to focus 
on actual code changes.


  Sami
___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

Re: [linuxtools-dev] Gerrit reviews,

[sami wagiaalla]

Please try to not submit for review patch series - gerrit doesn't handle them 
gracefully and it makes it really hard to review stuff.


The problem is Gerrit makes it more difficult for the submitter to 
separate the patches than for the reviewer to review them in a series; 
for a bunch of patches to be submitted independently each one has to be 
done in an independent branch.


For the reviewer the patch is marked with a "depends on" and a link to 
the parent patch. If needed the reviewer can review only the oldest 
patch until it is approved and committed then do the next. Or mark a 
patch as approved but not merge it and the submitter can go through an 
submit the patches after the series is approved.



At least please don't make it for patches that can be easily separated like the 
recent systemtap series.



That is true. For completely independent patches a branch should be 
created for each one.


  Sami
___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

[linuxtools-dev] Removing org.eclipse.linuxtools.systemtap.backup*

[sami wagiaalla]

Hi,

I have proposed a patch to delete 
org.eclipse.linuxtools.systemtap.backup-feature and 
org.eclipse.linuxtools.systemtap.backup.ui.editor: 
https://git.eclipse.org/r/#/c/8903/


I can't see any usage of these classes within linux tools. Does anyone 
know why they were created or if they are still needed ?


Thanks,
  Sami
___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

[linuxtools-dev] [Hudson] Hudson build became unstable: linuxtools-master #1160

[hudsonbuild]

See 


--
This message is automatically generated by Hudson. 
For more information on Hudson, see: http://hudson-ci.org/
___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

Re: [linuxtools-dev] Gerrit reviews,

[Aleksandar Kurtakov]

And please don't mix formatting changes with code changes as it becomes really 
hard to review what actually was changed.

P.S. From now on I'll probably reject such patches :).

Alexander Kurtakov
Red Hat Eclipse team

- Original Message -
> From: "Aleksandar Kurtakov" 
> To: "Linux Tools developer discussions" 
> Sent: Wednesday, November 28, 2012 11:15:48 AM
> Subject: [linuxtools-dev] Gerrit reviews,
> 
> Sami and others,
> 
> Please try to not submit for review patch series - gerrit doesn't
> handle them gracefully and it makes it really hard to review stuff.
> At least please don't make it for patches that can be easily
> separated like the recent systemtap series.
> 
> 
> Alexander Kurtakov
> Red Hat Eclipse team
> 
> ___
> linuxtools-dev mailing list
> linuxtools-dev@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
> 
___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

[linuxtools-dev] Gerrit reviews,

[Aleksandar Kurtakov]

Sami and others,

Please try to not submit for review patch series - gerrit doesn't handle them 
gracefully and it makes it really hard to review stuff. At least please don't 
make it for patches that can be easily separated like the recent systemtap 
series.


Alexander Kurtakov
Red Hat Eclipse team

___
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev