Re: [Linuxwacom-devel] [PATCH] allow button events while touch is disabled

2011-02-27 Thread Peter Hutterer
On Sun, Feb 27, 2011 at 10:38:05AM -0600, Chris Bagwell wrote:
> On Sun, Feb 27, 2011 at 2:08 AM, Ping Cheng  wrote:
> > On Wed, Feb 23, 2011 at 6:49 AM, Chris Bagwell  wrote:
> > In case you were waiting for my reply, yes, I know both are in the same
> > routine. That's why I had the "reviewed-by".
> > I just repeated what I understood and agreed. Sorry for not saying it
> > clearly.
> > Ping
> 
> I wasn't waiting but perhaps Peter was.  Thanks for email.  I kinda
> forgot patch was still pending.
> 
> Peter, can you commit patch or reject?

not ignoring you, my workload is too high atm. patch is still in my inbox.

Cheers,
  Peter

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-02-27 Thread Favux ...
Hi Peter,

Sounds good.

I like the MatchDriver idea.

Favux

On Sun, Feb 27, 2011 at 8:59 PM, Peter Hutterer
 wrote:
> On Sun, Feb 27, 2011 at 02:13:14PM -0600, Favux ... wrote:
>> Hi Peter,
>>
>> FYI the Tablet Configuration HOWTO is essentially complete.  You can
>> remove the Tablet PC Configuration and Wacom Tablet Configuration
>> pages whenever you are ready to.
>>
>> The 52-wacom-options.conf is a template.  I won't add it to
>> Configuring X until you've had a chance to review it.
>
>
> thanks. As you can see from the history, I'd like to make this new page the
> main [[xorg.conf.d]] page and link to it from Configuring_X. there's plenty
> of information we should provide that it warrants a separate page.
> especially since we have different configurations for 1.8, 1.9 and 1.10.
>
> I haven't really finished with it yet though, I'll try to edit it over the
> next few days.
>
> The main plan is:
> - use MatchDriver instead of duplicating the matches (for server 1.9+)
> - don't tell users to search for the right snippets (they stack anyway),
>  just explain how they can write one that applies to their device
>
> Cheers,
>  Peter
>

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-02-27 Thread Peter Hutterer
On Sun, Feb 27, 2011 at 02:13:14PM -0600, Favux ... wrote:
> Hi Peter,
> 
> FYI the Tablet Configuration HOWTO is essentially complete.  You can
> remove the Tablet PC Configuration and Wacom Tablet Configuration
> pages whenever you are ready to.
> 
> The 52-wacom-options.conf is a template.  I won't add it to
> Configuring X until you've had a chance to review it.


thanks. As you can see from the history, I'd like to make this new page the
main [[xorg.conf.d]] page and link to it from Configuring_X. there's plenty
of information we should provide that it warrants a separate page.
especially since we have different configurations for 1.8, 1.9 and 1.10. 

I haven't really finished with it yet though, I'll try to edit it over the
next few days.

The main plan is:
- use MatchDriver instead of duplicating the matches (for server 1.9+)
- don't tell users to search for the right snippets (they stack anyway),
  just explain how they can write one that applies to their device

Cheers,
  Peter

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL

2011-02-27 Thread Pander
On 2011-02-27 21:16, Pander wrote:
...
> Please let me know what to add to
>   /lib/udev/rules.d/69-xserver-xorg-input-wacom.rules
> for this Wacom Bamboo Fun (pen and touch)

Please confirm if this is the correct patch for udev rules and implement
upstream:



--- /lib/udev/rules.d/.69-xserver-xorg-input-wacom.rules2011-02-27
16:29:59.334113006 +0100
+++ /lib/udev/rules.d/69-xserver-xorg-input-wacom.rules 2011-02-27
21:32:30.726049993 +0100
@@ -92,6 +92,7 @@ ATTRS{idVendor}=="056a", ATTRS{idProduct
 ATTRS{idVendor}=="056a", ATTRS{idProduct}=="00c6",
SYMLINK+="input/tablet-cintiq12wx"
 ATTRS{idVendor}=="056a", ATTRS{idProduct}=="00cc",
SYMLINK+="input/tablet-cintiq21ux2"
 ATTRS{idVendor}=="056a", ATTRS{idProduct}=="00c7",
ENV{WACOM_TYPE}!="touch", SYMLINK+="input/tablet-dtu1931"
+ATTRS{idVendor}=="056a", ATTRS{idProduct}=="00db",
SYMLINK="input/tablet-wacom-bamboo-pen_touch-$env{WACOM_TYPE}"

 # Convenience links for the common case of a single tablet.  We could
do just this:
 #ATTRS{idVendor}=="056a", SYMLINK+="input/wacom-$env{WACOM_TYPE}"



> Thanks,
> 
> Pander
> 
> --
> Free Software Download: Index, Search & Analyze Logs and other IT data in 
> Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
> generated by your applications, servers and devices whether physical, virtual
> or in the cloud. Deliver compliance at lower cost and gain new business 
> insights. http://p.sf.net/sfu/splunk-dev2dev 
> ___
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


[Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL

2011-02-27 Thread Pander
Hi all,

Here are some patches for supporting Wacom Bamboo Fun CTH-661SE-NL.
These are created on a system with Ubuntu 10.10 Maverick.

The USB ID has been added to the USB ID Repository at
https://usb-ids.gowdy.us/read/UD/056a/00db

Before this trickles down, the following patches need to be applied:



--- /var/lib/usbutils/.usb.ids  2011-02-27 20:58:10.58605 +0100
+++ /var/lib/usbutils/usb.ids   2011-02-27 21:01:34.706049996 +0100
@@ -4892,6 +4892,7 @@
00c6  Cintiq 12WX
00c7  DTU-1931
00d3  Bamboo Fun (CTH-661)
+   00db  Bamboo Fun (CTH-661SE-NL)
0400  PenPartner 4x5
4850  PenPartner 6x8
 056b  Decicon, Inc.



--- /usr/share/hwdata/.usb.ids  2011-02-27 21:07:29.386049996 +0100
+++ /usr/share/hwdata/usb.ids   2011-02-27 21:08:04.076049994 +0100
@@ -4629,6 +4629,7 @@
0044  Intuos2 12x12
0045  Intuos2 12x18
00b5  Intuos3 6x11 (PTZ-631W)
+   00db  Bamboo Fun (CTH-661SE-NL)
0400  PenPartner 4x5
4850  PenPartner 6x8
 056b  Decicon, Inc.



--- /lib/modules/2.6.35-25-generic/.modules.alias   2011-02-27
16:18:03.554113003 +0100
+++ /lib/modules/2.6.35-25-generic/modules.alias2011-02-27
16:18:46.304113004 +0100
@@ -7842,6 +7842,7 @@ alias usb:v056Ap0012d*dc*dsc*dp*ic*isc*i
 alias usb:v056Ap0011d*dc*dsc*dp*ic*isc*ip* wacom
 alias usb:v056Ap0010d*dc*dsc*dp*ic*isc*ip* wacom
 alias usb:v056Apd*dc*dsc*dp*ic*isc*ip* wacom
+alias usb:v056Ap00DBd*dc*dsc*dp*ic*isc*ip* wacom
 alias platform:88pm860x-touch 88pm860x_ts
 alias spi:ad7877 ad7877
 alias spi:ad7879 ad7879



--- /lib/modules/2.6.35-25-generic/.modules.usbmap  2011-02-27
16:15:12.214112988 +0100
+++ /lib/modules/2.6.35-25-generic/modules.usbmap   2011-02-27
16:17:21.934112993 +0100
@@ -3533,6 +3533,7 @@ wacom0x0003  0x056a
 wacom0x0003  0x056a   0x00e20x   0x
  0x00 0x000x000x000x00
  0x00   0x0
 wacom0x0003  0x056a   0x00e30x   0x
  0x00 0x000x000x000x00
  0x00   0x0
 wacom0x0003  0x056a   0x00470x   0x
  0x00 0x000x000x000x00
  0x00   0x0
+wacom0x0003  0x056a   0x00db0x   0x
  0x00 0x000x000x000x00
  0x00   0x0
 usbtouchscreen   0x0283  0x0eef   0x00010x   0x
  0x00 0x000x000x030x00
  0x02   0x0
 usbtouchscreen   0x0283  0x0eef   0x00020x   0x
  0x00 0x000x000x030x00
  0x02   0x0
 usbtouchscreen   0x0003  0x3823   0x00010x   0x
  0x00 0x000x000x000x00
  0x00   0x0



Please also report them upstream.

Please let me know what to add to
  /lib/udev/rules.d/69-xserver-xorg-input-wacom.rules
for this Wacom Bamboo Fun (pen and touch)

Thanks,

Pander

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-02-27 Thread Favux ...
Hi Peter,

FYI the Tablet Configuration HOWTO is essentially complete.  You can
remove the Tablet PC Configuration and Wacom Tablet Configuration
pages whenever you are ready to.

The 52-wacom-options.conf is a template.  I won't add it to
Configuring X until you've had a chance to review it.

Favux

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] Make 1 finger tap work based on finger release.

2011-02-27 Thread Chris Bagwell
On Mon, Feb 21, 2011 at 3:53 PM, Ping Cheng  wrote:
> On Tue, Feb 22, 2011 at 4:29 AM, Andrzej Giniewicz  wrote:
>>
>> Hi,
>>
>> > Looks like you have tested this patch yourself. Can you report back here
>> > with your testing result and a "Tested-by" tag? I am willing to put
>> > "Acked-by" once I see "Tested-by".
>>
>> well, indeed I tested it.  About tagging, I'm not sure if this is what
>> you mean, but here goes a try. If this is done somehow else, would be
>> happy to do it differently, never tagged a thing here so I don't know
>> the rules yet :)
>
> Thank you. You are following the rules ;). In fact, I just needed a second
> opinion on the change.
>
>> cheers,
>> Andrzej.
>>
>> Tested-by: Andrzej Giniewicz 
>
> Acked-by: Ping Cheng 
>
> Ping
>

Peter, any comments on this patch?

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] allow button events while touch is disabled

2011-02-27 Thread Chris Bagwell
On Sun, Feb 27, 2011 at 2:08 AM, Ping Cheng  wrote:
> On Wed, Feb 23, 2011 at 6:49 AM, Chris Bagwell  wrote:
> In case you were waiting for my reply, yes, I know both are in the same
> routine. That's why I had the "reviewed-by".
> I just repeated what I understood and agreed. Sorry for not saying it
> clearly.
> Ping

I wasn't waiting but perhaps Peter was.  Thanks for email.  I kinda
forgot patch was still pending.

Peter, can you commit patch or reject?

Thanks,
Chris

--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] allow button events while touch is disabled

2011-02-27 Thread Ping Cheng
On Wed, Feb 23, 2011 at 6:49 AM, Chris Bagwell  wrote:

> On Tue, Feb 22, 2011 at 1:32 PM, Ping Cheng  wrote:
> > On Tue, Feb 22, 2011 at 7:01 AM, Chris Bagwell 
> wrote:
> >>
> >> On Mon, Feb 21, 2011 at 9:09 PM, Ping Cheng 
> wrote:
> >> > On Mon, Feb 21, 2011 at 9:19 AM,  wrote:
> >> >>
> >> >> From: Chris Bagwell 
> >> >>
> >> >> PROTOCOL_GENERIC devices send "pad" buttons along
> >> >> with touchscreen/touchpad events.  Since we are
> >> >> emulating "pad" device concept, we need to let
> >> >> "pad" events go through when "touch" is disabled.
> >> >>
> >> >> There seems to be a popular script floating around
> >> >> that toggles "touch" device on/off by using
> >> >> same devices "pad" buttons.  This patch allows that
> >> >> to work again.
> >> >>
> >> >> Signed-off-by: Chris Bagwell 
> >
> > Reviewed-by: Ping Cheng 
>
> Thanks.
>
> >
> > Thank you Chris. A minor reply to you inline.
> >
> > PIng
> >>
> >> >> ---
> >> >>  src/wcmUSB.c |   29 +++--
> >> >>  1 files changed, 15 insertions(+), 14 deletions(-)
> >> >>
> >> >> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
> >> >> index 4aae452..cb7bf6b 100644
> >> >> --- a/src/wcmUSB.c
> >> >> +++ b/src/wcmUSB.c
> >> >> @@ -1312,10 +1312,6 @@ static void usbDispatchEvents(InputInfoPtr
> >> >> pInfo)
> >> >>}
> >> >>}
> >> >>
> >> >> -   /* don't send touch event when touch isn't enabled */
> >> >> -   if ((ds->device_type == TOUCH_ID) && !common->wcmTouch)
> >> >
> >> > I guess the root cause of the issue was device_type for PAD was not
> set
> >> > at
> >> > this stage. If we move:
> >> >
> >> > if (private->wcmBTNChannel != channel && btn_channel_change)
> >> > {
> >> > /* Force to in proximity for this special case */
> >> > btn_ds->proximity = 1;
> >> > btn_ds->device_type = PAD_ID;
> >> > btn_ds->device_id = PAD_DEVICE_ID;
> >> > btn_ds->serial_num = 0xf0;
> >> > }
> >> >
> >> > or just:
> >> >
> >> > if (private->wcmBTNChannel != channel && btn_channel_change)
> >> > {
> >> > btn_ds->device_type = PAD_ID;
> >> > btn_ds->device_id = PAD_DEVICE_ID;
> >> > }
> >> >
> >> > above the if statement, the rest can stay unchanged.
> >> >
> >>
> >> Not exactly.  That is because both TOUCH and PAD events can come in
> >> same sync window.  So we need to break them into two batches and
> >> execute them in two batches.  Thats why instead of returning I changed
> >> conditionally send touch to wcmEvent() but always send pad to
> >> wcmEvent().
> >>
> >> Sure, we could basically discard touch data (by forcing device to PAD
> >> as you show) and let it be posted in future interrupts but this goes
> >> ahead and handles them now.
> >
> > Since it is specific to generic protocol, let's send both touch and pad
> data
> > in the same routine.
> >
>
> We are sending both for generic when possible but the pad part was
> just below end of patch (unchanged).
>

In case you were waiting for my reply, yes, I know both are in the same
routine. That's why I had the "reviewed-by".

I just repeated what I understood and agreed. Sorry for not saying it
clearly.

Ping
--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev ___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel