Re: [Linuxwacom-devel] [PATCH] Add support for Lenovo tablet ID 0xE6

2011-04-01 Thread TImo Aaltonen
On 01.04.2011 19:59, Ping Cheng wrote:
> Hi Timo,
> 
> Does E6 come with a stylus (pen)? If so, you need to change the resolution
> from 5 to 10.

As I understand it, yes. Actually, it was tested with 0.10.8 which used
old resolution values (1016), so here I copied what Volito2 had in master..

t

--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [linuxwacom-announce] [ANNOUNCE] xf86-input-wacom 0.10.99.1

2011-04-01 Thread Andrzej Giniewicz
Hi,

I just tested the 0.10.99.1 out using kernel
2.6.37.5+input-wacom-0.10.11 on Bamboo 2FG 4x5 (P&T).
I noticed two regressions compared to 0.10.11, all on fresh setup
without configuration changes:

1) Button 9 on finger pad no longer works for me - it doesn't generate
any event in xev (other buttons 1, 3 and 8 works)
2) Even that I have gesture and touch set to "on", touchpad does not
work at all (no tapping, moving, touching, etc - xev is silent for
fingers) - was there any change to the touch features and something
more needs to be enabled?

Andrzej.

--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH 7/7] Fix get_map to return proper wheel/strip button number

2011-04-01 Thread Jason Gerecke
On Thu, Mar 31, 2011 at 9:28 PM, Peter Hutterer
 wrote:
> On Thu, Mar 31, 2011 at 12:07:32AM -0700, Jason Gerecke wrote:
>> On Wed, Mar 30, 2011 at 9:20 PM, Peter Hutterer
>>  wrote:
>> > On Wed, Mar 30, 2011 at 01:54:47PM -0700, Jason Gerecke wrote:
>> >> Adding to the only-kinda-hackish use of XGetDeviceButtonMapping,
>> >> in get_map, this total hackjob of a patch "fixes" the problem with
>> >> us having no way of knowing the driver's defaults for wheels and
>> >> strips.
>> >>
>> >> Thankfully, the defaults aren't changing anytime soon so its
>> >> not likely to break. Additionally, once the raw button path is
>> >> removed from the driver, the entire 'get_map' function can go
>> >> the way of the dodo.
>> >
>> > This seems to solve the wrong problem. How about we decide that xsetwacom
>> > controls the physical buttons on the device? That way, anyone wanting to
>> > configure logical mapping can use the X tools and xsetwacom is
>> > driver-specific and stays (documented so!) driver-specific. which of course
>> > also means we need to check that the Button xorg.conf option does the right
>> > thing.
>> >
>> That would make a number of things easier, but also comes with its own
>> drawbacks. I think we should probably figure out where hassle,
>> correctness, and compatibility collide first.
>
> just checked the man page again:
>
> Option "ButtonM" "AC"
>   reports  an  action  AC when button M is pressed,  where M is one of the
>   device supported  button numbers,  it can be 1 to 32. Wacom uses a
>   driver-internal button mapping, where any physical button appears to the
>   X server as  the button specified by the ButtonM mapping. Hence, if two
>   physical buttons have the same ButtonM mapping, the server will think
>   they are the same physical button.  The default action reported to the X
>   server is mouse button M click. Because X uses buttons 4, 5, 6, and 7 as
>   the four scrolling directions, physical buttons 4 and higher are mapped
>   to 8 and higher by default.  To ignore the button click, i.e.,  to  not
>   report  any  button click event to the X server,  use "0" or "button 0".
>
> so at least for the xorg.conf option, we already say that this is the
> _physical_ button mapping. I guess it makes sense then to have xsetwacom do
> the same on the physical buttons and leave the X specific stuff up to the X
> tools.
>
> Cheers,
>  Peter
>
And xsetwacom's man page is wholly silent on just what its version 'M'
is, so deferring to the existing docs would make sense.

Of course, despite the lack of official documentation, its "expected"
by users familiar with xsetwacom that it use the X button number.
Don't get me wrong -- I'd love to see the change. I just hate breaking
things for our users/customers without good cause. :) Then again, we
already broke compatibility in the last release, so...

Jason

---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.

--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips "reset"]

2011-04-01 Thread Jason Gerecke
On Thu, Mar 31, 2011 at 9:21 PM, Peter Hutterer
 wrote:
> On Wed, Mar 30, 2011 at 11:51:22PM -0700, Jason Gerecke wrote:
>> On Wed, Mar 30, 2011 at 9:04 PM, Peter Hutterer
>>  wrote:
>> > On Wed, Mar 30, 2011 at 01:54:45PM -0700, Jason Gerecke wrote:
>> >> Since the worker functions now check that they have the appropriate
>> >> number of arguments, its possible to decrease the number of arguments
>> >> required by 'set'. Since all it really needs is a device number and
>> >> a property, the minimum argc is now 2.
>> >>
>> >> A handy side-effect of this change is that its now possible to run
>> >> e.g. `xsetwacom --set $ID StripLeftDown` to reset the action to
>> >> its default.
>> >
>> > is that because we delete the property then so it falls back to using the
>> > button mapping?
>> >
>> Correct.
>>
>> > this formulation is a bit unfortunate, since it doesn't actually set to the
>> > default. if I map the button to say 8, then run the above command it would
>> > revert back to 8, not to the default (4 or whatever it is), right?
>> >
>> > Cheers,
>> >  Peter
>> >
>> I'm not quite sure what you mean here. If no action has been defined,
>> the driver falls back to its predefined button. If you run e.g.
>> `xsetwacom --set $ID LeftStripUp 8`, the action "button +8" is
>> assigned (because of parse_action's simple button handling). When you
>> move your finger along the strip, the driver notices an action has
>> been set and will send the button 8 event. If you then run `xsetwacom
>> --set $ID LeftStripUp` the action is deleted. Moving your finger along
>> the strip again, the driver will not find an action and fall back to
>> its predefined mapping (which should be button 5)
>
> Where is this 5 coming from? shouldn't this be the equivalent of "button
> +5" in the driver?
>
> Cheers,
>  Peter
>
getWheelButton (in wcmCommon.c) is responsible for finding both the
"fakeButton" and "fakeKey" that could be associated with various
device events. In the case of our hypothetical "strip left up", it
gets the button from 'priv->striplup' and the key from
'priv->strip_keys[0]'. The former is defined during wcmAllocate and is
never changed. The latter is changed by wcmUpdateButtonKeyActions
(after a long call chain beginning with wcmSetProperty) whenever X
detects a change in the WACOM_PROP_STRIPBUTTONS property.
getWheelButton then returns both of these to sendWheelStripEvents. If
a "key" is defined, it will preferentially decode it and send the
necessary events. Otherwise, it interprets the raw integer fakeButton
as the X button to send a button press event for.

When xsetwacom is given arguments to StripLeftUp, it converts them
into an action and modifies the appropriate offset into
WACOM_PROP_STRIPBUTTONS. When the appropriate motion is made the
driver notices an action is sent and sends it. When it is run without
arguments, it clears the offset, so the same motion results in the
driver not finding an action and sending the default button. Note that
xsetwacom works the same way for "Button X"! Running with arguments
sets an action the driver will preferentially use; running without
arguments clears the action, forcing the driver to fall back on the
raw integer defined in the button[] array.


The only thing I find a little mystifying is how priv->strip_keys is
initially set. My first thought was that it was done when the
properties were first created -- this doesn't look to be true. My
second thought was that perhaps the entire priv structure was zeroed
out prior to initialization -- can't find evidence of this either. I
would think unless strip_keys[] were initialized somewhere it'd be
filled with random junk, defeating the logic used and resulting in
completely undefined behavior...

Jason

---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.

--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] Add support for Lenovo tablet ID 0xE6

2011-04-01 Thread Ping Cheng
Hi Timo,

Does E6 come with a stylus (pen)? If so, you need to change the resolution
from 5 to 10.

Thank you.

Ping

P.S., I don't have that system myself.

On Fri, Apr 1, 2011 at 2:45 AM, Timo Aaltonen  wrote:

> From: Timo Aaltonen 
>
> Signed-off-by: Timo Aaltonen 
> Tested-by: Manoj Iyer 
> ---
>  src/wcmUSB.c |1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
> index 81af067..61983eb 100644
> --- a/src/wcmUSB.c
> +++ b/src/wcmUSB.c
> @@ -269,6 +269,7 @@ static struct
>{ WACOM_VENDOR_ID, 0x9F,394,394, &usbTabletPC   }, /*
> CapPlus  0x9F */
>{ WACOM_VENDOR_ID, 0xE2,394,394, &usbTabletPC   }, /*
> TabletPC 0xE2 */
>{ WACOM_VENDOR_ID, 0xE3, 10, 10, &usbTabletPC   }, /*
> TabletPC 0xE3 */
> +   { WACOM_VENDOR_ID, 0xE6,  5,  5, &usbTabletPC   }, /*
> TabletPC 0xE6 */
>
>/* IDs from Waltop's driver, available
> http://www.waltop.com.tw/download.asp?lv=0&id=2.
>   Accessed 8 Apr 2010, driver release date 2009/08/11, fork of
> linuxwacom 0.8.4.
> --
> 1.7.4.1
>
>
>
> --
> Create and publish websites with WebMatrix
> Use the most popular FREE web apps or write code yourself;
> WebMatrix provides all the features you need to develop and
> publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
> ___
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


[Linuxwacom-devel] [PATCH] Add support for Lenovo tablet ID 0xE6

2011-04-01 Thread Timo Aaltonen
From: Timo Aaltonen 

Signed-off-by: Timo Aaltonen 
Tested-by: Manoj Iyer 
---
 src/wcmUSB.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 81af067..61983eb 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -269,6 +269,7 @@ static struct
{ WACOM_VENDOR_ID, 0x9F,394,394, &usbTabletPC   }, /* CapPlus  
0x9F */
{ WACOM_VENDOR_ID, 0xE2,394,394, &usbTabletPC   }, /* TabletPC 
0xE2 */
{ WACOM_VENDOR_ID, 0xE3, 10, 10, &usbTabletPC   }, /* TabletPC 
0xE3 */
+   { WACOM_VENDOR_ID, 0xE6,  5,  5, &usbTabletPC   }, /* TabletPC 
0xE6 */
 
/* IDs from Waltop's driver, available 
http://www.waltop.com.tw/download.asp?lv=0&id=2.
   Accessed 8 Apr 2010, driver release date 2009/08/11, fork of 
linuxwacom 0.8.4.
-- 
1.7.4.1


--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel