Re: [Linuxwacom-devel] [PATCH 03/14] Fix warning: Change default_options to be const

2012-05-27 Thread Peter Hutterer 
On Fri, May 25, 2012 at 12:49:03PM -0700, Jason Gerecke wrote:
 ../src/wcmConfig.c: At top level:
 ../src/wcmConfig.c:212:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:212:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:213:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:213:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:214:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:214:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:215:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:215:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:216:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:216:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:217:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 ../src/wcmConfig.c:217:2: warning: initialization discards 'const' qualifier 
 from pointer target type [enabled by default]
 
 Signed-off-by: Jason Gerecke killert...@gmail.com
 ---
  src/wcmConfig.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/wcmConfig.c b/src/wcmConfig.c
 index 7a4cfde..aeae119 100644
 --- a/src/wcmConfig.c
 +++ b/src/wcmConfig.c
 @@ -207,7 +207,7 @@ int wcmGetPhyDeviceID(WacomDevicePtr priv)
   * starts making sense again.
   */
  
 -static char *default_options[] =
 +static const char *default_options[] =
  {
   StopBits,1,
   DataBits,8,
 -- 
 1.7.10.2

for the archives: this only moves the warning, but i've got a patch for the
ABI update to the server to fix the second half.

Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

Cheers,
  Peter

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Re: [Linuxwacom-devel] [PATCH 00/14] Lots of compiler warning fixes

2012-05-27 Thread Peter Hutterer 
On Fri, May 25, 2012 at 12:49:00PM -0700, Jason Gerecke wrote:
 The compiler is spitting out too many warnings for me to easily
 find concerns about new changes, so I've gone ahead and addressed
 a number of the ones I'm getting. There are still a handful of
 warnings left, but they're a little harder to fix.

series: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
but please remember to fix up the commit msg to 01/14 before pushing as
Chris suggested.

Cheers,
  Peter
 
 Jason Gerecke (14):
   Fix warning: Remove superflous casts in getScrollDelta
   Fix warning: Have wcmEventAutoDevProbe return const
   Fix warning: Change default_options to be const
   Fix warning: Constify _WacomCommonRec.device_path
   Fix warning: Remove superflous 'event' pointer in usbParseBTNEvent
   Fix warning: Constify 'name' argument of InitWcmAtom
   Fix warning: Swap empty strings for NULL in wcmCheckSource
   Fix warning: Swap empty string for NULL in wcmIsDuplicate
   Fix warning: Swap empty string for NULL in wcmNeedAutoHotplug
   Fix warning: Swap empty string for NULL in wcmIsAValidType
   Fix warning: Swap empty string for NULL in wcmIsHotpluggedDevice
   Fix warning: Remove variable re-definition in wcmSerialValidate
   Fix warning: Re-scope variable in wcmPreInitParseOptions
   Align returned type of wcmEventAutoDevProbe with expected type
 
  src/wcmCommon.c |6 +++---
  src/wcmConfig.c |8 
  src/wcmISDV4.c  |2 +-
  src/wcmUSB.c|5 ++---
  src/wcmValidateDevice.c |   32 
  src/wcmXCommand.c   |2 +-
  src/xf86Wacom.c |4 ++--
  src/xf86Wacom.h |4 ++--
  src/xf86WacomDefs.h |2 +-
  9 files changed, 32 insertions(+), 33 deletions(-)
 
 -- 
 1.7.10.2

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel