Re: [Linuxwacom-devel] [PATCH] Input: wacom - Mark Intuos5 pad as in-prox when touching buttons

2012-09-22 Thread Chris Bagwell 
On Fri, Sep 14, 2012 at 6:30 PM, Jason Gerecke  wrote:
> If the ExpressKeys on the Intuos5 are touched, they currently result
> an out-of-prox packet being sent even if the pad is already out of
> prox. This can cause some confusion in the X driver. To restore the
> expected semantics, we make being touched a sufficient condition to
> signal proximity.

Seems like easiest solution to prevent invalid event sequencies.

Reviewed-by: Chris Bagwell 

>
> https://bugs.freedesktop.org/show_bug.cgi?id=54250
>
> Reported-by: Timo Aaltonen 
> Signed-off-by: Jason Gerecke 
> ---
>  drivers/input/tablet/wacom_wac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c 
> b/drivers/input/tablet/wacom_wac.c
> index 532d067..9317109 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -606,7 +606,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom)
> input_report_abs(input, ABS_WHEEL, 0);
> }
>
> -   if (data[2] | (data[3] & 0x01) | data[4]) {
> +   if (data[2] | (data[3] & 0x01) | data[4] | data[5]) {
> input_report_key(input, wacom->tool[1], 1);
> input_report_abs(input, ABS_MISC, 
> PAD_DEVICE_ID);
> } else {
> --
> 1.7.12
>

--
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

[Linuxwacom-devel] [PATCH] Input: wacom - Mark Intuos5 pad as in-prox when touching buttons

2012-09-14 Thread Jason Gerecke 
If the ExpressKeys on the Intuos5 are touched, they currently result
an out-of-prox packet being sent even if the pad is already out of
prox. This can cause some confusion in the X driver. To restore the
expected semantics, we make being touched a sufficient condition to
signal proximity.

https://bugs.freedesktop.org/show_bug.cgi?id=54250

Reported-by: Timo Aaltonen 
Signed-off-by: Jason Gerecke 
---
 drivers/input/tablet/wacom_wac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 532d067..9317109 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -606,7 +606,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom)
input_report_abs(input, ABS_WHEEL, 0);
}
 
-   if (data[2] | (data[3] & 0x01) | data[4]) {
+   if (data[2] | (data[3] & 0x01) | data[4] | data[5]) {
input_report_key(input, wacom->tool[1], 1);
input_report_abs(input, ABS_MISC, 
PAD_DEVICE_ID);
} else {
-- 
1.7.12


--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel