Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-31 Thread Bastien Nocera
Robert Ancell  writes:

> 
> Attached patch stops private symbols from being exported in the library 
> (currently bus_from_str, bus_to_str, type_from_str)

The patch is fine by me. People that want to port it to Solaris will need to 
start by making libgudev a compile-time dependency. We can see after that :)

Pushed


--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Peter Hutterer
On Wed, Jan 11, 2012 at 04:38:54PM +0100, Robert Ancell wrote:
> Attached patch stops private symbols from being exported in the
> library (currently bus_from_str, bus_to_str, type_from_str)

Can we use something similar to X.org's _X_EXPORT. At least that forces us
to mark symbols we actually want to export explicitly.
 
Cheers,
  Peter

> >From b4a7a3a434f1fa03a3f8a94c84f5b60d83980a1c Mon Sep 17 00:00:00 2001
> From: Robert Ancell 
> Date: Tue, 10 Jan 2012 10:19:46 +0100
> Subject: [PATCH] lib: Don't export private symbols
> 
> Signed-off-by: Robert Ancell 
> ---
>  libwacom/Makefile.am |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/libwacom/Makefile.am b/libwacom/Makefile.am
> index c09417a..57032db 100644
> --- a/libwacom/Makefile.am
> +++ b/libwacom/Makefile.am
> @@ -9,6 +9,8 @@ libwacom_la_SOURCES = \
>libwacom-error.c \
> libwacom-database.c
>  
> +libwacom_la_LDFLAGS = -export-symbols-regex '^libwacom_'
> +
>  libwacom_la_LIBADD = $(GLIB_LIBS)
>  
>  libwacomincludedir = $(includedir)/libwacom-1.0/libwacom/
> -- 
> 1.7.7.3


--
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Jason Gerecke
I've been meaning to get around to fixing up and submitting the
Solaris patches that were submitted a while back (they work fine, but
are in need of some editing)... Higher priority projects keep
appearing on my plate before I can do much with it, but I'd still like
to keep the GNU-isms to a minimum.

Jason

---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.



On Wed, Jan 11, 2012 at 2:49 PM, Ping Cheng  wrote:
> On Wed, Jan 11, 2012 at 12:57 PM, Chris Bagwell 
> wrote:
>>
>> This uses a gnu-ish.  Not sure if this matters or if any of the other
>> xf86-input-* do this type stuff.
>>
>> Once upon a time, there was a port of xf86-input-wacom to Solaris
>> using non-GNU linker.
>
>
> We still need this port. So, please keep the link whenever possible.
>
> Thank you.
>
> Ping
>
>>
>>
>> Chris
>>
>> On Wed, Jan 11, 2012 at 9:38 AM, Robert Ancell
>>  wrote:
>> > Attached patch stops private symbols from being exported in the library
>> > (currently bus_from_str, bus_to_str, type_from_str)
>> >
>> > Thanks,
>> > --Robert Ancell
>> >
>> >
>> > --
>> > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a
>> > complex
>> > infrastructure or vast IT resources to deliver seamless, secure access
>> > to
>> > virtual desktops. With this all-in-one solution, easily deploy virtual
>> > desktops for less than the cost of PCs and save 60% on VDI
>> > infrastructure
>> > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
>> > ___
>> > Linuxwacom-devel mailing list
>> > Linuxwacom-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>> >
>>
>>
>> --
>> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
>> infrastructure or vast IT resources to deliver seamless, secure access to
>> virtual desktops. With this all-in-one solution, easily deploy virtual
>> desktops for less than the cost of PCs and save 60% on VDI infrastructure
>> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
>> ___
>> Linuxwacom-devel mailing list
>> Linuxwacom-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
>
>
> --
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> ___
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>

--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Ping Cheng
On Wed, Jan 11, 2012 at 12:57 PM, Chris Bagwell wrote:

> This uses a gnu-ish.  Not sure if this matters or if any of the other
> xf86-input-* do this type stuff.
>
> Once upon a time, there was a port of xf86-input-wacom to Solaris
> using non-GNU linker.


We still need this port. So, please keep the link whenever possible.

Thank you.

Ping


>
> Chris
>
> On Wed, Jan 11, 2012 at 9:38 AM, Robert Ancell
>  wrote:
> > Attached patch stops private symbols from being exported in the library
> > (currently bus_from_str, bus_to_str, type_from_str)
> >
> > Thanks,
> > --Robert Ancell
> >
> >
> --
> > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> > infrastructure or vast IT resources to deliver seamless, secure access to
> > virtual desktops. With this all-in-one solution, easily deploy virtual
> > desktops for less than the cost of PCs and save 60% on VDI infrastructure
> > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> > ___
> > Linuxwacom-devel mailing list
> > Linuxwacom-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> >
>
>
> --
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> ___
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Chris Bagwell
This uses a gnu-ish.  Not sure if this matters or if any of the other
xf86-input-* do this type stuff.

Once upon a time, there was a port of xf86-input-wacom to Solaris
using non-GNU linker.

Chris

On Wed, Jan 11, 2012 at 9:38 AM, Robert Ancell
 wrote:
> Attached patch stops private symbols from being exported in the library
> (currently bus_from_str, bus_to_str, type_from_str)
>
> Thanks,
> --Robert Ancell
>
> --
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> ___
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>

--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


[Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Robert Ancell
Attached patch stops private symbols from being exported in the library 
(currently bus_from_str, bus_to_str, type_from_str)


Thanks,
--Robert Ancell
>From b4a7a3a434f1fa03a3f8a94c84f5b60d83980a1c Mon Sep 17 00:00:00 2001
From: Robert Ancell 
Date: Tue, 10 Jan 2012 10:19:46 +0100
Subject: [PATCH] lib: Don't export private symbols

Signed-off-by: Robert Ancell 
---
 libwacom/Makefile.am |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/libwacom/Makefile.am b/libwacom/Makefile.am
index c09417a..57032db 100644
--- a/libwacom/Makefile.am
+++ b/libwacom/Makefile.am
@@ -9,6 +9,8 @@ libwacom_la_SOURCES = \
   libwacom-error.c \
 		  libwacom-database.c
 
+libwacom_la_LDFLAGS = -export-symbols-regex '^libwacom_'
+
 libwacom_la_LIBADD = $(GLIB_LIBS)
 
 libwacomincludedir = $(includedir)/libwacom-1.0/libwacom/
-- 
1.7.7.3

--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel