Re: [Linuxwacom-devel] [PATCH 00/14] Lots of compiler warning fixes
On Fri, May 25, 2012 at 12:49 PM, Jason Gerecke killert...@gmail.com wrote: The compiler is spitting out too many warnings for me to easily find concerns about new changes, so I've gone ahead and addressed a number of the ones I'm getting. There are still a handful of warnings left, but they're a little harder to fix. Jason Gerecke (14): Fix warning: Remove superflous casts in getScrollDelta Fix warning: Have wcmEventAutoDevProbe return const Fix warning: Change default_options to be const Fix warning: Constify _WacomCommonRec.device_path Fix warning: Remove superflous 'event' pointer in usbParseBTNEvent Fix warning: Constify 'name' argument of InitWcmAtom Fix warning: Swap empty strings for NULL in wcmCheckSource Fix warning: Swap empty string for NULL in wcmIsDuplicate Fix warning: Swap empty string for NULL in wcmNeedAutoHotplug Fix warning: Swap empty string for NULL in wcmIsAValidType Fix warning: Swap empty string for NULL in wcmIsHotpluggedDevice Fix warning: Remove variable re-definition in wcmSerialValidate Fix warning: Re-scope variable in wcmPreInitParseOptions Align returned type of wcmEventAutoDevProbe with expected type src/wcmCommon.c | 6 +++--- src/wcmConfig.c | 8 src/wcmISDV4.c | 2 +- src/wcmUSB.c | 5 ++--- src/wcmValidateDevice.c | 32 src/wcmXCommand.c | 2 +- src/xf86Wacom.c | 4 ++-- src/xf86Wacom.h | 4 ++-- src/xf86WacomDefs.h | 2 +- 9 files changed, 32 insertions(+), 33 deletions(-) -- 1.7.10.2 Pushed with fixes. Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH 00/14] Lots of compiler warning fixes
On Fri, May 25, 2012 at 12:49:00PM -0700, Jason Gerecke wrote: The compiler is spitting out too many warnings for me to easily find concerns about new changes, so I've gone ahead and addressed a number of the ones I'm getting. There are still a handful of warnings left, but they're a little harder to fix. series: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net but please remember to fix up the commit msg to 01/14 before pushing as Chris suggested. Cheers, Peter Jason Gerecke (14): Fix warning: Remove superflous casts in getScrollDelta Fix warning: Have wcmEventAutoDevProbe return const Fix warning: Change default_options to be const Fix warning: Constify _WacomCommonRec.device_path Fix warning: Remove superflous 'event' pointer in usbParseBTNEvent Fix warning: Constify 'name' argument of InitWcmAtom Fix warning: Swap empty strings for NULL in wcmCheckSource Fix warning: Swap empty string for NULL in wcmIsDuplicate Fix warning: Swap empty string for NULL in wcmNeedAutoHotplug Fix warning: Swap empty string for NULL in wcmIsAValidType Fix warning: Swap empty string for NULL in wcmIsHotpluggedDevice Fix warning: Remove variable re-definition in wcmSerialValidate Fix warning: Re-scope variable in wcmPreInitParseOptions Align returned type of wcmEventAutoDevProbe with expected type src/wcmCommon.c |6 +++--- src/wcmConfig.c |8 src/wcmISDV4.c |2 +- src/wcmUSB.c|5 ++--- src/wcmValidateDevice.c | 32 src/wcmXCommand.c |2 +- src/xf86Wacom.c |4 ++-- src/xf86Wacom.h |4 ++-- src/xf86WacomDefs.h |2 +- 9 files changed, 32 insertions(+), 33 deletions(-) -- 1.7.10.2 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH 00/14] Lots of compiler warning fixes
The compiler is spitting out too many warnings for me to easily find concerns about new changes, so I've gone ahead and addressed a number of the ones I'm getting. There are still a handful of warnings left, but they're a little harder to fix. Jason Gerecke (14): Fix warning: Remove superflous casts in getScrollDelta Fix warning: Have wcmEventAutoDevProbe return const Fix warning: Change default_options to be const Fix warning: Constify _WacomCommonRec.device_path Fix warning: Remove superflous 'event' pointer in usbParseBTNEvent Fix warning: Constify 'name' argument of InitWcmAtom Fix warning: Swap empty strings for NULL in wcmCheckSource Fix warning: Swap empty string for NULL in wcmIsDuplicate Fix warning: Swap empty string for NULL in wcmNeedAutoHotplug Fix warning: Swap empty string for NULL in wcmIsAValidType Fix warning: Swap empty string for NULL in wcmIsHotpluggedDevice Fix warning: Remove variable re-definition in wcmSerialValidate Fix warning: Re-scope variable in wcmPreInitParseOptions Align returned type of wcmEventAutoDevProbe with expected type src/wcmCommon.c |6 +++--- src/wcmConfig.c |8 src/wcmISDV4.c |2 +- src/wcmUSB.c|5 ++--- src/wcmValidateDevice.c | 32 src/wcmXCommand.c |2 +- src/xf86Wacom.c |4 ++-- src/xf86Wacom.h |4 ++-- src/xf86WacomDefs.h |2 +- 9 files changed, 32 insertions(+), 33 deletions(-) -- 1.7.10.2 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
