Re: [Linuxwacom-devel] [xf86-input-wacom PATCH 1/4] Support up to 16 touch points
On Thu, Nov 22, 2012 at 10:53:13PM -0800, Ping Cheng wrote: On Thursday, November 22, 2012, Peter Hutterer wrote: On Wed, Nov 21, 2012 at 12:13:44PM -0800, Ping Cheng wrote: Bamboo3 and Intuos5 both support 16 fingers Signed-off-by: Ping Cheng pi...@wacom.com javascript:; --- src/xf86WacomDefs.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h index 2704f3d..7df0e95 100644 --- a/src/xf86WacomDefs.h +++ b/src/xf86WacomDefs.h @@ -397,7 +397,7 @@ extern WacomDeviceClass gWacomISDV4Device; #define TILT_REQUEST_FLAG 1 #define TILT_ENABLED_FLAG 2 -#define MAX_CHANNELS 15 +#define MAX_CHANNELS 17 #define PAD_CHANNEL (MAX_CHANNELS-1) #define MAX_FINGERS (MAX_CHANNELS-1) Reviewed-by: Peter Hutterer peter.hutte...@who-t.net javascript:; for this change, Please merge this one now so we do not break Bamboo3 and Intuos5 support, although I do not think there are many people using their fingers and toes on their tablets except for testing ;). pushed 0c417e3..38018e9 master - master Cheers, Peter but can we swap this around to define MAX_FINGERS as number and the MAX_CHANNELS is based on MAX_FINGERS + 1? that seems more intuitive, We'll have to come back to these defines since we need to consider the case that pen, touch, and pad events are all reported on the same logical port. This is related to a new feature that I think the driver should support - reporting touch events while pen is in prox. XI2 made this support possible. But it requires more changes to the driver, which I do not have time to work on yet. Ping -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [xf86-input-wacom PATCH 1/4] Support up to 16 touch points
On Thursday, November 22, 2012, Peter Hutterer wrote: On Wed, Nov 21, 2012 at 12:13:44PM -0800, Ping Cheng wrote: Bamboo3 and Intuos5 both support 16 fingers Signed-off-by: Ping Cheng pi...@wacom.com javascript:; --- src/xf86WacomDefs.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h index 2704f3d..7df0e95 100644 --- a/src/xf86WacomDefs.h +++ b/src/xf86WacomDefs.h @@ -397,7 +397,7 @@ extern WacomDeviceClass gWacomISDV4Device; #define TILT_REQUEST_FLAG 1 #define TILT_ENABLED_FLAG 2 -#define MAX_CHANNELS 15 +#define MAX_CHANNELS 17 #define PAD_CHANNEL (MAX_CHANNELS-1) #define MAX_FINGERS (MAX_CHANNELS-1) Reviewed-by: Peter Hutterer peter.hutte...@who-t.net javascript:; for this change, Please merge this one now so we do not break Bamboo3 and Intuos5 support, although I do not think there are many people using their fingers and toes on their tablets except for testing ;). but can we swap this around to define MAX_FINGERS as number and the MAX_CHANNELS is based on MAX_FINGERS + 1? that seems more intuitive, We'll have to come back to these defines since we need to consider the case that pen, touch, and pad events are all reported on the same logical port. This is related to a new feature that I think the driver should support - reporting touch events while pen is in prox. XI2 made this support possible. But it requires more changes to the driver, which I do not have time to work on yet. Ping -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [xf86-input-wacom PATCH 1/4] Support up to 16 touch points
Bamboo3 and Intuos5 both support 16 fingers Signed-off-by: Ping Cheng pi...@wacom.com --- src/xf86WacomDefs.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h index 2704f3d..7df0e95 100644 --- a/src/xf86WacomDefs.h +++ b/src/xf86WacomDefs.h @@ -397,7 +397,7 @@ extern WacomDeviceClass gWacomISDV4Device; #define TILT_REQUEST_FLAG 1 #define TILT_ENABLED_FLAG 2 -#define MAX_CHANNELS 15 +#define MAX_CHANNELS 17 #define PAD_CHANNEL (MAX_CHANNELS-1) #define MAX_FINGERS (MAX_CHANNELS-1) -- 1.7.10.4 -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
