Re: [Linuxwacom-devel] libwacom: [PATCH] data: rename serial WACf004 to generic serial
On Tue, Dec 04, 2012 at 11:29:34AM +0100, Olivier Fourdan wrote: Hi, It's been reported [1] that some serial tablet are wrongly seen as Wacom Serial Tablet WACf004. Looking at the device definition in libwacom, it appears that the DeviceMatch for the serial-wacf004.tablet is serial:: so I suspect any unknown serial tablet will be reported as a WACf004. The attached patch therefore changes the current definition of serial-wacf004.tablet to a more generic dfefintion, thus the name generic-serial.tablet and the new name Generic Serial Tablet. Would that be better? in theory, but make check fails once I apply this patch. Haven't looked at it in detail though. Cheers, Peter [1] https://bugzilla.gnome.org/show_bug.cgi?id=688317#c5 From 914aa387b4ef816703326633289336100b664c89 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan ofour...@redhat.com Date: Tue, 4 Dec 2012 11:21:30 +0100 Subject: [PATCH] data: rename serial WACf004 to generic serial The definition of the serial-wacf004.tablet does not specify any device match, so any generic serial tablet would be reported as a WACf004 serial tablet. Renamed serial-wacf004.tablet to generic-serial.tablet and changed the name to Generic serial tablet Signed-off-by: Olivier Fourdan ofour...@redhat.com --- data/generic-serial.tablet | 10 ++ data/serial-wacf004.tablet | 10 -- 2 files changed, 10 insertions(+), 10 deletions(-) create mode 100644 data/generic-serial.tablet delete mode 100644 data/serial-wacf004.tablet diff --git a/data/generic-serial.tablet b/data/generic-serial.tablet new file mode 100644 index 000..275375c --- /dev/null +++ b/data/generic-serial.tablet @@ -0,0 +1,10 @@ +[Device] +Name=Generic Serial Tablet +DeviceMatch=serial:: +Class=ISDV4 +IntegratedIn=Display;System + +[Features] +Stylus=true +Ring=false +Buttons=0 diff --git a/data/serial-wacf004.tablet b/data/serial-wacf004.tablet deleted file mode 100644 index e2b5f74..000 --- a/data/serial-wacf004.tablet +++ /dev/null @@ -1,10 +0,0 @@ -[Device] -Name=Wacom Serial Tablet WACf004 -DeviceMatch=serial:: -Class=ISDV4 -IntegratedIn=Display;System - -[Features] -Stylus=true -Ring=false -Buttons=0 -- 1.7.1 -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] libwacom: [PATCH] data: rename serial WACf004 to generic serial
Hi, It's been reported [1] that some serial tablet are wrongly seen as Wacom Serial Tablet WACf004. Looking at the device definition in libwacom, it appears that the DeviceMatch for the serial-wacf004.tablet is serial:: so I suspect any unknown serial tablet will be reported as a WACf004. The attached patch therefore changes the current definition of serial-wacf004.tablet to a more generic dfefintion, thus the name generic-serial.tablet and the new name Generic Serial Tablet. Would that be better? Cheers, Olivier. -- [1] https://bugzilla.gnome.org/show_bug.cgi?id=688317#c5 From 914aa387b4ef816703326633289336100b664c89 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan ofour...@redhat.com Date: Tue, 4 Dec 2012 11:21:30 +0100 Subject: [PATCH] data: rename serial WACf004 to generic serial The definition of the serial-wacf004.tablet does not specify any device match, so any generic serial tablet would be reported as a WACf004 serial tablet. Renamed serial-wacf004.tablet to generic-serial.tablet and changed the name to Generic serial tablet Signed-off-by: Olivier Fourdan ofour...@redhat.com --- data/generic-serial.tablet | 10 ++ data/serial-wacf004.tablet | 10 -- 2 files changed, 10 insertions(+), 10 deletions(-) create mode 100644 data/generic-serial.tablet delete mode 100644 data/serial-wacf004.tablet diff --git a/data/generic-serial.tablet b/data/generic-serial.tablet new file mode 100644 index 000..275375c --- /dev/null +++ b/data/generic-serial.tablet @@ -0,0 +1,10 @@ +[Device] +Name=Generic Serial Tablet +DeviceMatch=serial:: +Class=ISDV4 +IntegratedIn=Display;System + +[Features] +Stylus=true +Ring=false +Buttons=0 diff --git a/data/serial-wacf004.tablet b/data/serial-wacf004.tablet deleted file mode 100644 index e2b5f74..000 --- a/data/serial-wacf004.tablet +++ /dev/null @@ -1,10 +0,0 @@ -[Device] -Name=Wacom Serial Tablet WACf004 -DeviceMatch=serial:: -Class=ISDV4 -IntegratedIn=Display;System - -[Features] -Stylus=true -Ring=false -Buttons=0 -- 1.7.1 -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] libwacom: [PATCH] data: rename serial WACf004 to generic serial
On Tue, Dec 4, 2012 at 2:29 AM, Olivier Fourdan ofour...@redhat.com wrote: Hi, It's been reported [1] that some serial tablet are wrongly seen as Wacom Serial Tablet WACf004. Looking at the device definition in libwacom, it appears that the DeviceMatch for the serial-wacf004.tablet is serial:: so I suspect any unknown serial tablet will be reported as a WACf004. I wonder how a serial device ever gets a serial::. We assign vendor id and device id to all serial devices in the kernel and X drivers. The attached patch therefore changes the current definition of serial-wacf004.tablet to a more generic dfefintion, thus the name generic-serial.tablet and the new name Generic Serial Tablet. If we have no idea about the device id, we can not tell the device type and its supported feature. Naming it generic is a good choice. Reviewed-by: Ping Cheng pingli...@gmail.com Ping -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
