[Lldb-commits] [lldb] r226244 - Fixes to DNBArchImpl in debugserver to correctly get/set
Author: jmolenda
Date: Thu Jan 15 20:31:35 2015
New Revision: 226244
URL: http://llvm.org/viewvc/llvm-project?rev=226244&view=rev
Log:
Fixes to DNBArchImpl in debugserver to correctly get/set
the register state when debugging AArch32 programs (armv7
programs running on an armv8 processor). Most notably,
there is no "fpscr" register in the register context -
there is an fpsr and an fpcr.
Also fix a bug where the floating point values could not
be written in armv7 processes.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp
lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.h
Modified: lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp?rev=226244&r1=226243&r2=226244&view=diff
==
--- lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp Thu Jan 15
20:31:35 2015
@@ -234,9 +234,62 @@ DNBArchMachARM::GetVFPState(bool force)
if (!force && m_state.GetError(set, Read) == KERN_SUCCESS)
return KERN_SUCCESS;
+kern_return_t kret;
+
+#if defined (__arm64__) || defined (__aarch64__)
+// Read the registers from our thread
+mach_msg_type_number_t count = ARM_NEON_STATE_COUNT;
+kret = ::thread_get_state(m_thread->MachPortNumber(), ARM_NEON_STATE,
(thread_state_t)&m_state.context.vfp, &count);
+if (DNBLogEnabledForAny (LOG_THREAD))
+{
+DNBLogThreaded("thread_get_state(0x%4.4x, %u, &vfp, %u) => 0x%8.8x
(count = %u) regs"
+ "\n q0 = 0x%16.16llx%16.16llx"
+ "\n q1 = 0x%16.16llx%16.16llx"
+ "\n q2 = 0x%16.16llx%16.16llx"
+ "\n q3 = 0x%16.16llx%16.16llx"
+ "\n q4 = 0x%16.16llx%16.16llx"
+ "\n q5 = 0x%16.16llx%16.16llx"
+ "\n q6 = 0x%16.16llx%16.16llx"
+ "\n q7 = 0x%16.16llx%16.16llx"
+ "\n q8 = 0x%16.16llx%16.16llx"
+ "\n q9 = 0x%16.16llx%16.16llx"
+ "\n q10 = 0x%16.16llx%16.16llx"
+ "\n q11 = 0x%16.16llx%16.16llx"
+ "\n q12 = 0x%16.16llx%16.16llx"
+ "\n q13 = 0x%16.16llx%16.16llx"
+ "\n q14 = 0x%16.16llx%16.16llx"
+ "\n q15 = 0x%16.16llx%16.16llx"
+ "\n fpsr = 0x%8.8x"
+ "\n fpcr = 0x%8.8x\n\n",
+ m_thread->MachPortNumber(),
+ ARM_NEON_STATE,
+ ARM_NEON_STATE_COUNT,
+ kret,
+ count,
+ ((uint64_t *)&m_state.context.vfp.__v[0])[0] ,
((uint64_t *)&m_state.context.vfp.__v[0])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[1])[0] ,
((uint64_t *)&m_state.context.vfp.__v[1])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[2])[0] ,
((uint64_t *)&m_state.context.vfp.__v[2])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[3])[0] ,
((uint64_t *)&m_state.context.vfp.__v[3])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[4])[0] ,
((uint64_t *)&m_state.context.vfp.__v[4])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[5])[0] ,
((uint64_t *)&m_state.context.vfp.__v[5])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[6])[0] ,
((uint64_t *)&m_state.context.vfp.__v[6])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[7])[0] ,
((uint64_t *)&m_state.context.vfp.__v[7])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[8])[0] ,
((uint64_t *)&m_state.context.vfp.__v[8])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[9])[0] ,
((uint64_t *)&m_state.context.vfp.__v[9])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[10])[0],
((uint64_t *)&m_state.context.vfp.__v[10])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[11])[0],
((uint64_t *)&m_state.context.vfp.__v[11])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[12])[0],
((uint64_t *)&m_state.context.vfp.__v[12])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[13])[0],
((uint64_t *)&m_state.context.vfp.__v[13])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[14])[0],
((uint64_t *)&m_state.context.vfp.__v[14])[1],
+ ((uint64_t *)&m_state.context.vfp.__v[15])[0],
((uint64_t *)&m_state.context.vfp.__v[15])[1],
+ m_state.context.vfp.__fpsr,
+ m_state.context.vfp.__fpcr);
+
+}
+#else
// Read the registers from our thread
mach_msg_type_
Re: [Lldb-commits] [PATCH] LLGS Android target support
Comment at: cmake/LLDBDependencies.cmake:100
@@ +99,3 @@
+if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )
+ set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
+ add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
This doesn't look correct. Now every file that includes LLDBDependencies will
have a custom command that builds tools/lldb/source/LLDB_vers.c. With ninja,
this causes "ninja: warning: multiple rules generate
tools/lldb/source/LLDB_vers.c. builds involving this target will not be
correct; continuing anyway" for example (since there's more than one
CMakeLists.txt that includes LLDBDependencies.txt).
Maybe this rule could stay where it was?
http://reviews.llvm.org/D6166
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Add Socket::Get[Remote/Local]IpAddress and unit tests
REPOSITORY
rL LLVM
http://reviews.llvm.org/D6917
Files:
lldb/trunk/gtest/gtest.xcodeproj/project.pbxproj
lldb/trunk/gtest/unittest/Host/Makefile
lldb/trunk/gtest/unittest/Host/SocketAddressTest.cpp
lldb/trunk/gtest/unittest/Host/SocketTest.cpp
lldb/trunk/gtest/unittest/Host/SocketTestMock.cpp
lldb/trunk/include/lldb/Host/Socket.h
lldb/trunk/include/lldb/Host/SocketAddress.h
lldb/trunk/source/Host/common/Socket.cpp
lldb/trunk/source/Host/common/SocketAddress.cpp
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: lldb/trunk/gtest/unittest/Host/SocketTest.cpp
===
--- lldb/trunk/gtest/unittest/Host/SocketTest.cpp
+++ lldb/trunk/gtest/unittest/Host/SocketTest.cpp
@@ -0,0 +1,132 @@
+//===-- SocketTest.cpp --*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include
+
+#include "gtest/gtest.h"
+
+#include "lldb/Host/Socket.h"
+
+class SocketTest: public ::testing::Test
+{
+};
+
+using namespace lldb_private;
+
+void AcceptThread (Socket* listen_socket,
+ const char* listen_remote_address,
+ bool child_processes_inherit,
+ Socket** accept_socket,
+ Error* error)
+{
+*error = listen_socket->BlockingAccept (listen_remote_address, child_processes_inherit, *accept_socket);
+}
+
+void CreateConnectedSockets (std::unique_ptr* a_up, std::unique_ptr* b_up)
+{
+Predicate port_predicate;
+// Used when binding to port zero to wait for the thread
+// that creates the socket, binds and listens to resolve
+// the port number.
+
+port_predicate.SetValue (0, eBroadcastNever);
+
+bool child_processes_inherit = false;
+Socket *socket = nullptr;
+const char* listen_remote_address = "localhost:0";
+Error error = Socket::TcpListen (listen_remote_address, child_processes_inherit, socket, &port_predicate);
+std::unique_ptr listen_socket_up (socket);
+socket = nullptr;
+EXPECT_FALSE (error.Fail ());
+EXPECT_NE (nullptr, listen_socket_up.get ());
+EXPECT_TRUE (listen_socket_up->IsValid ());
+
+Error accept_error;
+Socket* accept_socket;
+std::thread accept_thread (AcceptThread,
+ listen_socket_up.get (),
+ listen_remote_address,
+ child_processes_inherit,
+ &accept_socket,
+ &accept_error);
+
+char connect_remote_address[64];
+snprintf (connect_remote_address, sizeof (connect_remote_address), "localhost:%u", port_predicate.GetValue ());
+error = Socket::TcpConnect (connect_remote_address, child_processes_inherit, socket);
+a_up->reset (socket);
+socket = nullptr;
+EXPECT_TRUE (error.Success ());
+EXPECT_NE (nullptr, a_up->get ());
+EXPECT_TRUE ((*a_up)->IsValid ());
+
+accept_thread.join ();
+b_up->reset (accept_socket);
+EXPECT_TRUE (accept_error.Success ());
+EXPECT_NE (nullptr, b_up->get ());
+EXPECT_TRUE ((*b_up)->IsValid ());
+
+listen_socket_up.reset ();
+}
+
+TEST_F (SocketTest, DecodeHostAndPort)
+{
+std::string host_str;
+std::string port_str;
+int32_t port;
+Error error;
+EXPECT_TRUE (Socket::DecodeHostAndPort ("localhost:1138", host_str, port_str, port, &error));
+EXPECT_STREQ ("localhost", host_str.c_str ());
+EXPECT_STREQ ("1138", port_str.c_str ());
+EXPECT_EQ (1138, port);
+EXPECT_TRUE (error.Success ());
+
+EXPECT_FALSE (Socket::DecodeHostAndPort ("google.com:65536", host_str, port_str, port, &error));
+EXPECT_TRUE (error.Fail ());
+EXPECT_STREQ ("invalid host:port specification: 'google.com:65536'", error.AsCString ());
+
+EXPECT_FALSE (Socket::DecodeHostAndPort ("google.com:-1138", host_str, port_str, port, &error));
+EXPECT_TRUE (error.Fail ());
+EXPECT_STREQ ("invalid host:port specification: 'google.com:-1138'", error.AsCString ());
+
+EXPECT_TRUE (Socket::DecodeHostAndPort ("12345", host_str, port_str, port, &error));
+EXPECT_STREQ ("", host_str.c_str ());
+EXPECT_STREQ ("12345", port_str.c_str ());
+EXPECT_EQ (12345, port);
+EXPECT_TRUE (error.Success ());
+
+EXPECT_TRUE (Socket::DecodeHostAndPort ("*:0", host_str, port_str, port, &error));
+EXPECT_STREQ ("*", host_str.c_str ());
+EXPECT_STREQ ("0", port_str.c_str ());
+EXPECT_EQ (0, port);
+EXPECT_TRUE (error.Success ());
+
+}
+
+TEST_F (SocketTest, Listen0ConnectAccept)
+{
+std::unique_ptr socket_a_up;
+std::unique_ptr socket_
Re: [Lldb-commits] [PATCH] Add Socket::Get[Remote/Local]IpAddress and unit tests
You removed a comment from line 1 of source/Host/common/Socket.cpp. Fix that and it will be good to go. http://reviews.llvm.org/D6917 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r226231 - Add comment regarding which i386 registers are non-volatile instead of
Author: jmolenda
Date: Thu Jan 15 18:27:25 2015
New Revision: 226231
URL: http://llvm.org/viewvc/llvm-project?rev=226231&view=rev
Log:
Add comment regarding which i386 registers are non-volatile instead of
just pointing to the standard document regarding this.
Modified:
lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
Modified: lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp?rev=226231&r1=226230&r2=226231&view=diff
==
--- lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp Thu Jan 15
18:27:25 2015
@@ -786,6 +786,11 @@ ABIMacOSX_i386::RegisterIsVolatile (cons
}
// v.
http://developer.apple.com/library/mac/#documentation/developertools/Conceptual/LowLevelABI/130-IA-32_Function_Calling_Conventions/IA32.html#//apple_ref/doc/uid/TP40002492-SW4
+//
+// This document ("OS X ABI Function Call Guide", chapter "IA-32 Function
Calling Conventions")
+// says that the following registers on i386 are preserved aka non-volatile
aka callee-saved:
+//
+// ebx, ebp, esi, edi, esp
bool
ABIMacOSX_i386::RegisterIsCalleeSaved (const RegisterInfo *reg_info)
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r226218 - Fixed the regex test case after recent modifications to the "help" command output.
Author: gclayton
Date: Thu Jan 15 16:52:17 2015
New Revision: 226218
URL: http://llvm.org/viewvc/llvm-project?rev=226218&view=rev
Log:
Fixed the regex test case after recent modifications to the "help" command
output.
Modified:
lldb/trunk/test/functionalities/command_regex/TestCommandRegex.py
Modified: lldb/trunk/test/functionalities/command_regex/TestCommandRegex.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/command_regex/TestCommandRegex.py?rev=226218&r1=226217&r2=226218&view=diff
==
--- lldb/trunk/test/functionalities/command_regex/TestCommandRegex.py (original)
+++ lldb/trunk/test/functionalities/command_regex/TestCommandRegex.py Thu Jan
15 16:52:17 2015
@@ -36,8 +36,7 @@ class CommandRegexTestCase(TestBase):
# Help!
child.sendline('Help__')
# If we see the familiar 'help' output, the test is done.
-child.expect('The following is a list of built-in, permanent debugger
commands:')
-
+child.expect('Debugger commands:')
# Try and incorrectly remove "Help__" using "command unalias" and
verify we fail
child.sendline('command unalias Help__')
child.expect_exact("error: 'Help__' is not an alias, it is a debugger
command which can be removed using the 'command delete' command")
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Add Socket::Get[Remote/Local]IpAddress and unit tests
Replace strtoul with ConvertString::ToUInt32
Socket::DecodeHostAndPort was accepting negative port numbers and numbers >
65535, fixed
http://reviews.llvm.org/D6917
Files:
gtest/gtest.xcodeproj/project.pbxproj
gtest/unittest/Host/
gtest/unittest/Host/Makefile
gtest/unittest/Host/SocketAddressTest.cpp
gtest/unittest/Host/SocketTest.cpp
gtest/unittest/Host/SocketTestMock.cpp
include/lldb/Host/Socket.h
include/lldb/Host/SocketAddress.h
source/Host/common/Socket.cpp
source/Host/common/SocketAddress.cpp
source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: gtest/gtest.xcodeproj/project.pbxproj
===
--- gtest/gtest.xcodeproj/project.pbxproj
+++ gtest/gtest.xcodeproj/project.pbxproj
@@ -12,14 +12,19 @@
236ED33619D490B0008CA7D7 /* Makefile.rules */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = Makefile.rules; sourceTree = ""; };
33064C981A5C7A1A0033D415 /* UriParserTest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = UriParserTest.cpp; path = Utility/UriParserTest.cpp; sourceTree = ""; };
33064C9D1A5C7AC90033D415 /* do-gtest.py */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.python; path = "do-gtest.py"; sourceTree = ""; };
+ 330E475C1A609CF600FD2884 /* Makefile */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.make; name = Makefile; path = Host/Makefile; sourceTree = ""; };
+ 330E475D1A609CF600FD2884 /* SocketTest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = SocketTest.cpp; path = Host/SocketTest.cpp; sourceTree = ""; };
+ 330E475E1A60B31F00FD2884 /* SocketTestMock.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = SocketTestMock.cpp; path = Host/SocketTestMock.cpp; sourceTree = ""; };
+ 330E47621A62451800FD2884 /* SocketAddressTest.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = SocketAddressTest.cpp; path = Host/SocketAddressTest.cpp; sourceTree = ""; };
338C47F41A1E67B900B46077 /* Makefile */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.make; name = Makefile; path = Utility/Makefile; sourceTree = ""; };
338C47F51A1E67B900B46077 /* StringExtractorTest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = StringExtractorTest.cpp; path = Utility/StringExtractorTest.cpp; sourceTree = ""; };
/* End PBXFileReference section */
/* Begin PBXGroup section */
236ED32F19D4901D008CA7D7 /* unittest */ = {
isa = PBXGroup;
children = (
+330E475B1A609CDF00FD2884 /* Host */,
338C47F31A1E677900B46077 /* Utility */,
236ED33019D4903E008CA7D7 /* Plugins */,
);
@@ -68,6 +73,17 @@
);
sourceTree = "";
};
+ 330E475B1A609CDF00FD2884 /* Host */ = {
+ isa = PBXGroup;
+ children = (
+330E475E1A60B31F00FD2884 /* SocketTestMock.cpp */,
+330E475C1A609CF600FD2884 /* Makefile */,
+330E475D1A609CF600FD2884 /* SocketTest.cpp */,
+330E47621A62451800FD2884 /* SocketAddressTest.cpp */,
+ );
+ name = Host;
+ sourceTree = "";
+ };
338C47F31A1E677900B46077 /* Utility */ = {
isa = PBXGroup;
children = (
Index: gtest/unittest/Host/Makefile
===
--- /dev/null
+++ gtest/unittest/Host/Makefile
@@ -0,0 +1,32 @@
+THIS_FILE_DIR := $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST/
+
+LEVEL := $(realpath $(THIS_FILE_DIR)../../make)
+
+CFLAGS_EXTRAS := -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_CONSTANT_MACROS
+ENABLE_THREADS := YES
+# the fact that we need all of these source files to compile Socket.cpp
+# is a good indication that we need some refactoring
+CXX_SOURCES := $(wildcard *.cpp) \
+$(realpath $(LEVEL)/../../source/Core/Error.cpp) \
+$(realpath $(LEVEL)/../../source/Core/RegularExpression.cpp) \
+$(realpath $(LEVEL)/../../source/Core/Stream.cpp) \
+$(realpath $(LEVEL)/../../source/Core/StreamString.cpp) \
+$(realpath $(LEVEL)/../../source/Host/common/Socket.cpp) \
+$(realpath $(LEVEL)/../../source/Host/common/SocketAddress.cpp) \
+$(realpath $(LEVEL)/../../source/Host/common/StringConvert.cpp) \
+$(realpath $(LEVEL)/../../source/Host/common/TimeValue.cpp)
+
+OS := $(shell uname -s)
+ifeq ($(OS),Windows)
+CXX_SOURCES := $(CXX_SOURCES) \
+$(LEVEL)/../../source/Host/windows/Condition.cpp \
+$(LEVEL)/../../source/Host/windows/Mutex.cpp
+else
+CXX_SOURCES := $(CXX_SOURCES) \
+$(LEVEL)/../../source/Host/common/Condition.cpp \
+$(LEVEL)/../../source/Host/common/Mutex.cpp
+endif
+
+MAKE_DSYM := NO
+
+include $(LEVEL)/Makefile.rules
Index: gtest/unittest/Host/SocketAddressTest.cpp
==
Re: [Lldb-commits] [PATCH] UriParser - fixed potential buffer overrun
Looks good. http://reviews.llvm.org/D6918 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Moved Args::StringToXIntYZ to StringConvert::ToXIntYZ
REPOSITORY rL LLVM http://reviews.llvm.org/D6992 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r226162 - In commit clang r226096, DefinitionRequired has been removed. Do the same in lldb implementation
Thanks!
On Thu, Jan 15, 2015 at 3:50 AM, Sylvestre Ledru
wrote:
> Author: sylvestre
> Date: Thu Jan 15 05:50:50 2015
> New Revision: 226162
>
> URL: http://llvm.org/viewvc/llvm-project?rev=226162&view=rev
> Log:
> In commit clang r226096, DefinitionRequired has been removed. Do the same
> in lldb implementation
>
> Modified:
> lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h
> lldb/trunk/include/lldb/Expression/ASTStructExtractor.h
> lldb/trunk/source/Expression/ASTResultSynthesizer.cpp
> lldb/trunk/source/Expression/ASTStructExtractor.cpp
>
> Modified: lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h?rev=226162&r1=226161&r2=226162&view=diff
>
> ==
> --- lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h (original)
> +++ lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h Thu Jan 15
> 05:50:50 2015
> @@ -91,7 +91,7 @@ public:
>
> //--
> /// Passthrough stub
>
> //--
> -void HandleVTable(clang::CXXRecordDecl *RD, bool DefinitionRequired);
> +void HandleVTable(clang::CXXRecordDecl *RD);
>
>
> //--
> /// Passthrough stub
>
> Modified: lldb/trunk/include/lldb/Expression/ASTStructExtractor.h
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ASTStructExtractor.h?rev=226162&r1=226161&r2=226162&view=diff
>
> ==
> --- lldb/trunk/include/lldb/Expression/ASTStructExtractor.h (original)
> +++ lldb/trunk/include/lldb/Expression/ASTStructExtractor.h Thu Jan 15
> 05:50:50 2015
> @@ -99,7 +99,7 @@ public:
>
> //--
> /// Passthrough stub
>
> //--
> -void HandleVTable(clang::CXXRecordDecl *RD, bool DefinitionRequired);
> +void HandleVTable(clang::CXXRecordDecl *RD);
>
>
> //--
> /// Passthrough stub
>
> Modified: lldb/trunk/source/Expression/ASTResultSynthesizer.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ASTResultSynthesizer.cpp?rev=226162&r1=226161&r2=226162&view=diff
>
> ==
> --- lldb/trunk/source/Expression/ASTResultSynthesizer.cpp (original)
> +++ lldb/trunk/source/Expression/ASTResultSynthesizer.cpp Thu Jan 15
> 05:50:50 2015
> @@ -480,10 +480,10 @@ ASTResultSynthesizer::CompleteTentativeD
> }
>
> void
> -ASTResultSynthesizer::HandleVTable(CXXRecordDecl *RD, bool
> DefinitionRequired)
> +ASTResultSynthesizer::HandleVTable(CXXRecordDecl *RD)
> {
> if (m_passthrough)
> -m_passthrough->HandleVTable(RD, DefinitionRequired);
> +m_passthrough->HandleVTable(RD);
> }
>
> void
>
> Modified: lldb/trunk/source/Expression/ASTStructExtractor.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ASTStructExtractor.cpp?rev=226162&r1=226161&r2=226162&view=diff
>
> ==
> --- lldb/trunk/source/Expression/ASTStructExtractor.cpp (original)
> +++ lldb/trunk/source/Expression/ASTStructExtractor.cpp Thu Jan 15
> 05:50:50 2015
> @@ -186,10 +186,10 @@ ASTStructExtractor::CompleteTentativeDef
> }
>
> void
> -ASTStructExtractor::HandleVTable(CXXRecordDecl *RD, bool
> DefinitionRequired)
> +ASTStructExtractor::HandleVTable(CXXRecordDecl *RD)
> {
> if (m_passthrough)
> -m_passthrough->HandleVTable(RD, DefinitionRequired);
> +m_passthrough->HandleVTable(RD);
> }
>
> void
>
>
> ___
> lldb-commits mailing list
> lldb-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r226162 - In commit clang r226096, DefinitionRequired has been removed. Do the same in lldb implementation
Author: sylvestre
Date: Thu Jan 15 05:50:50 2015
New Revision: 226162
URL: http://llvm.org/viewvc/llvm-project?rev=226162&view=rev
Log:
In commit clang r226096, DefinitionRequired has been removed. Do the same in
lldb implementation
Modified:
lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h
lldb/trunk/include/lldb/Expression/ASTStructExtractor.h
lldb/trunk/source/Expression/ASTResultSynthesizer.cpp
lldb/trunk/source/Expression/ASTStructExtractor.cpp
Modified: lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h?rev=226162&r1=226161&r2=226162&view=diff
==
--- lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h (original)
+++ lldb/trunk/include/lldb/Expression/ASTResultSynthesizer.h Thu Jan 15
05:50:50 2015
@@ -91,7 +91,7 @@ public:
//--
/// Passthrough stub
//--
-void HandleVTable(clang::CXXRecordDecl *RD, bool DefinitionRequired);
+void HandleVTable(clang::CXXRecordDecl *RD);
//--
/// Passthrough stub
Modified: lldb/trunk/include/lldb/Expression/ASTStructExtractor.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ASTStructExtractor.h?rev=226162&r1=226161&r2=226162&view=diff
==
--- lldb/trunk/include/lldb/Expression/ASTStructExtractor.h (original)
+++ lldb/trunk/include/lldb/Expression/ASTStructExtractor.h Thu Jan 15 05:50:50
2015
@@ -99,7 +99,7 @@ public:
//--
/// Passthrough stub
//--
-void HandleVTable(clang::CXXRecordDecl *RD, bool DefinitionRequired);
+void HandleVTable(clang::CXXRecordDecl *RD);
//--
/// Passthrough stub
Modified: lldb/trunk/source/Expression/ASTResultSynthesizer.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ASTResultSynthesizer.cpp?rev=226162&r1=226161&r2=226162&view=diff
==
--- lldb/trunk/source/Expression/ASTResultSynthesizer.cpp (original)
+++ lldb/trunk/source/Expression/ASTResultSynthesizer.cpp Thu Jan 15 05:50:50
2015
@@ -480,10 +480,10 @@ ASTResultSynthesizer::CompleteTentativeD
}
void
-ASTResultSynthesizer::HandleVTable(CXXRecordDecl *RD, bool DefinitionRequired)
+ASTResultSynthesizer::HandleVTable(CXXRecordDecl *RD)
{
if (m_passthrough)
-m_passthrough->HandleVTable(RD, DefinitionRequired);
+m_passthrough->HandleVTable(RD);
}
void
Modified: lldb/trunk/source/Expression/ASTStructExtractor.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ASTStructExtractor.cpp?rev=226162&r1=226161&r2=226162&view=diff
==
--- lldb/trunk/source/Expression/ASTStructExtractor.cpp (original)
+++ lldb/trunk/source/Expression/ASTStructExtractor.cpp Thu Jan 15 05:50:50 2015
@@ -186,10 +186,10 @@ ASTStructExtractor::CompleteTentativeDef
}
void
-ASTStructExtractor::HandleVTable(CXXRecordDecl *RD, bool DefinitionRequired)
+ASTStructExtractor::HandleVTable(CXXRecordDecl *RD)
{
if (m_passthrough)
-m_passthrough->HandleVTable(RD, DefinitionRequired);
+m_passthrough->HandleVTable(RD);
}
void
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
