Re: [Lldb-commits] [PATCH] Default to linking lldb-server statically for Android.

2015-07-02 Thread Vince Harron 
Chaoren, the fact that they are asking for rationale is a good clue that
the rationale should be captured in comments.
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Default to linking lldb-server statically for Android.

2015-07-02 Thread Tamas Berghammer 
What is the implication of this change in terms of the size of lldb-server?

You are linking statically against the system libraries (such as libc, libm, 
libdl) what might not be a portable solution if they are depending on features 
only present in some device / kernel.


http://reviews.llvm.org/D10858

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Default to linking lldb-server statically for Android.

2015-07-01 Thread Chaoren Lin 
-pie is not compatible with -static. lldb-server can work on any API if
linked statically.
On Jul 1, 2015 02:17, "Tamas Berghammer"  wrote:

> 
> Comment at: cmake/platforms/Android.cmake:98-102
> @@ -97,7 +101,2 @@
>
> -# PIE is required for API 21+ so we enable it
> -# unfortunately, it is not supported before API 14 so we need to do
> something else there
> -# see http://llvm.org/pr23457
> -set( ANDROID_CXX_FLAGS "${ANDROID_CXX_FLAGS} -pie -fPIE" )
> -
>  # linker flags
> 
> Who will specify the "-pie" flag for API 21+? Without it lldb-server won't
> work in those API levels.
>
> http://reviews.llvm.org/D10858
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits